New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664859 link

Starred by 1 user
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Jan 2017
Cc:
loyso@chromium.org
█ dstockwell@chromium.org
█ dongseon...@intel.com
enne@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

9 tests in virtual/threaded/transitions are flaky when run in random order

Project Member Reported by qyears...@chromium.org, Nov 14 2016 
The tests:

virtual/threaded/transitions/opacity-transform-transitions-inside-iframe.html
virtual/threaded/transitions/opacity-transition-zindex.html
virtual/threaded/transitions/position-background-transition.html
virtual/threaded/transitions/transition-end-event-container.html
virtual/threaded/transitions/transition-end-event-multiple-02.html
virtual/threaded/transitions/transition-end-event-transform.html
virtual/threaded/transitions/transition-end-event-unprefixed-02.html
virtual/threaded/transitions/transition-end-event-window.html
virtual/threaded/transitions/unprefixed-transform.html

appear to be flaky when run in random order. Steps to reproduce:

This should pass consistently:
Tools/Scripts/run-webkit-tests virtual/threaded/transitions

This should fail intermittently:
Tools/Scripts/run-webkit-tests virtual/threaded/transitions --order=random

We're working on removing order dependency from Blink layout tests. More context here:
https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit

Comment 1 by jeffcarp@chromium.org, Nov 14 2016

Description: Show this description

Comment 2 by dtapu...@chromium.org, Nov 14 2016

Components: -Blink>Input Blink>Animation

Comment 3 by mikelawther@chromium.org, Nov 15 2016

Labels: Test-Layout

Comment 4 by mikelawther@chromium.org, Nov 15 2016

Cc: loyso@chromium.org
Status: Available (was: Untriaged)

Comment 5 by suzyh@chromium.org, Nov 23 2016

Labels: Update-Fortnightly

Comment 6 by suzyh@chromium.org, Nov 23 2016

Owner: suzyh@chromium.org
Status: Started (was: Available)

Comment 7 by suzyh@chromium.org, Dec 15 2016

Owner: ericwilligers@chromium.org
Status: Assigned (was: Started)
I attempted to wrap the contents of transitions/transition-end-event-helpers.js startTest function with runAfterLayoutAndPaint (from resources/run-after-layout-and-paint.js) to reduce flakiness of the transitions/transition-end-event-* tests. On a first pass, this didn't seem to work, but I didn't spend time digging into it in more detail yet. Passing over to Eric, who has been looking at the flaky virtual/threaded/animations tests.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82fda4f8137102335b166ec1a7808d891459607e

commit 82fda4f8137102335b166ec1a7808d891459607e
Author: ericwilligers <ericwilligers@chromium.org>
Date: Wed Dec 21 03:18:12 2016

CSS Transition: Fix flaky opacity-transition-zindex.html

We wait for the compositor before announcing the test has completed.

BUG= 664859 

Review-Url: https://codereview.chromium.org/2591623002
Cr-Commit-Position: refs/heads/master@{#439997}

[modify] https://crrev.com/82fda4f8137102335b166ec1a7808d891459607e/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/233f57ab4869984231b841dc58dff2dde3545072/third_party/WebKit/LayoutTests/platform/mac/transitions/opacity-transition-zindex-expected.png
[delete] https://crrev.com/233f57ab4869984231b841dc58dff2dde3545072/third_party/WebKit/LayoutTests/platform/mac/virtual/threaded/transitions/opacity-transition-zindex-expected.png
[delete] https://crrev.com/233f57ab4869984231b841dc58dff2dde3545072/third_party/WebKit/LayoutTests/platform/win/transitions/opacity-transition-zindex-expected.png
[delete] https://crrev.com/233f57ab4869984231b841dc58dff2dde3545072/third_party/WebKit/LayoutTests/platform/win/virtual/threaded/transitions/opacity-transition-zindex-expected.png
[add] https://crrev.com/82fda4f8137102335b166ec1a7808d891459607e/third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex-expected.png
[modify] https://crrev.com/82fda4f8137102335b166ec1a7808d891459607e/third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex-expected.txt
[modify] https://crrev.com/82fda4f8137102335b166ec1a7808d891459607e/third_party/WebKit/LayoutTests/transitions/opacity-transition-zindex.html
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc4fbc3299c9a473b7c153ea5213f80a181f93a8

commit bc4fbc3299c9a473b7c153ea5213f80a181f93a8
Author: ericwilligers <ericwilligers@chromium.org>
Date: Tue Jan 03 01:08:15 2017

CSS Transitions: Reduce time taken by transition-end-event tests

Transitions have been reduced from 500ms to about 100ms, to avoid
timeouts.

BUG=248938, 664859 

Review-Url: https://codereview.chromium.org/2602163002
Cr-Commit-Position: refs/heads/master@{#441082}

[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-container-expected.txt
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-container.html
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-multiple-02-expected.txt
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-multiple-02.html
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-multiple-03-expected.txt
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-multiple-03.html
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-transform-expected.txt
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-transform.html
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-unprefixed-01-expected.txt
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-unprefixed-01.html
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-unprefixed-02-expected.txt
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-unprefixed-02.html
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-window-expected.txt
[modify] https://crrev.com/bc4fbc3299c9a473b7c153ea5213f80a181f93a8/third_party/WebKit/LayoutTests/transitions/transition-end-event-window.html

Comment 13 by ericwilligers@chromium.org, Jan 4 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment