6 tests in virtual/threaded/fast/scroll-behavior are flaky when run in random order |
||||||
Issue descriptionThe tests: virtual/threaded/fast/scroll-behavior/overflow-scroll-animates.html virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-added.html virtual/threaded/fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-anchors.html virtual/threaded/fast/scroll-behavior/smooth-scroll/ongoing-smooth-scroll-vertical-rl-anchors.html virtual/threaded/fast/scroll-behavior/smooth-scroll/scroll-during-selection.html appear to be flaky when run in random order. Steps to reproduce: This should pass consistently: Tools/Scripts/run-webkit-tests virtual/threaded/fast/scroll-behavior This should fail intermittently: Tools/Scripts/run-webkit-tests virtual/threaded/fast/scroll-behavior --order=random We're working on removing order dependency from Blink layout tests. More context here: https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit
,
Nov 14 2016
chaopeng@ can you investigate this?
,
Nov 14 2016
,
Nov 14 2016
OK
,
Nov 14 2016
low priority though
,
Nov 14 2016
Something about threaded compositing makes smooth scroll tests flaky even in regular order. Many of them are disabled in TestExpectations for this reason. See issue 587165 , issue 593568 , issue 624247 , and issue 636961 .
,
May 23 2017
,
Aug 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bca475d1bc6cb1ae4208a69a05199a249730c26 commit 3bca475d1bc6cb1ae4208a69a05199a249730c26 Author: Tim 'mithro' Ansell <tansell@chromium.org> Date: Thu Aug 24 08:42:04 2017 LayoutTests: Disabling flaky main-thread-scrolling-reason-added.html test. It seems to be flaky everywhere. BUG=664858 TBR=qyearsley@chromium.org,dpranke@chromium.org,jeffcarp@chromium.org NOTRY=true Change-Id: If658415822a4e4d1ff6d500b2aec5b05d1e29448 Reviewed-on: https://chromium-review.googlesource.com/630680 Reviewed-by: Tim 'mithro' Ansell <tansell@chromium.org> Commit-Queue: Tim 'mithro' Ansell <tansell@chromium.org> Cr-Commit-Position: refs/heads/master@{#496987} [modify] https://crrev.com/3bca475d1bc6cb1ae4208a69a05199a249730c26/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 11 2017
,
Dec 11 2017
Raising to P1. This is causing failures on the Linux Tests bot. Sample failures: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65460 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65456 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65449 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65433 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65431 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65424 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65404 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65373 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65279
,
Dec 11 2017
,
Dec 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/135d571a1e793a2063621fc3c760d1035a2b31f3 commit 135d571a1e793a2063621fc3c760d1035a2b31f3 Author: Tom Anderson <thomasanderson@chromium.org> Date: Mon Dec 11 22:35:33 2017 Disable flaky smooth-scroll tests The tests are flaky when run in random order. Example failures: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65460 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65456 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65449 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65433 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65431 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65424 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65404 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65373 https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests/65279 BUG=664858 TBR=qyearsley@chromium.org Change-Id: I9871947f69860d308c4b2765f9e23dabbae3c3d4 Reviewed-on: https://chromium-review.googlesource.com/820100 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#523237} [modify] https://crrev.com/135d571a1e793a2063621fc3c760d1035a2b31f3/third_party/WebKit/LayoutTests/TestExpectations
,
Dec 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0945d3eb09d3fb4c833dd4da299a08873bca1a0c commit 0945d3eb09d3fb4c833dd4da299a08873bca1a0c Author: Sandra Sun <sunyunjia@chromium.org> Date: Wed Dec 13 00:50:03 2017 Rewrite horizontal-smooth-scroll-in-rtl.html The original test is written using js-test and is using shouldBecomeEqual() to verify the scroll offset after the animation, which makes it flaky. This patch rewrites the patch using testharness and promise test, and only checks after the page no longer scrolls or has reached the specified destination, which would be independent from the platform's performance, making the test robust. We separate the waitForWindowScrollEnd into scroll-animation.js so that other tests can reuse the method. We also change the input-driven scroll from clicking at scrollbar to keyboard-left so that the test passes on Mac. Bug: 664858 Change-Id: I030392484489983453bf7a11b55b05c13fa4a470 Reviewed-on: https://chromium-review.googlesource.com/822988 Reviewed-by: Eric Willigers <ericwilligers@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#523629} [modify] https://crrev.com/0945d3eb09d3fb4c833dd4da299a08873bca1a0c/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/0945d3eb09d3fb4c833dd4da299a08873bca1a0c/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html [add] https://crrev.com/0945d3eb09d3fb4c833dd4da299a08873bca1a0c/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/scroll-animation.js [delete] https://crrev.com/207b7651d583795cb62f2bfe9ae6866632d75337/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl-expected.txt [modify] https://crrev.com/0945d3eb09d3fb4c833dd4da299a08873bca1a0c/third_party/WebKit/LayoutTests/virtual/threaded/fast/scroll-behavior/smooth-scroll/horizontal-smooth-scroll-in-rtl.html
,
Dec 14 2017
horizontal-smooth-scroll-in-rtl.html flaky on https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/
,
Dec 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3101f04b41e77ff852ba65200efdcef4d9231f78 commit 3101f04b41e77ff852ba65200efdcef4d9231f78 Author: Henrik Grunell <grunell@chromium.org> Date: Thu Dec 14 13:40:13 2017 Disable flaky horizontal-smooth-scroll-in-rtl.html. TBR=sunyunjia@chromium.org Bug: 664858 Change-Id: I8d7332fdb6755347177fcf7e736e0d7f4d6e533d No-Try: true Reviewed-on: https://chromium-review.googlesource.com/827016 Reviewed-by: Henrik Grunell <grunell@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#524054} [modify] https://crrev.com/3101f04b41e77ff852ba65200efdcef4d9231f78/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 8 2018
Updating priority to reflect reality. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jeffcarp@chromium.org
, Nov 14 2016