New issue
Advanced search Search tips

Issue 664857 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

4 tests in virtual/threaded/animations are flaky when run in random order

Project Member Reported by qyears...@chromium.org, Nov 14 2016

Issue description

The tests:

virtual/threaded/animations/3d/transform-origin-vs-functions.html
virtual/threaded/animations/animation-transition-collision-crash.html
virtual/threaded/animations/composited-animations-simple.html
virtual/threaded/animations/transform-responsive-neutral-keyframe.html

appear to be flaky when run in random order. Steps to reproduce:

This should pass consistently:
Tools/Scripts/run-webkit-tests virtual/threaded/animations

This should fail intermittently:
Tools/Scripts/run-webkit-tests virtual/threaded/animations --order=random

We're working on removing order dependency from Blink layout tests. More context here:
https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit

 

Comment 1 by loyso@chromium.org, Nov 14 2016

Labels: Test-Layout Update-Quarterly OS-All
Status: Available (was: Untriaged)
Description: Show this description
Owner: ericwilligers@chromium.org
Status: Assigned (was: Available)

Comment 4 Deleted

These might be a duplicate of https://crbug.com/248938
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eca181ca7edd0aee94b03583405cf733f5a9c7e0

commit eca181ca7edd0aee94b03583405cf733f5a9c7e0
Author: ericwilligers <ericwilligers@chromium.org>
Date: Mon Dec 19 06:11:24 2016

CSS Animations: transform-responsive-neutral-keyframe.html is slow test

The test waits twice for communication to and from the compositor.

Sometimes the test times out.

BUG= 664857 

Review-Url: https://codereview.chromium.org/2587873002
Cr-Commit-Position: refs/heads/master@{#439418}

[modify] https://crrev.com/eca181ca7edd0aee94b03583405cf733f5a9c7e0/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/eca181ca7edd0aee94b03583405cf733f5a9c7e0/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/eca181ca7edd0aee94b03583405cf733f5a9c7e0/third_party/WebKit/LayoutTests/animations/transform-responsive-neutral-keyframe.html

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ddbfebc9e931593ff6ef86cd1da3bbbdad3f5a3e

commit ddbfebc9e931593ff6ef86cd1da3bbbdad3f5a3e
Author: ericwilligers <ericwilligers@chromium.org>
Date: Thu Dec 22 07:20:45 2016

CSS Animations: Reformat animation-transition-collision-crash.html

Update test to follow style guide
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_layout_tests.md

Stop marking the test as flaky, as no recent flakes have been observed.

BUG= 664857 

Review-Url: https://codereview.chromium.org/2575423002
Cr-Commit-Position: refs/heads/master@{#440350}

[modify] https://crrev.com/ddbfebc9e931593ff6ef86cd1da3bbbdad3f5a3e/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/ddbfebc9e931593ff6ef86cd1da3bbbdad3f5a3e/third_party/WebKit/LayoutTests/animations/animation-transition-collision-crash.html

Project Member

Comment 9 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50b12df39a684cea45639d2d758a9b6dbd6d16df

commit 50b12df39a684cea45639d2d758a9b6dbd6d16df
Author: ericwilligers <ericwilligers@chromium.org>
Date: Wed Jan 04 00:00:09 2017

CSS Animations: Fix flaky composited-animations-simple.html

We wait for the compositor before declaring the test complete.

BUG= 664857 

Review-Url: https://codereview.chromium.org/2607853003
Cr-Commit-Position: refs/heads/master@{#441256}

[modify] https://crrev.com/50b12df39a684cea45639d2d758a9b6dbd6d16df/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/50b12df39a684cea45639d2d758a9b6dbd6d16df/third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js

Status: Fixed (was: Assigned)
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa8b12920e8c2042e47816d004b113c155e81aee

commit fa8b12920e8c2042e47816d004b113c155e81aee
Author: Alexis Hetu <sugoi@google.com>
Date: Fri Jul 06 14:14:32 2018

Attempt to unmark some tests as slow/timeout

Now that SwiftShader is on Linux/Windows/MacOS and that a recent
performance improvement has been landed in SwiftShader, verify
which tests still require the Slow/Timeout markers and which don't.

TBR=kbr@chromium.org

Bug:chromium:24182  chromium:433711  chromium:763197  chromium:311482   chromium:243871   chromium:664857   chromium:9798   chromium:237270   chromium:241576   chromium:241869   chromium:246749   chromium:535478   chromium:363029   chromium:364225   chromium:552556   chromium:570656   chromium:584807  chromium:614910  chromium:791659   chromium:726075   chromium:808153  chromium:816045  chromium:693568  chromium:626703 chromium:703533 chromium:786641  chromium:799137   chromium:831686   chromium:831230  chromium:818324  chromium:810437   chromium:847205  chromium:848799  chromium:828962   chromium:849284   chromium:855055 

Change-Id: I5d36d20bd87b234fefe4da3ea7e4af039c0188cb
Reviewed-on: https://chromium-review.googlesource.com/1102341
Reviewed-by: Alexis Hétu <sugoi@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#572962}
[modify] https://crrev.com/fa8b12920e8c2042e47816d004b113c155e81aee/third_party/WebKit/LayoutTests/SlowTests
[modify] https://crrev.com/fa8b12920e8c2042e47816d004b113c155e81aee/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment