svg/dom/transform-parser.html is flaky when run with random order |
||||||
Issue descriptionThe test: svg/dom/transform-parser.html appears to be flaky when run in random order. Steps to reproduce: This should pass consistently: Tools/Scripts/run-webkit-tests svg/dom This should fail intermittently: Tools/Scripts/run-webkit-tests svg/dom --order=random We're working on removing order dependency from Blink layout tests. More context here: https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit
,
Nov 14 2016
,
Nov 29 2016
,
Dec 8 2016
,
Jan 17 2017
,
Jan 18 2017
The flakiness dashboard [1] doesn't show anything interesting for this test. There's some seemingly old diff showing messages like: CONSOLE WARNING: Long running JavaScript task took XXXms. So maybe that is the source of the original failures. Besides a few timeouts all appears green. Maybe we should just tentatively drop the line from expectations. [1] http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=svg%2Fdom%2Ftransform-parser.html
,
Jan 18 2017
It's totally reasonable to just drop the expectations line and see what happens. I would support that. You should, however, add it to SlowTests for Linux Debug, or look into splitting it into 2 tests if it's amenable to that.
,
Jan 18 2017
Yes, this test could probably be split without too much trouble. I'll start with two pieces...
,
Jan 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e800d7672ea681b08ecad44d273d3db1689af1c commit 7e800d7672ea681b08ecad44d273d3db1689af1c Author: fs <fs@opera.com> Date: Wed Jan 18 18:10:30 2017 Split svg/dom/transform-parser.html This CL splits the mentioned test into two to alleviate the potential for test timeouts. The bulk of the test is moved to a JS file, and the js-test dependency is dropped since the only useful output of this test is the console log generated. The TestExpectations entry is dropped. BUG= 664849 Review-Url: https://codereview.chromium.org/2646503002 Cr-Commit-Position: refs/heads/master@{#444418} [modify] https://crrev.com/7e800d7672ea681b08ecad44d273d3db1689af1c/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/5b45dc22297adb1eba7518c2731ec1de87513e99/third_party/WebKit/LayoutTests/platform/android/svg/dom/transform-parser-expected.txt [add] https://crrev.com/7e800d7672ea681b08ecad44d273d3db1689af1c/third_party/WebKit/LayoutTests/svg/dom/resources/transform-parser-fuzzer.js [add] https://crrev.com/7e800d7672ea681b08ecad44d273d3db1689af1c/third_party/WebKit/LayoutTests/svg/dom/transform-parser-2-expected.txt [add] https://crrev.com/7e800d7672ea681b08ecad44d273d3db1689af1c/third_party/WebKit/LayoutTests/svg/dom/transform-parser-2.html [delete] https://crrev.com/5b45dc22297adb1eba7518c2731ec1de87513e99/third_party/WebKit/LayoutTests/svg/dom/transform-parser-expected.png [modify] https://crrev.com/7e800d7672ea681b08ecad44d273d3db1689af1c/third_party/WebKit/LayoutTests/svg/dom/transform-parser-expected.txt [modify] https://crrev.com/7e800d7672ea681b08ecad44d273d3db1689af1c/third_party/WebKit/LayoutTests/svg/dom/transform-parser.html
,
Jan 19 2017
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by f...@opera.com
, Nov 14 2016