New issue
Advanced search Search tips

Issue 664844 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

3 tests in media/track/ are flaky when run in random order

Project Member Reported by qyears...@chromium.org, Nov 14 2016

Issue description

The tests:

media/track/track-cue-rendering-tree-is-removed-properly.html
media/track/track-default-attribute.html
media/track/track-kind-user-preference.html

appear to be flaky when run in random order. Steps to reproduce:

This should pass consistently:
Tools/Scripts/run-webkit-tests media/track

This should fail intermittently:
Tools/Scripts/run-webkit-tests media/track --order=random

We're working on removing order dependency from Blink layout tests. More context here:
https://docs.google.com/document/d/11-628Ny6hY__kfIv__zVD0m3rA0OB9tQLLC_gJI_PNg/edit
 
Description: Show this description
Labels: FlakyLayoutMediaTest
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cb72612ac8ba4e959986c8a2eb9d5babfa53e2e

commit 1cb72612ac8ba4e959986c8a2eb9d5babfa53e2e
Author: Fredrik Söderquist <fs@opera.com>
Date: Wed Nov 08 09:58:30 2017

Fix media/track/track-cue-rendering-tree-is-removed-properly.html

The way media/track/track-cue-rendering-tree-is-removed-properly.html is
using assert_throws is no longer valid, so replace it with a different
construct.
Also, <track> does not have a 'mode' content attribute. Using 'default
here seems like it should DTRT.

Bug:  664844 
Change-Id: I7cf035dc262160f4748a22f7f92fbc45c2bfe13b
Reviewed-on: https://chromium-review.googlesource.com/756848
Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#514789}
[modify] https://crrev.com/1cb72612ac8ba4e959986c8a2eb9d5babfa53e2e/third_party/WebKit/LayoutTests/media/track/track-cue-rendering-tree-is-removed-properly.html

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e1293d3bbd46e8a7ea9ab4803e1bfa81e56c77c

commit 4e1293d3bbd46e8a7ea9ab4803e1bfa81e56c77c
Author: Fredrik Söderquist <fs@opera.com>
Date: Mon Nov 13 10:45:11 2017

Explicitly reset preferred lang and text track state in media/track

Add cleanup handlers that resets "user preferred languages" and "text
track kind user preference", or just reset them outright, to see if this
has any bearing on the problem (works locally.)

Bug:  664844 
Change-Id: I6237ace717fbaf6f5203d8a051950763547e191f
Reviewed-on: https://chromium-review.googlesource.com/757102
Reviewed-by: srirama chandra sekhar <srirama.m@samsung.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#515919}
[modify] https://crrev.com/4e1293d3bbd46e8a7ea9ab4803e1bfa81e56c77c/third_party/WebKit/LayoutTests/media/track/track-kind-user-preference.html
[modify] https://crrev.com/4e1293d3bbd46e8a7ea9ab4803e1bfa81e56c77c/third_party/WebKit/LayoutTests/media/track/track-language-preference-no-crash.html
[modify] https://crrev.com/4e1293d3bbd46e8a7ea9ab4803e1bfa81e56c77c/third_party/WebKit/LayoutTests/media/track/track-language-preference.html

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/874de51f601dbec1c405e48f20efd0ec70cbdcc7

commit 874de51f601dbec1c405e48f20efd0ec70cbdcc7
Author: Fredrik Söderquist <fs@opera.com>
Date: Wed Nov 15 17:26:49 2017

Remove expectations for a few media/track tests

After https://chromium-review.googlesource.com/756848 and
https://chromium-review.googlesource.com/757102 these tests appear to
have stabilized.

TBR=srirama.m@samsung.com

Bug:  664844 
Change-Id: Ie97611e52a579e6d2f18833f5faaedef662038fc
Reviewed-on: https://chromium-review.googlesource.com/771794
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#516732}
[modify] https://crrev.com/874de51f601dbec1c405e48f20efd0ec70cbdcc7/third_party/WebKit/LayoutTests/TestExpectations

Comment 6 by f...@opera.com, Nov 15 2017

Owner: f...@opera.com
Status: Fixed (was: Untriaged)

Sign in to add a comment