New issue
Advanced search Search tips

Issue 664832 link

Starred by 1 user
Status: Fixed
Owner:
kjlubick@chromium.org
Closed: Nov 2016
Cc:
mar...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Column name should match value being filtered on

Project Member Reported by tansell@chromium.org, Nov 13 2016 
On page https://chromium-swarm-dev.appspot.com/tasklist?c=name&c=state&c=created_ts&c=user&c=bot&l=50&s=created_ts%3Adesc

A bunch of the values you select in the first column seem to have a "human name" when displayed in a table of results. 

IE "bot" == "Bot Assigned" and "user" == "Requesting User"

Can you please add;

 a) Display the human name in the selection list at the top (maybe something like "user (Requesting User)"
 b) Display the filter name in the top of the column (maybe something like "Requesting User (user)"

Thanks!

Comment 1 by kjlubick@google.com, Nov 14 2016 

I worry about this added verbosity.  My gut is that this would add a lot of unnecessary words to the page.

This is what one of my "dashboards" looks like already:
https://screenshot.googleplex.com/5atu3OYzB0A

Implementing b would make the title bar very busy.  Would you find a mouseover helpful?


What is currently confusing about the way it is now?  Is it unclear how the items in the selection list map to the columns?

Comment 2 by tansell@chromium.org, Nov 15 2016 

Mouse over might work. 

Having https://bugs.chromium.org/p/chromium/issues/detail?id=664833#c2 might also help if the order in that box always matches the order of the columns.

The question I have, is from the UI in that picture, what do I type into the box to filter on battery temp?

Comment 3 by kjlubick@google.com, Nov 15 2016 

You cannot filter on all the fields available.  The backend API only supports filtering on dimensions and quarantined/dead/alive

battery_temp (and many other attributes in a bot's _state_) are not dimensions, and thus not sortable.

Comment 4 by tansell@chromium.org, Nov 17 2016 

Well, that is an example of something the UI is hiding and confusing to the user :)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 17 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3

commit be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3
Author: kjlubick <kjlubick@google.com>
Date: Thu Nov 17 20:11:48 2016

Add informational messages to clarify what can be filtered on.

These informational messages should clarify that users can only filter
on tags and dimensions.

This adjusts the "float selected columns to the top" to sort those
floated columns in the order they are displayed.

This adds ... at the bottom of the task list to clarify that
not all options are givin for sorting tags (due to memory constraints).

This changes sort order a bit.  "none" now sorts at the bottom (like
ZZZ) which makes it less obnoxious than being in the middle.

This adds internal_ip to visually see what ip addresses have been
assigned.

BUG= 665277 , 664832 

Review-Url: https://codereview.chromium.org/2513613002

[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/botlist/bot-filters.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/botlist/bot-list-shared-behavior.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/botlist/bot-list.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/common/dynamic-table-behavior.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/common/query-column-filter-behavior.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/tasklist/task-filters.html
[modify] https://crrev.com/be7bdd7b286c076e6405ab13cf44d4bb1ff2e0e3/appengine/swarming/ui/res/imp/tasklist/task-list.html

Comment 6 by kjlubick@chromium.org, Nov 17 2016

Status: Fixed (was: Assigned)
Message added about what is sortable.  Order in the box matches column display order.

This is live on chromium-swarm.
►

Sign in to add a comment