New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664829 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 664830
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

oldui link should preserve the page it is currently on

Project Member Reported by tansell@chromium.org, Nov 13 2016

Issue description

The new UI is pretty good but occasionally I want to compare something on the old UI.

Clicking the old UI link takes me to the root location. It would be good if it took me to the same information.
 

Comment 1 by kjlubick@google.com, Nov 14 2016

Cc: mar...@chromium.org
Mergedinto: 664830
Status: Duplicate (was: Assigned)
As of https://codereview.chromium.org/2500503002, the old UI (for anything to do with tasks or bots) has been removed. 

That "old ui" link will also be going away soon.
I still semi-regularly visited the old UI. However, without access to the old UI I can't tell you exactly what I found useful that isn't covered by the new UI.

Is there any hurry to remove the old UI? It would have been good to have some type of message on the old UI which said "We want to remove this UI, please report open a bug to track why you switched back to it so we can make sure your use case is covered" or similar....

Comment 3 by mar...@chromium.org, Nov 15 2016

Cc: phajdan.jr@chromium.org
Removing the old UI is blocker to rewriting the service in Go, so yes there's a time pressure.

I thought I had sent a PSA about the switch over but can't find it, so it looks like I forgot. My bad. :( I will send one now.
I don't understand how something in the Python system could prevent rewriting the service in Go? If they are rewriting, they could choose not to implement the old UI right?

PSAs can be ignore and generally bad way of doing things.

What you want to do is catch the people when they switch back to the oldui and figure out why they are switching back to the oldui. When people are no longer switching back to the oldui, then it makes sense to delete it.

Comment 5 by mar...@chromium.org, Nov 17 2016

Kevin diligently implemented missing features as people reported them (he usually deployed to prod on the same day as reported!) and we never heard any push back.

The Swarming UI isn't as publicly facing as Rietveld, Gerrit or Milo so we decided to take a shorter path to deploy it. Sorry for causing you inconvenience.

You can still (temporarily) look at the old UI by forcing an older Swarming server version, e.g.:
https://2470-c8f977e-dot-chromium-swarm.appspot.com/restricted/bots
https://2470-c8f977e-dot-chromium-swarm.appspot.com/user/tasks

Please report any missing item or potential improvements as a new bug report.
Kevin has definitely been awesome responding to my feedback!

The problem with the swarming UI being less public facing is that you have less people finding places where things are missing or use cases which are not covered. Frustratingly, this means you actually need to move slower :-(

Without the old UI, I can't report things the old UI did better (or reasons I felt like I needed to switch to it). I don't know until I'm trying to debug a problem, or show someone else some functionality. The thought process is frequently, "I remember seeing XYZ but I can't find it on the new UI, is it just hidden somewhere else or did I imagined it existing in the first place..." or "I was sure that I was previously able to do XYZ..." or even "I'm sure I page loaded much quicker previously..."

Switching back to the old UI and getting reminded about how hard it was to use also makes us appreciate how much better the new UI is :).

Could we make the old UI link to those older versions for now? The only reason the old version would stop working is changes to the datastore? When the old UI has been broken for 6 months and nobody complains about it, you'll know that the new UI is doing a great job :)

Comment 7 by kjlubick@google.com, Nov 18 2016

Status: Started (was: Duplicate)
I can add that back in on Monday.  Instead of /user/tasks (like it used to be), I'm going to stick it in /oldui/user/tasks because I want the new UI to be the default (sooooo much faster load times on bot-page, for example)  

I'll see how much effort it is to make the "old ui" link keep the params and stuff.  No promises that it will work 100%, but I think I can at least get it close.

Also, I'm going to put in big bold letters at the top of the page something like:
"This UI is going away on January 1, 2017.  If it has something you need and the new UI doesn't have it, file a bug ASAP"
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-py.git/+/8a4efd26384614855c0ffb511b51c21d0aad4e1b

commit 8a4efd26384614855c0ffb511b51c21d0aad4e1b
Author: kjlubick <kjlubick@google.com>
Date: Mon Nov 21 17:49:23 2016

Add link to old ui back in

This keeps the new ui as default (/user/* and /restricted/* will still
redirect to new ui), but also adds in a way to easily see the old
ui.

The old UI will go away next year.

BUG= 664829 

Review-Url: https://codereview.chromium.org/2523433002

[modify] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/handlers_frontend.py
[add] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/templates/bot_view.html
[add] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/templates/restricted_bot.html
[add] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/templates/restricted_botslist.html
[modify] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/templates/root.html
[add] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/templates/user_task.html
[add] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/templates/user_tasks.html
[modify] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/ui/build/elements.html
[modify] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/ui/res/imp/common/swarming-app.html
[modify] https://crrev.com/8a4efd26384614855c0ffb511b51c21d0aad4e1b/appengine/swarming/ui/res/imp/index/swarming-index-demo.html

Comment 9 by kjlubick@google.com, Nov 21 2016

Status: Fixed (was: Started)
old ui added back in as stated in comment #7.  The new ui links to approximately the equivalent old ui page.  If you were filtering anything, that doesn't translate, but it at least gets you to the right page.
Thank you. I've already started reporting bugs like https://bugs.chromium.org/p/chromium/issues/detail?id=667627

Being able to compare them side-by-side is really interesting.

Sign in to add a comment