Issue metadata
Sign in to add a comment
|
Regression: The Window Control Buttons are misplaced in Fullscreen Mode |
||||||||||||||||||||||
Issue descriptionVersion: Version 56.0.2918.0 canary (64-bit) OS: Mac OS 10.11.6 What steps will reproduce the problem? (1) go into Fullscreen Mode with a Chrome Canary window What is the expected result? What happens instead? The Window Control Buttons are misplaced on the Toolbar. A screenshot is attached. Please use labels and text to provide additional information. Maybe caused by one of latest Fullscreen changes? E.g. https://codereview.chromium.org/2484973004 ?
,
Nov 14 2016
maybe this should block dev too.. Issue also happens on 10.12. Doesn't happen on 10.9 (there are no window controls in fullscreen there). Not sure about 10.10.
,
Nov 14 2016
Able to reproduce this issue on Mac 10.11.6 on chrome canary version 56.0.2918.0 Issue is broken in M56. Bisect Info: =========== Good build : 56.0.2916.0, Revision Range(431463) Bad build : 56.0.2917.0, Revision Range(431726) After executing the per-revision-bisect script, i got the following CL's between good and bad build versions =========================================== https://chromium.googlesource.com/chromium/src/+log/e981878315978869aacb65868644467ca1f46dd9..144e6019d55ce9a31b22b68b045f05eddd8bfae0 The suspecting Change Log is : ----------- https://chromium.googlesource.com/chromium/src/+/144e6019d55ce9a31b22b68b045f05eddd8bfae0 From the above CL suspecting the below change --------------------------- https://codereview.chromium.org/2489373002 lgrey@- Could you please look into this issue, if it's related to your change? if not could you please help us to reassign this issue to the right owner.
,
Nov 14 2016
Fix is out for review: https://codereview.chromium.org/2503533002/
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f27907f882cfa0074ed0ed5e023508aae6bd6f1c commit f27907f882cfa0074ed0ed5e023508aae6bd6f1c Author: lgrey <lgrey@chromium.org> Date: Tue Nov 15 00:42:45 2016 [Mac] Fix autoresizing mask for full-screen windows controls BUG= 664807 Review-Url: https://codereview.chromium.org/2503533002 Cr-Commit-Position: refs/heads/master@{#432025} [modify] https://crrev.com/f27907f882cfa0074ed0ed5e023508aae6bd6f1c/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
,
Nov 15 2016
,
Nov 15 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by meh...@chromium.org
, Nov 13 201619.1 KB
19.1 KB View Download