Issue metadata
Sign in to add a comment
|
Translator always thinks that user language is English, even though UI is Hebrew
Reported by
dids...@gmail.com,
Nov 13 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.87 Safari/537.36 Steps to reproduce the problem: 1. 2. Windus Hebrew Chrome Hebrew Entrance to the site is not possible to translate English subtitles Unable to select languages English Right mouse appears translated into English and translated subtitles ווינדוס בעברית כרום בעברית כניסה לאתר באנגלית אין אפשרות לתרגם לעברית אין אפשרות לסמן בשפות תרגום מאנגלית מקש ימני בעכבר מופיע תרגם לאנגלית ולא תרגם לעברית 3. What is the expected behavior? 1. 2. Windus Hebrew Chrome Hebrew Entrance to the site is not possible to translate English subtitles Unable to select languages English Right mouse appears translated into English and translated subtitles ווינדוס בעברית כרום בעברית כניסה לאתר באנגלית אין אפשרות לתרגם לעברית אין אפשרות לסמן בשפות תרגום מאנגלית מקש ימני בעכבר מופיע תרגם לאנגלית ולא תרגם לעברית 3. What went wrong? 1. 2. Windus Hebrew Chrome Hebrew Entrance to the site is not possible to translate English subtitles Unable to select languages English Right mouse appears translated into English and translated subtitles ווינדוס בעברית כרום בעברית כניסה לאתר באנגלית אין אפשרות לתרגם לעברית אין אפשרות לסמן בשפות תרגום מאנגלית מקש ימני בעכבר מופיע תרגם לאנגלית ולא תרגם לעברית 3. Did this work before? N/A Chrome version: 54.0.2840.87 Channel: n/a OS Version: 10.0 Flash Version: Shockwave Flash 23.0 r0 לפני שבועיים בערך זה התקלקל אין אפשרות לתרגם מאנגלית לעברית תמיד היה בעיה בהגדר שפות אי אפשר לסמן שדפים באנגלית יתורגמו לעומת שאר השפות שאפשר .... About two weeks ago it broke can not always translate from English to Hebrew language was a problem setting impossible to mark pages in English will be translated in the other languages can be ....
,
Nov 14 2016
,
Nov 14 2016
,
Nov 14 2016
Basically a simple enough problem All my computer and browser Hebrew Chrome settings in English language is impossible to mark translate English pages All languages English can not ... Simon will be built there but you can not click it is not available ... Until two weeks ago translation browser also worked and what translated in English Now it has stopped The problem will be built Simone was always (because it is now more settings and also issue translation icon that appears
,
Nov 21 2016
Thank you for providing more feedback. Adding requester "krajshree@chromium.org" for another review and adding "Needs-Review" label for tracking. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 22 2016
,
Nov 22 2016
What it means ??? Components: UI> Browser> Translate
,
Nov 22 2016
dbeam/dpapad: Did we change anything in language settings in the old settings UI? It looks like the user is prevented from even enabling translation to English, even though the browser UI is Hebrew. (Although the screenshots look like English is still the primary language... I'm not quite clear what's happening there)
,
Nov 22 2016
no, we haven't changed anything in old options that i'm aware of
,
Nov 22 2016
You ask if you have changed anything? Apparently it is a fact that can not be translated into Hebrew ... The truth is always part of the problem was the language settings that you can click to translate pages written in English But if I went to English was up window appears and asks if I want to translate Today there is no window pages in English Each interface also Hebrew me chromium even Windows! Still, right-click the mouse gospel message translated into English translation and not translated into Hebrew ....
,
Nov 22 2016
Can you not have changed any way but probably chromium think my language is English Language and Translation settings You can not click the translate English pages clicking ... there is a window but can not shake the possibility Dat
,
Nov 22 2016
didschr: There's no need to click on that checkbox, because Chrome will offer to translate non-Hebrew pages to you by default. The phrasing of the checkbox is confusing, because "translate pages in this language" can be understood to mean either "translate from this language to Hebrew" (correct) or "translate from Hebrew to this language" (incorrect). Sorry about the confusion! didschr: If you've added "English" to the list of languages, please make sure that its checkbox "Offer to translate pages in this language" is checked.
,
Nov 22 2016
If you've added "English" to the list of languages, please make sure that its checkbox "Offer to translate pages in this language" is checked. That's what I say !!!!! You can not mark !!! You can not click !!!
,
Nov 22 2016
Able to reproduce when running "LANGUAGE=iw google-chrome-stable". "iw" is the ISO language code for Hebrew. Expected status of "Offer to translate page in this language": English - Enabled Russian - Enabled Hebrew - Disabled English (United States) - Enabled Observed status of "Offer to translate page in this language": English - Disabled Russian - Enabled Hebrew - Enabled English (United States) - Disabled Hebrew-to-Hebrew translation does not make sense, so this must be a bug.
,
Nov 22 2016
Okay settings can mark translate but ! I went to English it does not translate! Right mouse button on the page still appears translated into English and not Hebrew!
,
Nov 22 2016
,
Nov 22 2016
,
Nov 22 2016
Now again it is impossible to mark a check box Why Linux on Windows I Now that you understand the problem I very much hope that a solution will be found Until about a month ago he worked translation (no checkbox but I went to English appeared in a small window with a proposal to translate) I do not think it did change my computer formatting, etc. Although it is possible less likely
,
Nov 23 2016
Io aggiungo Qualsiasi lingua da tradurre opzione Appare in il pulsante destro del mouse del mouse ebraico ( foto allegata ) La cosa strana ho aggiunto , per esempio, italiano premo fate clic destro che non si traducono in italiano ! Questo si traduce in ebraico ...
,
Nov 23 2016
Italian mistakenly sent! I add any language to translate option appears in the right-click mouse Hebrew (photo attached) The strange thing I added, for example, Italian I press right click it did not translate into Italian! This translates into Hebrew ...
,
Nov 23 2016
It is now also automatically translates any page me I came from English to Hebrew .... Currently this Hebrew language settings and removed the English-Italian ...
,
Dec 28 2016
,
Dec 28 2016
Able to reproduce the issue on Windows 10 and Ubuntu 14.04 using chrome reported version #54.0.2840.87 and latest canary #57.0.2964.0. OS Mac don't have the option to translate page. Bisect Information: ===================== Good build: 54.0.2825.0 Revision(410913) Bad Build : 55.0.2876.0 Revision(411209) Change Log URL: https://chromium.googlesource.com/chromium/src/+log/024c8dbbb497a75c01abb813d61659663689ccaa..9658047b62714181886bd2fed9f8246e635b70f3 From the above change log suspecting below change Review url: https://codereview.chromium.org/2200493002 ftang@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks...!!
,
Dec 28 2016
From what I see there is still the problem nothing has changed .... 😢
,
Jan 4 2017
Hi all, We have technical case with the same issue persisting. On version 55, it gives us to option to check the translate checkbox, but on Canary build the option is grayed out for Hebrew. What we found out is that if a separate language (ex. French, or any other) is added in the languages and the translate option is available, we can use the translator to manually select Hebrew (after clicking on the options link when the pop up shows up or in the translator option in the address bar) and the page will be translated successfully. This is sort of a workaround, but it requires a third language to be added in the Languages settings. Thanks!
,
Jan 4 2017
I really do not know what exactly the situation that small changes make a big difference but I think you're right ...
,
Jan 20 2017
Gentle ping to get an update on this issue.
,
Jan 20 2017
This is intended behavior because the user is Hebrew so it is more likely they want to translate a page into Hebrew. The user could change the target language selection once they translate. There are no prove that more Hebrew window Hebrew chrome user like to translate Hebrew into English than those want to translate English to Hebrew.
,
Jan 20 2017
See comment #15. Setting UI to Hebrew offers to translate Hebrew pages to Hebrew. I don't think this should be WontFix.
,
Apr 4 2017
Flipping back to assigned. Barak and I confirmed today that this is still an issue. With Chrome in Hebrew, option to opt into English translations is greyed out. Target language is chosen as English for translations from another language.
,
Apr 5 2017
Too bad I did not see the discussion anyway the problem remained ....
,
Apr 5 2017
Thanks for confirming didschr@gmail.com, we're taking a look.
,
Apr 5 2017
,
Apr 5 2017
This can be reproduced for two other locale tl (Filipino) and no (Norwegian). The issue seems related to the call to CheckAndResolveLocale() inside ui/base/l10n/l10n_util.cc which map "iw" to "he", and map "tl" to "fil" and "no" to "nb".
,
Apr 5 2017
can reproduce this on Windows. Do not know how to switch language on Mac.
,
Apr 5 2017
@Ftang: you can change Chrome UI language on Mac only by changing your OS UI language
,
Apr 5 2017
,
Apr 5 2017
jshin@ - looks like you're the owner for ui/base/l10n/l10n_util.cc - can you help us troubleshoot?
,
Apr 5 2017
don't worry. I have the fix. I missed one line in a cl last time.
I think I found the problem. Missing a line "translate::ToTranslateLanguageSynonym(&language);" when I move the code. Should be fixed by components/translate/core/browser/translate_manager.cc
449 if (language.empty()) {
450 // Get the language from ULP.
451 language = TranslateManager::GetTargetLanguageFromULP(prefs);
452 if (!language.empty())
453 return language;
454
455 // Get the browser's user interface language.
456 language = TranslateDownloadManager::GetLanguageCode(
457 TranslateDownloadManager::GetInstance()->application_locale());
+ translate::ToTranslateLanguageSynonym(&language);
458 }
,
Apr 6 2017
fix pending review https://codereview.chromium.org/2802613004/
,
Apr 6 2017
Great, thanks Frank.
,
Apr 11 2017
Issue 702976 has been merged into this issue.
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5d482d74629b9a30493f0c0201fd6863ec1c1ece commit 5d482d74629b9a30493f0c0201fd6863ec1c1ece Author: ftang <ftang@chromium.org> Date: Fri Apr 14 18:26:49 2017 fix target language issue under three locales (Hebrew[iw->he], Fillipion[tl->fil], and Nowreign[no->nb] BUG= 664791 Review-Url: https://codereview.chromium.org/2802613004 Cr-Commit-Position: refs/heads/master@{#464758} [modify] https://crrev.com/5d482d74629b9a30493f0c0201fd6863ec1c1ece/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/5d482d74629b9a30493f0c0201fd6863ec1c1ece/components/translate/core/browser/translate_manager_unittest.cc
,
Apr 17 2017
,
Apr 17 2017
,
Apr 18 2017
Issue 664977 has been merged into this issue.
,
Apr 18 2017
Issue 676460 has been merged into this issue.
,
Apr 27 2017
,
Apr 28 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by krajshree@chromium.org
, Nov 14 2016Labels: Needs-Feedback