New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664782 link

Starred by 1 user
Status: Fixed
Owner:
█ dfalcant...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
Cc:
█ mbarowsky+blinkimage@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Mouse pointer only changes to the zoom-icon after clicking the image once (for zooming)

Reported by parasdee...@gmail.com, Nov 13 2016 
UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2914.3 Safari/537.36

Steps to reproduce the problem:
1. Open any image (larger than the viewport) via dragging from the file system or right-click to open-in-new-tab
2. Hover over the image to zoom in
3. Click on the image to zoom.

What is the expected behavior?
The mouse pointer should automatically change it's icon to the magnifying glass when hovered over the image, to indicate the image is zoomable.

What went wrong?
The mouse pointer remains in the default icon until the image is clicked for zooming in. Once that is done, the pointer behaves normally.

Did this work before? N/A 

Chrome version: 56.0.2914.3  Channel: dev
OS Version: 10.0
Flash Version: Shockwave Flash 24.0 r0
step1.png
360 KB View Download
step2.png
297 KB View Download
step3.png
367 KB View Download

Comment 1 by kavvaru@chromium.org, Nov 21 2016

Components: Blink>Image
Labels: -Type-Bug -Pri-2 hasbisect-per-revision ReleaseBlock-Stable M-56 OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Owner: dfalcant...@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 57.0.2926.0.the sane is working fine on stable 54.0.2840.99.
This is regression issue broken in M56.Please find the bisect information as below

Narrow Bisect::
Good :: 56.0.2909.0  ---  (build revision 429737)
Bad::  56.0.2910.0   ----  (build revision 430103)

Change Log::
https://chromium.googlesource.com/chromium/src/+log/c2e553e4b38ed65bf11045c2e61895dc625e3dd5..98b66eba2a1509a2c7d2d6a4ecab6c270a761092

Possible suspect::
https://chromium.googlesource.com/chromium/src/+/98b66eba2a1509a2c7d2d6a4ecab6c270a761092

dfalcantara@ Could you please look into this issue if it is related to your change,else please route this to an appropriate owner for this issue.

Thanks,

Comment 2 by dfalcant...@chromium.org, Nov 23 2016

Labels: Merge-Request-56
Don't know why the bot didn't report the CL landing, but requesting merge on https://chromiumcodereview.appspot.com/2523553002/.

Comment 3 by dimu@chromium.org, Nov 24 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c45131ad8acfc30cf22e7113a8029d26f7ec4bb8

commit c45131ad8acfc30cf22e7113a8029d26f7ec4bb8
Author: dfalcantara@chromium.org <dfalcantara@chromium.org>
Date: Mon Nov 28 21:05:05 2016

[M56] Consolidate how ImageDocument sets image styling

* Consolidate how the image sets the cursor styling inside of
  updateImageStyle(), which now checks for whether the cursor
  or checkerboard size has changed during styling updates.

* Fix how the magnifying glass cursor is initialized on desktop
  versions of the page.

BUG= 664782 
TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/2535063002 .

Original-Review-Url: https://codereview.chromium.org/2523553002
Original-Cr-Commit-Position: refs/heads/master@{#434020}
Cr-Commit-Position: refs/branch-heads/2924@{#127}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/c45131ad8acfc30cf22e7113a8029d26f7ec4bb8/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/c45131ad8acfc30cf22e7113a8029d26f7ec4bb8/third_party/WebKit/Source/core/html/ImageDocument.cpp
[modify] https://crrev.com/c45131ad8acfc30cf22e7113a8029d26f7ec4bb8/third_party/WebKit/Source/core/html/ImageDocument.h

Comment 5 by dfalcant...@chromium.org, Nov 28 2016

Status: Fixed (was: Assigned)

Comment 6 by kavvaru@chromium.org, Nov 29 2016

Labels: TE-Verified-M56 TE-Verified-56.0.2924.10
Tested the fix on windows 7, Linux Ubuntu 14.04 and Mac 10.11.6 using chrome version 56.0.2924.10.Observed zoom icon changed when hovered on image.
Please find the attached screen cast for the same.

Adding TE-Verified labels.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7fa62c57b78c4c0433f7570fe34ad16a323db47

commit e7fa62c57b78c4c0433f7570fe34ad16a323db47
Author: wangxianzhu <wangxianzhu@chromium.org>
Date: Fri Dec 02 22:09:05 2016

Manually rebaseline NeedsRebaselines on or before 12/1

This is done in the following steps:
1. Replace [ NeedsRebaseline ] with [ Rebaseline ]
2. run webkit-patch rebaseline-expectations
3. Remove the [ PRECISE ] lines from TestExpectations (caused by 660580).

For console-stack-overflow-source-url.html, because it's flaky, marked it
flaky instead of rebaselining.

BUG= 662722 , 666628 , 664782 ,475556
TBR=rebaseline under webexposed/ as the NeedsRebaselines have already been approved.

Review-Url: https://codereview.chromium.org/2549843002
Cr-Commit-Position: refs/heads/master@{#436042}

[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/images/huge-image-viewport-scale-expected.txt
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/linux/css1/pseudo/anchor-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/linux/svg/wicd/test-scalable-background-image2-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/linux/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac-mac10.10/css1/pseudo/anchor-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/basic/grouping-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/box_properties/border_left_width-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/box_properties/border_top_inline-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac-mac10.9/css1/pseudo/anchor-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac-mac10.9/svg/wicd/test-scalable-background-image1-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac/css1/pseudo/anchor-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/mac/http/tests/inspector-enabled/console-stack-overflow-source-url-expected.txt
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/mac/svg/wicd/test-scalable-background-image2-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/win/css1/pseudo/anchor-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-scalable-background-image1-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/win/svg/wicd/test-scalable-background-image2-expected.png
[modify] https://crrev.com/e7fa62c57b78c4c0433f7570fe34ad16a323db47/third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/win7/svg/wicd/test-scalable-background-image1-expected.png
[delete] https://crrev.com/56c90a89889693bd6e1a7d7bb4b8f49c69bab2fd/third_party/WebKit/LayoutTests/platform/win7/svg/wicd/test-scalable-background-image2-expected.png
►

Sign in to add a comment