**** Bulk edit -  please ignore if not applicable ****


A friendly reminder that M55 Stable is launch is coming soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged into the release branch ASAP so it gets enough baking time in Beta (before Stable promotion). Thank you!

Also due to Thanksgiving holidays in US, please make sure fix is ready and merged to M55 latest by 5:00 PM PT Friday, 11/18/16 (sooner the better).

dbeam@ - History is something you're overseeing as well (in addition to Settings), correct?

shrike@: most of the engineering power on MD history was from tsergeant@/calamity@/lshang@ and previously hannahs@ and yingranc@.  I helped a bit in the home stretch and on the old version of history (when the previous owner, dubroy@, left google).

tsergeant@/calamity@: the autofocus attribute on the delete button in history's removal confirmation <dialog> isn't working.  autofocus only works on form control elements.

note: the old history UI didn't actually focus the remove button by default, but had a subtly different style for the default button (darker border) as well as had a separate key listener for Enter presses.  the rationale was, i believe, that if you're using a screenreader and focus starts at the "Remove" button it's kind of annoying to have to navigate to the top / read what the confirmation dialog says (it's like the equivalent of starting with your page scrolled fully to the bottom of a list).

so, to be clear: you can still easily click, tap, or tab to the remove button.  focus starts on the "CANCEL" button, right next to "REMOVE".

we can block stable and attempt to land a CL quickly and merge it, but I don't really see that as necessary in this case.  it is a small functional regression compared to the last UI, as well as a small product excellence issue.

explained some of the wonkiness involving tabindex= in <dialog> to pinkerton@ and a high-level desired outcome.  we decided we were OK with a little bit of focus()/AT "flicker" and will just focus() the remove button shortly after showing the dialog.  it's a 1 line, mergable fix, and will have a better end outcome (i.e. bugs filed about focus / outline flicker) than bugs filed about failures to remove history.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae7af053da762dc6d0aed3a3a2cd7c7bb084b253

commit ae7af053da762dc6d0aed3a3a2cd7c7bb084b253
Author: dbeam <dbeam@chromium.org>
Date: Tue Nov 15 00:59:56 2016

MD History: focus REMOVE button by default in multi-delete dialog

R=tsergeant@chromium.org
BUG= 664777 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2503613002
Cr-Commit-Position: refs/heads/master@{#432039}

[modify] https://crrev.com/ae7af053da762dc6d0aed3a3a2cd7c7bb084b253/chrome/browser/resources/md_history/app.crisper.js
[modify] https://crrev.com/ae7af053da762dc6d0aed3a3a2cd7c7bb084b253/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/ae7af053da762dc6d0aed3a3a2cd7c7bb084b253/chrome/browser/resources/md_history/list_container.html
[modify] https://crrev.com/ae7af053da762dc6d0aed3a3a2cd7c7bb084b253/chrome/browser/resources/md_history/list_container.js

can we get an M55 merge verdict?

Please wait until CL is baked/verified in Canary. If cl looks good in Canary and safe to merge, then I will approve merge to M55.

just tried it on Mac OS X canary, looks good to me.

Approving merge to M55 branch 2883 per comment #12. Please merge ASAP. If merge happens today before 4:00 PM PT, then we can pick it up for this week beta release. Thank you.

Looks good to me. I tried on canary and enter works properly, as does esc. Pressing spacebar triggers the default button. I don't see any flicker, which we were worried about by calling focus late.

Once you start tabbing around, enter will activate the focused button, not the default button. That's a larger issue for <dialog>-based UI, and not something that should block this feature. 

oh boy, that was a fun 2h of conflicts and M55 branch building!

merged manually to 2883 as crrev.com/7832080d380a6341a09a3dedfbe29efc535c7c7f

Already merged to M55 per comment #15. Hence, removing "Merge-Approved-55" label and applying "merge-merged-2883" label.

Verified this issue on Ubuntu 14.04, Mac OS 10.12 and Windows-10 using chrome latest M55-55.0.2883.52 by following steps mentioned in the original comment. Observed able to delete the history by pressing return key as expected. Hence adding TE-Verified label.

Deleted: 664777.ogv 1.5 MB

	664777.ogv 1.5 MB View Download

Verified on ChromeOS 8872.67.0, 55.0.2883.82