New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664716 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Xbox One S Gamepad has incorrect mappings with new firmware

Reported by aicomman...@gmail.com, Nov 12 2016

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.100 Safari/537.36

Steps to reproduce the problem:
1. Update an Xbox One S controller to the latest firmware on a Windows 10 PC or Xbox One console.
2. Connect to a Mac, Linux, or Android device
3. Go to http://html5gamepad.com/

What is the expected behavior?
Axes and buttons should be mapped correctly.

What went wrong?
Axes and buttons are not mapped correctly.

Did this work before? No 

Does this work in other browsers? Yes

Chrome version: 54.0.2840.100  Channel: stable
OS Version: Fedora 24
Flash Version: Shockwave Flash 23.0 r0
 

Comment 1 by dk...@chromium.org, Nov 14 2016

Cc: bajones@chromium.org
+bajones who works in this space. @Brandon - any thoughts on where to route this?
Just LGTMed the fix from the bug reporter.

https://codereview.chromium.org/2494823005/
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f47e3fc8435f1f90d88133522067b7669251c2a

commit 5f47e3fc8435f1f90d88133522067b7669251c2a
Author: aicommander <aicommander@gmail.com>
Date: Tue Nov 15 05:43:48 2016

Correct mappings for Xbox One S gamepad with new firmware

Microsoft has released a firmware update that changes HID mapping
to be more Android-friendly. In fact, it would already be mapped
perfectly by our existing unknown gamepad mapping code on Android.
Unfortunately, since the device name didn't change, we're now using
the wrong mapping because we made a special one for the older firmware.
This CL removes the old mapping so the unknown gamepad mapping code
will now handle this controller properly on Android.

For Mac and Linux, I have replaced the existing mapping for the old
firmware with a new mapping for the current firmware.

BUG= 664716 
TEST=http://html5gamepad.com/

Review-Url: https://codereview.chromium.org/2494823005
Cr-Commit-Position: refs/heads/master@{#432119}

[modify] https://crrev.com/5f47e3fc8435f1f90d88133522067b7669251c2a/device/gamepad/android/java/src/org/chromium/device/gamepad/GamepadMappings.java
[modify] https://crrev.com/5f47e3fc8435f1f90d88133522067b7669251c2a/device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java
[modify] https://crrev.com/5f47e3fc8435f1f90d88133522067b7669251c2a/device/gamepad/gamepad_standard_mappings_linux.cc
[modify] https://crrev.com/5f47e3fc8435f1f90d88133522067b7669251c2a/device/gamepad/gamepad_standard_mappings_mac.mm

Cc: tkonch...@chromium.org
Labels: TE-Hardware-Dependency

Comment 5 by dk...@chromium.org, Dec 15 2016

Owner: bajones@chromium.org
Status: Assigned (was: Unconfirmed)
Assigning to bajones to confirm this was fixed! 
Status: Fixed (was: Assigned)
Marking as "Fixed", needs verification

Sign in to add a comment