New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664710 link

Starred by 1 user
Status: Fixed
Owner:
█ robert...@chromium.org
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 664494
issue 662170



Sign in to add a comment

Return code bisect pass/fail printed incorrectly

Project Member Reported by sullivan@chromium.org, Nov 12 2016 
See https://bugs.chromium.org/p/chromium/issues/detail?id=662170#c7, Exit Code column printed incorrectly.


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N  Good?
chromium@428543  N/A        N/A      5  good
chromium@428559  N/A        N/A      5  good
chromium@428563  N/A        N/A      5  good
chromium@428564  N/A        N/A      5  bad    <--
chromium@428565  N/A        N/A      5  bad
chromium@428567  N/A        N/A      5  bad
chromium@428574  N/A        N/A      5  bad
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/cee5ea9bfe21ecd903faccbd80b2deb69bfb7197

commit cee5ea9bfe21ecd903faccbd80b2deb69bfb7197
Author: Roberto Carrillo <robertocn@google.com>
Date: Sat Nov 12 04:39:05 2016

Fix return code display for bisects.

Dashboard is expecting the return code in the 'mean_value' field. This
change does that.

TBR=sullivan@chromium.org,dtu@chromium.org
BUG= 664710 

Change-Id: Ie4ee27f33a2240363dd96bb3e7c0ff6d1f465fa2
Reviewed-on: https://chromium-review.googlesource.com/410171
Reviewed-by: Roberto Carrillo <robertocn@chromium.org>
Commit-Queue: Roberto Carrillo <robertocn@chromium.org>

[modify] https://crrev.com/cee5ea9bfe21ecd903faccbd80b2deb69bfb7197/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
[modify] https://crrev.com/cee5ea9bfe21ecd903faccbd80b2deb69bfb7197/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json

Comment 2 by sullivan@chromium.org, Nov 12 2016

Blocking: 664478

Comment 4 by sullivan@chromium.org, Nov 14 2016

Blocking: 662170

Comment 5 by sullivan@chromium.org, Nov 14 2016

Blocking: -664478
Status: Fixed (was: Untriaged)
Looks like the comment there is correct:
https://bugs.chromium.org/p/chromium/issues/detail?id=662170#c9

I just looked at the blocked bugs, bug 664478 wasn't right, changed that and marking this fixed.
►

Sign in to add a comment