New issue
Advanced search Search tips

Issue 664705 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Nov 2016
Cc:
mfo...@chromium.org
btolsch@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

[Media Router] Dialog appears off-center for a split second

Project Member Reported by taku...@chromium.org, Nov 12 2016 
When user opens the MR dialog, it appears off-center (to the right), then immediately shifts to the center as the WebUI contents load. Not a recent regression; currently observable in M54-TOT.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d8038f14a717e711c1ab57997559b8a564d76bd

commit 9d8038f14a717e711c1ab57997559b8a564d76bd
Author: takumif <takumif@chromium.org>
Date: Sat Nov 12 03:38:25 2016

[MR UI] Set dialog width in MediaRouterDialogDelegate::GetDialogSize() if not set

Currently the Media Router dialog shows up off-center for a split second, then gets center-aligned as its contents load and size gets set dynamically. This change makes GetDialogSize() set the dialog width if it's not set yet, so that the dialog appears in the center from the beginning.

BUG= 664705 

Review-Url: https://codereview.chromium.org/2481413007
Cr-Commit-Position: refs/heads/master@{#431756}

[modify] https://crrev.com/9d8038f14a717e711c1ab57997559b8a564d76bd/chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.cc

Comment 2 by taku...@chromium.org, Nov 14 2016

Status: Fixed (was: Started)
►

Sign in to add a comment