New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664704 link

Starred by 2 users
Status: Fixed
Owner:
█ allada@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Feature

Blocked on:
issue 682861
issue 696109
issue 697668
issue 697669


Sign in to add a comment

Network log to show users which resource belong to which product

Project Member Reported by allada@chromium.org, Nov 12 2016 
We should be able to group items in network log view.

Comment 1 Deleted

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2878e413939ca755242d198304226fb83c5e4963

commit 2878e413939ca755242d198304226fb83c5e4963
Author: allada <allada@chromium.org>
Date: Tue Dec 20 04:55:55 2016

[Devtools] Add experiment for network group support

This patch adds a hidden experiment to support groups of requests in
network panel.

Right now the patch only adds group by domain, but we'll be tweaking that with time to add interface and get rid of non-supported aspects of groups.

See: http://imgur.com/a/FDmmt

R=dgozman
BUG= 664704 

Review-Url: https://codereview.chromium.org/2561683003
Cr-Commit-Position: refs/heads/master@{#439711}

[modify] https://crrev.com/2878e413939ca755242d198304226fb83c5e4963/third_party/WebKit/LayoutTests/http/tests/inspector/network/network-columns-visible.html
[modify] https://crrev.com/2878e413939ca755242d198304226fb83c5e4963/third_party/WebKit/Source/devtools/front_end/main/Main.js
[modify] https://crrev.com/2878e413939ca755242d198304226fb83c5e4963/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/2878e413939ca755242d198304226fb83c5e4963/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/2878e413939ca755242d198304226fb83c5e4963/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
[modify] https://crrev.com/2878e413939ca755242d198304226fb83c5e4963/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6cbb8dfd02ecd7f4f7f4c71f089eb9403c31e76

commit c6cbb8dfd02ecd7f4f7f4c71f089eb9403c31e76
Author: allada <allada@chromium.org>
Date: Wed Dec 21 03:13:32 2016

[Devtools] Fixes regression caused by experiment for network popover

This patch fixes a regression caused by network panel not properly
showing popover when colored bars are on in network panel and hover over
a request in waterfall.

R=dgozman
BUG= 664704 

Review-Url: https://codereview.chromium.org/2593893002
Cr-Commit-Position: refs/heads/master@{#439994}

[modify] https://crrev.com/c6cbb8dfd02ecd7f4f7f4c71f089eb9403c31e76/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31f31a2fa7d1367fa3472044adfbc746ceba1caf

commit 31f31a2fa7d1367fa3472044adfbc746ceba1caf
Author: allada <allada@chromium.org>
Date: Tue Dec 27 20:19:24 2016

[Devtools] Setup network groupping to show bars for collapsed nodes

This patch will now show bars for nodes that are collapsed and contain
nodes that have bars inside them.

See: http://imgur.com/a/egUwg

R=dgozman
BUG= 664704 

Review-Url: https://codereview.chromium.org/2591043003
Cr-Commit-Position: refs/heads/master@{#440779}

[modify] https://crrev.com/31f31a2fa7d1367fa3472044adfbc746ceba1caf/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 20 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b4be1946c9953f17157f063b43251e32394e193

commit 0b4be1946c9953f17157f063b43251e32394e193
Author: allada <allada@chromium.org>
Date: Fri Jan 20 03:47:58 2017

[Devtools] Network group experiment is now grouped by connectionId

This patch moves to using connectionId as the default for network
group experiment.

See: http://imgur.com/a/O7y52

R=dgozman
BUG= 664704 

Review-Url: https://codereview.chromium.org/2614823003
Cr-Commit-Position: refs/heads/master@{#444970}

[modify] https://crrev.com/0b4be1946c9953f17157f063b43251e32394e193/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/0b4be1946c9953f17157f063b43251e32394e193/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Comment 7 by allada@chromium.org, Jan 20 2017

Blockedon: 682861
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 26 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f70665f72a40d378c7bda5fc3aa6aec33dc93919

commit f70665f72a40d378c7bda5fc3aa6aec33dc93919
Author: allada <allada@chromium.org>
Date: Thu Jan 26 00:10:11 2017

[Devtools] Handle network sorting of grouped nodes properly

This patch changes the logic of how grouped nodes are sorted to use first
known request in a group; however, sorting by name will first sort nodes by
weather they are grouped then sort them by name. This will ensure that
group nodes are together and non-group nodes are together but sorrted within
their partition.

R=dgozman,luoe,caseq
BUG= 664704 

Review-Url: https://codereview.chromium.org/2648853002
Cr-Commit-Position: refs/heads/master@{#446168}

[modify] https://crrev.com/f70665f72a40d378c7bda5fc3aa6aec33dc93919/third_party/WebKit/Source/devtools/front_end/data_grid/ViewportDataGrid.js
[modify] https://crrev.com/f70665f72a40d378c7bda5fc3aa6aec33dc93919/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb786f1d99f2e0fc427e59c2dd6db9cd0b24b273

commit bb786f1d99f2e0fc427e59c2dd6db9cd0b24b273
Author: allada <allada@chromium.org>
Date: Fri Jan 27 22:33:17 2017

[Devtools] Added padding to child nodes in network group experiment

This patch adds 15px padding to child nodes recursively.

R=dgozman,luoe,caseq
BUG= 664704 

Review-Url: https://codereview.chromium.org/2649653002
Cr-Commit-Position: refs/heads/master@{#446798}

[modify] https://crrev.com/bb786f1d99f2e0fc427e59c2dd6db9cd0b24b273/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
Project Member

Comment 10 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1edc35f110d1a463f9809286478c3f0dee9e1761

commit 1edc35f110d1a463f9809286478c3f0dee9e1761
Author: allada <allada@chromium.org>
Date: Thu Feb 16 06:28:40 2017

[Devtools] Fixes network group to remove parents if no child

This patch removes parents of grouped network items if there are no
children in the parents.

BUG= 664704 
R=pfeldman

Review-Url: https://codereview.chromium.org/2694103007
Cr-Commit-Position: refs/heads/master@{#450877}

[modify] https://crrev.com/1edc35f110d1a463f9809286478c3f0dee9e1761/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
Project Member

Comment 12 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c8a8c65fe2514ada96567a8ee4d35d054934121

commit 0c8a8c65fe2514ada96567a8ee4d35d054934121
Author: allada <allada@chromium.org>
Date: Fri Feb 17 06:03:09 2017

[Devtools] Prepared network panel for Group Lookup Interface

This patch introduces the interface and small gui to group network
requests.

R=pfeldman,dgozman
BUG= 664704 

Review-Url: https://codereview.chromium.org/2698743003
Cr-Commit-Position: refs/heads/master@{#451234}

[modify] https://crrev.com/0c8a8c65fe2514ada96567a8ee4d35d054934121/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/0c8a8c65fe2514ada96567a8ee4d35d054934121/third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js
Project Member

Comment 13 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7234ea5d5045f6fedbc01503613cc26a2e264670

commit 7234ea5d5045f6fedbc01503613cc26a2e264670
Author: allada <allada@chromium.org>
Date: Fri Feb 17 06:13:00 2017

[Devtools] Added provider for NetworkLookupInterface to ProductRegistry

This patch completes the linking between Network and Product Registry.
There should now be a dropdown in the top of the network panel that
allows the user to group by product (found in the product registry
module).

R=pfeldman,dgozman
BUG= 664704 

Review-Url: https://codereview.chromium.org/2695423002
Cr-Commit-Position: refs/heads/master@{#451239}

[modify] https://crrev.com/7234ea5d5045f6fedbc01503613cc26a2e264670/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/7234ea5d5045f6fedbc01503613cc26a2e264670/third_party/WebKit/Source/devtools/front_end/externs.js
[modify] https://crrev.com/7234ea5d5045f6fedbc01503613cc26a2e264670/third_party/WebKit/Source/devtools/front_end/inspector.json
[add] https://crrev.com/7234ea5d5045f6fedbc01503613cc26a2e264670/third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
[add] https://crrev.com/7234ea5d5045f6fedbc01503613cc26a2e264670/third_party/WebKit/Source/devtools/front_end/network_group_lookup/module.json
[modify] https://crrev.com/7234ea5d5045f6fedbc01503613cc26a2e264670/third_party/WebKit/Source/devtools/front_end/product_registry/ProductNameForURL.js

Comment 14 by allada@chromium.org, Feb 25 2017

Blockedon: 696109

Comment 15 by allada@chromium.org, Mar 2 2017

Blockedon: 697668

Comment 16 by allada@chromium.org, Mar 2 2017

Blockedon: 697669
Project Member

Comment 17 by bugdroid1@chromium.org, Mar 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3e8277dbaf900a53ab0ec812a030ac4a95f7323a

commit 3e8277dbaf900a53ab0ec812a030ac4a95f7323a
Author: allada <allada@chromium.org>
Date: Thu Mar 09 19:54:02 2017

[Devtools] Moved network waterfall to draw all text as a layer

This patch is a series of patches that moves network waterfall to draw in
layers. This is the patch specifically to move text to be caluclated then
drawn all at once.

R=caseq
BUG= 697668 , 664704 

Review-Url: https://codereview.chromium.org/2726103002
Cr-Commit-Position: refs/heads/master@{#455839}

[modify] https://crrev.com/3e8277dbaf900a53ab0ec812a030ac4a95f7323a/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
Project Member

Comment 18 by bugdroid1@chromium.org, Mar 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/595249cfd33d23fc10a9615b1252afa09ad35153

commit 595249cfd33d23fc10a9615b1252afa09ad35153
Author: allada <allada@chromium.org>
Date: Sat Mar 18 02:39:42 2017

[Devtools] Make network waterfall draw in layers

This patch finishes the move to make the waterfall column in the network
panel draw in layers. This ensures it looks good when grouping.

R=caseq
BUG= 664704 

Review-Url: https://codereview.chromium.org/2747293002
Cr-Commit-Position: refs/heads/master@{#457934}

[modify] https://crrev.com/595249cfd33d23fc10a9615b1252afa09ad35153/third_party/WebKit/LayoutTests/http/tests/inspector/network/waterfall-images-expected.png
[modify] https://crrev.com/595249cfd33d23fc10a9615b1252afa09ad35153/third_party/WebKit/Source/devtools/front_end/network/NetworkWaterfallColumn.js
Project Member

Comment 20 by bugdroid1@chromium.org, Apr 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dba9902a5c91c8474782336892c961fd94f82be

commit 7dba9902a5c91c8474782336892c961fd94f82be
Author: allada <allada@chromium.org>
Date: Thu Apr 13 23:42:00 2017

[Devtools] Updated format to store product registry data

Prepares the UI and product registry file format to add visual markers of
network resource classifications.

R=pfeldman
BUG= 664704 

Review-Url: https://codereview.chromium.org/2807823002
Cr-Commit-Position: refs/heads/master@{#464610}

[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/Images/smallIcons.png
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/Images/smallIcons_2x.png
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/Images/src/smallIcons.svg
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/network_group_lookup/NetworkProductGroupLookup.js
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/network_group_lookup/module.json
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/product_registry/ProductNameForURL.js
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/product_registry/ProductRegistryData.js
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/front_end/ui/Icon.js
[modify] https://crrev.com/7dba9902a5c91c8474782336892c961fd94f82be/third_party/WebKit/Source/devtools/scripts/convert-3pas-product-registry.js

Comment 21 by allada@chromium.org, Apr 17 2017

Status: Fixed (was: Started)

Comment 23 by allada@chromium.org, Aug 4 2017

Summary: Network log to show users which resource belong to which product (was: Network log view should be able to group items)
►

Sign in to add a comment