New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664688 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

Update laptop-mode tools to a newer version

Project Member Reported by mka@chromium.org, Nov 12 2016

Issue description

CrOS currently uses v1.59 of laptop-mode-tools, which is more than 5 years old. During the course of the investigation of https://crosbug.com/p/58864 groeck@ and mka@ did some experiments with the current release v1.70, which involved porting the v1.59 patches to v1.70.

The original issue has been resolved and AFAIK there are no pressing issues caused by laptop-mode-tools, but given that our LMT version is so old it would be a shame to discard the work already done on v1.70. Even if we don't want to move forward right now I think it would be a good idea to submit at least a WIP port to v1.70 which can be picked up later.
 

Comment 1 by mka@chromium.org, Nov 12 2016

Description: Show this description

Comment 2 by mka@chromium.org, Nov 12 2016

Cc: groeck@chromium.org snanda@chromium.org
Components: OS>Packages
Labels: -Type-Bug Performance Type-Feature
Owner: mka@chromium.org
Status: Assigned (was: mka)

Comment 3 by mka@chromium.org, Nov 18 2016

Status: WontFix (was: Assigned)
There has been discussion about extending power_managerd to cover the functionality of laptop-mode-tools ( Issue 666459  &  Issue 214886 ). This is the current/new plan, which makes an update to 1.70 obsolete.

The work done on 1.70 is available in a git sandbox:

https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+log/sandbox/mka/laptop-mode-tools_v1.70

git fetch cros refs/sandbox/mka/laptop-mode-tools_v1.70 && git checkout FETCH_HEAD

The port should be almost complete, I tested USB autosuspend, other runtime PM, WiFi power save mode and cpufreq settings.

Sign in to add a comment