New issue
Advanced search Search tips

Issue 664683 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 635953



Sign in to add a comment

DevTools: switch content/browser/devtools to inspector_protocol

Project Member Reported by dgozman@chromium.org, Nov 12 2016

Issue description

Also reuse state and restore abstractions from blink side.
 
Blocking: 635953
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc4d41727b85a3a2d92499c923fc5614e97dd241

commit dc4d41727b85a3a2d92499c923fc5614e97dd241
Author: dgozman <dgozman@chromium.org>
Date: Tue Nov 15 22:40:56 2016

[DevTools] Use inspector_protocol generator in content/browser/devtools.

This required rolling inspector_protocol to ae736f1e3ac306688c2d7feaa4f43dbdded01ed3:
- [inspector_protocol] Support chromium code style.

BUG= 664683 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2493063005
Cr-Commit-Position: refs/heads/master@{#432276}

[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/content/browser/BUILD.gn
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/content/browser/devtools/BUILD.gn
[add] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/content/browser/devtools/protocol_config.json
[add] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/content/browser/devtools/protocol_string.cc
[add] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/content/browser/devtools/protocol_string.h
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/WebKit/Source/core/inspector/BUILD.gn
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/inspector_protocol/CodeGenerator.py
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/inspector_protocol/README.chromium
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/inspector_protocol/lib/Collections_h.template
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/inspector_protocol/lib/ErrorSupport_cpp.template
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/inspector_protocol/lib/Protocol_cpp.template
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/inspector_protocol/templates/Imported_h.template
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/inspector_protocol/templates/TypeBuilder_cpp.template
[modify] https://crrev.com/dc4d41727b85a3a2d92499c923fc5614e97dd241/third_party/inspector_protocol/templates/TypeBuilder_h.template

Project Member

Comment 3 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d77188631f0c3503585d1e5971366208a0752a38

commit d77188631f0c3503585d1e5971366208a0752a38
Author: dgozman <dgozman@chromium.org>
Date: Wed Nov 16 01:34:39 2016

[DevTools] Introduce DevToolsSession.

This class so far encapsulates session id and dispatcher.
Going forward, it will also contain domain handlers and client (for multi-client support).

BUG= 664683 , 590878 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2499343002
Cr-Commit-Position: refs/heads/master@{#432343}

[modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/BUILD.gn
[modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/devtools_agent_host_impl.h
[add] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/devtools_session.cc
[add] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/forwarding_agent_host.cc
[modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/d77188631f0c3503585d1e5971366208a0752a38/content/browser/devtools/worker_devtools_agent_host.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Nov 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da80d33808f878ae22a5f9909384e18fcf420861

commit da80d33808f878ae22a5f9909384e18fcf420861
Author: dgozman <dgozman@chromium.org>
Date: Sat Nov 19 03:28:19 2016

[DevTools] Move IO and Tracing to new generator.

This also includes roll of inspector_protocol which supports new required features:
73028acaa3646789fd2a3bfd0d79eb2d91b696b3: [inspector_protocol] Support features for content/ generator.

BUG= 664683 

Review-Url: https://codereview.chromium.org/2500093002
Cr-Commit-Position: refs/heads/master@{#433389}

[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/browser_devtools_agent_host.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/devtools_agent_host_impl.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/devtools_io_context.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/devtools_io_context.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/devtools_protocol_handler.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/devtools_protocol_handler.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol/io_handler.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol/io_handler.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol/tracing_handler.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol/tracing_handler.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol/tracing_handler_unittest.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol_string.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/protocol_string.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/content/browser/devtools/worker_devtools_agent_host.cc
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/third_party/WebKit/LayoutTests/inspector-protocol/timeline/fetch-as-stream-expected.txt
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/third_party/WebKit/LayoutTests/inspector/report-protocol-errors-expected.txt
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/third_party/inspector_protocol/README.chromium
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/third_party/inspector_protocol/lib/DispatcherBase_cpp.template
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/third_party/inspector_protocol/lib/DispatcherBase_h.template
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/third_party/inspector_protocol/templates/TypeBuilder_cpp.template
[modify] https://crrev.com/da80d33808f878ae22a5f9909384e18fcf420861/third_party/inspector_protocol/templates/TypeBuilder_h.template

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abbad67b7abea455e83b4bd45b1dafcaf227b0fd

commit abbad67b7abea455e83b4bd45b1dafcaf227b0fd
Author: dgozman <dgozman@chromium.org>
Date: Tue Nov 22 02:37:02 2016

[DevTools] Move Memory, SystemInfo and Tethering domains to new generator.

BUG= 664683 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2515613006
Cr-Commit-Position: refs/heads/master@{#433751}

[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/BUILD.gn
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/browser_devtools_agent_host.h
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/protocol/memory_handler.cc
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/protocol/memory_handler.h
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/protocol/system_info_handler.cc
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/protocol/system_info_handler.h
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/protocol/tethering_handler.cc
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/protocol/tethering_handler.h
[modify] https://crrev.com/abbad67b7abea455e83b4bd45b1dafcaf227b0fd/content/browser/devtools/protocol_config.json

Labels: Hotlist-Polish
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb

commit 64a188e2b27be066f7e3b56b1a8debcbe83f7dbb
Author: dgozman <dgozman@chromium.org>
Date: Fri Dec 02 22:49:34 2016

Roll third_party/inspector_protocol to c65b17da8a32bc6ab25b4ebbef1008f23c69e7d1.

Roll includes:
- [inspector_protocol] Move imported/exported information to config options.
- [inspector_protocol] Restructure generator code.

BUG= 664683 

Review-Url: https://codereview.chromium.org/2544353002
Cr-Commit-Position: refs/heads/master@{#436064}

[modify] https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb/third_party/WebKit/Source/core/inspector/inspector_protocol_config.json
[modify] https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb/third_party/inspector_protocol/CodeGenerator.py
[modify] https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb/third_party/inspector_protocol/README.chromium
[modify] https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb/third_party/inspector_protocol/templates/Exported_h.template
[modify] https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb/third_party/inspector_protocol/templates/Imported_h.template
[modify] https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb/third_party/inspector_protocol/templates/TypeBuilder_cpp.template
[modify] https://crrev.com/64a188e2b27be066f7e3b56b1a8debcbe83f7dbb/third_party/inspector_protocol/templates/TypeBuilder_h.template

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5 2016

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad

commit b4f43e447c1bb2d8e255395aa13a0eaf88a516ad
Author: dgozman <dgozman@chromium.org>
Date: Tue Dec 13 06:12:40 2016

[DevTools] Migrate dom, emulation, inspector, network, page and schema handlers to new generator.

This also includes DevToolsSession::Dispatch utility method
which offers message to DevToolsManagerDelegate.

BUG= 664683 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2548263002
Cr-Commit-Position: refs/heads/master@{#438078}

[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/BUILD.gn
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/browser_devtools_agent_host.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/devtools_session.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/devtools_session.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/page_navigation_throttle.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/page_navigation_throttle.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/color_picker.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/color_picker.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/dom_handler.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/dom_handler.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/emulation_handler.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/emulation_handler.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/inspector_handler.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/inspector_handler.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/network_handler.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/network_handler.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/schema_handler.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol/schema_handler.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/service_worker_devtools_agent_host.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/service_worker_devtools_agent_host.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/worker_devtools_agent_host.cc
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/content/browser/devtools/worker_devtools_agent_host.h
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/third_party/WebKit/LayoutTests/inspector/geolocation-emulation-tests-expected.txt
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt
[modify] https://crrev.com/b4f43e447c1bb2d8e255395aa13a0eaf88a516ad/third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58154cb7b0764702884a7ffb28a5fd3f81ebc249

commit 58154cb7b0764702884a7ffb28a5fd3f81ebc249
Author: dgozman <dgozman@chromium.org>
Date: Tue Dec 13 20:23:18 2016

Revert of [DevTools] Migrate security handler to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2572653003/ )

Reason for revert:
Breaks build: https://build.chromium.org/p/chromium.linux/builders/Linux%20Builder/builds/75946

Original issue's description:
> [DevTools] Migrate security handler to new generator.
>
> BUG= 664683 
> TBR=pfeldman
>
> Committed: https://crrev.com/9bbce3fd6a435ee5950e9cfd069cfdd9ea2596b6
> Cr-Commit-Position: refs/heads/master@{#438267}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 664683 

Review-Url: https://codereview.chromium.org/2567343003
Cr-Commit-Position: refs/heads/master@{#438276}

[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/content/browser/BUILD.gn
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/content/browser/devtools/protocol/security_handler.cc
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/content/browser/devtools/protocol/security_handler.h
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/content/browser/devtools/render_frame_devtools_agent_host.h
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/third_party/WebKit/Source/core/inspector/browser_protocol.json
[modify] https://crrev.com/58154cb7b0764702884a7ffb28a5fd3f81ebc249/third_party/WebKit/Source/devtools/front_end/security/SecurityModel.js

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 14 2016

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81892544ca67cc6ff463c7a5d58bcfadd499594d

commit 81892544ca67cc6ff463c7a5d58bcfadd499594d
Author: tommycli <tommycli@chromium.org>
Date: Wed Dec 14 17:38:55 2016

Revert of [DevTools] Migrate storage domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2572933002/ )

Reason for revert:
Manually confirmed that this patch breaks Lighthouse.

Original issue's description:
> [DevTools] Migrate storage domain to new generator.
>
> BUG= 664683 
> TBR=pfeldman
>
> Committed: https://crrev.com/12183796fb5fe4e41ecfa50b10f8c7631c505bee
> Cr-Commit-Position: refs/heads/master@{#438449}

TBR=caseq@chromium.org,dgozman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 664683 

Review-Url: https://codereview.chromium.org/2576643003
Cr-Commit-Position: refs/heads/master@{#438538}

[modify] https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d/content/browser/BUILD.gn
[modify] https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d/content/browser/devtools/protocol/storage_handler.cc
[modify] https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d/content/browser/devtools/protocol/storage_handler.h
[modify] https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/81892544ca67cc6ff463c7a5d58bcfadd499594d/content/browser/devtools/render_frame_devtools_agent_host.h

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 14 2016

Project Member

Comment 17 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70847052d87dab3241593b925f87b2b96c031b7e

commit 70847052d87dab3241593b925f87b2b96c031b7e
Author: dgozman <dgozman@chromium.org>
Date: Thu Dec 15 22:39:54 2016

Revert of [DevTools] Migrate target domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2574843003/ )

Reason for revert:
Speculative

Original issue's description:
> [DevTools] Migrate target domain to new generator.
>
> BUG= 664683 
> TBR=pfeldman
>
> Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> Cr-Commit-Position: refs/heads/master@{#438733}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 664683 

Review-Url: https://codereview.chromium.org/2578303002
Cr-Commit-Position: refs/heads/master@{#438940}

[modify] https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e/content/browser/BUILD.gn
[modify] https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e/content/browser/devtools/protocol/target_handler.cc
[modify] https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e/content/browser/devtools/protocol/target_handler.h
[modify] https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e/content/browser/devtools/render_frame_devtools_agent_host.h

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 15 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5

commit 2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5
Author: dgozman <dgozman@chromium.org>
Date: Thu Dec 15 22:53:05 2016

Revert of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2573993003/ )

Reason for revert:
Crashes.
BUG= 674474 

Original issue's description:
> [DevTools] Migrate ServiceWorker domain to new generator.
>
> BUG= 664683 
> TBR=pfeldman
>
> Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f
> Cr-Commit-Position: refs/heads/master@{#438676}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 664683 

Review-Url: https://codereview.chromium.org/2577233002
Cr-Commit-Position: refs/heads/master@{#438942}

[modify] https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5/content/browser/BUILD.gn
[modify] https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5/content/browser/devtools/protocol/service_worker_handler.h
[modify] https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5/content/browser/devtools/render_frame_devtools_agent_host.h

Project Member

Comment 19 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b31e7730c9167a6395b702e42fb931002acaca0a

commit b31e7730c9167a6395b702e42fb931002acaca0a
Author: dgozman <dgozman@chromium.org>
Date: Fri Dec 16 04:08:39 2016

Reland of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2577233002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate ServiceWorker domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2573993003/ )
>
> Reason for revert:
> Crashes.
> BUG= 674474 
>
> Original issue's description:
> > [DevTools] Migrate ServiceWorker domain to new generator.
> >
> > BUG= 664683 
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/b41d221cb138f0f5e3824229f12bf794172e106f
> > Cr-Commit-Position: refs/heads/master@{#438676}
>
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 664683 
>
> Committed: https://crrev.com/2cbd54ce7ac7c807af2c9065a6eedd81ac97a3c5
> Cr-Commit-Position: refs/heads/master@{#438942}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 674474 

Review-Url: https://codereview.chromium.org/2580833004
Cr-Commit-Position: refs/heads/master@{#439015}

[modify] https://crrev.com/b31e7730c9167a6395b702e42fb931002acaca0a/content/browser/BUILD.gn
[modify] https://crrev.com/b31e7730c9167a6395b702e42fb931002acaca0a/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/b31e7730c9167a6395b702e42fb931002acaca0a/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/b31e7730c9167a6395b702e42fb931002acaca0a/content/browser/devtools/protocol/service_worker_handler.cc
[modify] https://crrev.com/b31e7730c9167a6395b702e42fb931002acaca0a/content/browser/devtools/protocol/service_worker_handler.h
[modify] https://crrev.com/b31e7730c9167a6395b702e42fb931002acaca0a/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/b31e7730c9167a6395b702e42fb931002acaca0a/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/b31e7730c9167a6395b702e42fb931002acaca0a/content/browser/devtools/render_frame_devtools_agent_host.h

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b35728c5e900f488ef0c1b78cbc3816b6a934fcf

commit b35728c5e900f488ef0c1b78cbc3816b6a934fcf
Author: dgozman <dgozman@chromium.org>
Date: Fri Dec 16 05:31:43 2016

Reland of [DevTools] Migrate target domain to new generator. (patchset #1 id:1 of https://codereview.chromium.org/2578303002/ )

Reason for revert:
Fixed crash reason in https://codereview.chromium.org/2579923002/

Original issue's description:
> Revert of [DevTools] Migrate target domain to new generator. (patchset #2 id:20001 of https://codereview.chromium.org/2574843003/ )
>
> Reason for revert:
> Speculative
>
> Original issue's description:
> > [DevTools] Migrate target domain to new generator.
> >
> > BUG= 664683 
> > TBR=pfeldman
> >
> > Committed: https://crrev.com/a1a32123e28de766b5df3c82ec9ed9f8ddadd724
> > Cr-Commit-Position: refs/heads/master@{#438733}
>
> TBR=caseq@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 664683 
>
> Committed: https://crrev.com/70847052d87dab3241593b925f87b2b96c031b7e
> Cr-Commit-Position: refs/heads/master@{#438940}

TBR=caseq@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 664683 

Review-Url: https://codereview.chromium.org/2581103002
Cr-Commit-Position: refs/heads/master@{#439035}

[modify] https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf/content/browser/BUILD.gn
[modify] https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf/content/browser/devtools/protocol/target_handler.cc
[modify] https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf/content/browser/devtools/protocol/target_handler.h
[modify] https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf/content/browser/devtools/protocol_config.json
[modify] https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/b35728c5e900f488ef0c1b78cbc3816b6a934fcf/content/browser/devtools/render_frame_devtools_agent_host.h

Project Member

Comment 21 by bugdroid1@chromium.org, Dec 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0fd57b76b9b0fb97681f9e7aeb24bc4c40576211

commit 0fd57b76b9b0fb97681f9e7aeb24bc4c40576211
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Fri Dec 16 18:03:30 2016

Roll src/third_party/catapult/ 7a32fcc6a..035bbd33b (1 commit).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/7a32fcc6a55e..035bbd33b52e

$ git log 7a32fcc6a..035bbd33b --date=short --no-merges --format='%ad %ae %s'
2016-12-16 dgozman Do not send null preventFling in SynthesizeScrollGesture.

BUG= 664683 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2577063004
Cr-Commit-Position: refs/heads/master@{#439145}

[modify] https://crrev.com/0fd57b76b9b0fb97681f9e7aeb24bc4c40576211/DEPS

Project Member

Comment 23 by bugdroid1@chromium.org, Dec 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c99acd65573b59a1d18a4715c189c8eb76d1b3d0

commit c99acd65573b59a1d18a4715c189c8eb76d1b3d0
Author: dgozman <dgozman@chromium.org>
Date: Sun Dec 18 20:43:57 2016

[DevTools] Remove old generator in content.

BUG= 664683 
TBR=pfeldman

Review-Url: https://codereview.chromium.org/2573423002
Cr-Commit-Position: refs/heads/master@{#439377}

[modify] https://crrev.com/c99acd65573b59a1d18a4715c189c8eb76d1b3d0/content/browser/BUILD.gn
[modify] https://crrev.com/c99acd65573b59a1d18a4715c189c8eb76d1b3d0/content/browser/devtools/BUILD.gn
[modify] https://crrev.com/c99acd65573b59a1d18a4715c189c8eb76d1b3d0/content/browser/devtools/devtools_agent_host_impl.cc
[modify] https://crrev.com/c99acd65573b59a1d18a4715c189c8eb76d1b3d0/content/browser/devtools/devtools_agent_host_impl.h
[delete] https://crrev.com/31b9f93554bec3e1fb69b7fb45e5770c8aebac73/content/browser/devtools/devtools_protocol_handler.cc
[delete] https://crrev.com/31b9f93554bec3e1fb69b7fb45e5770c8aebac73/content/browser/devtools/devtools_protocol_handler.h
[delete] https://crrev.com/31b9f93554bec3e1fb69b7fb45e5770c8aebac73/content/browser/devtools/protocol/devtools_protocol_client.cc
[delete] https://crrev.com/31b9f93554bec3e1fb69b7fb45e5770c8aebac73/content/browser/devtools/protocol/devtools_protocol_client.h
[delete] https://crrev.com/31b9f93554bec3e1fb69b7fb45e5770c8aebac73/content/browser/devtools/protocol/devtools_protocol_delegate.h
[delete] https://crrev.com/31b9f93554bec3e1fb69b7fb45e5770c8aebac73/content/browser/devtools/protocol/devtools_protocol_handler_generator.py
[modify] https://crrev.com/c99acd65573b59a1d18a4715c189c8eb76d1b3d0/content/browser/devtools/render_frame_devtools_agent_host.cc
[modify] https://crrev.com/c99acd65573b59a1d18a4715c189c8eb76d1b3d0/content/browser/devtools/render_frame_devtools_agent_host.h

Status: Fixed (was: Assigned)

Sign in to add a comment