Support property tree invalidation when main thread scrolling reasons change |
||||
Issue descriptionSee above.
,
Nov 19 2016
See above.
,
Dec 13 2016
I misunderstood how main thread scrolling reasons differ between document and non-document scrollers: http://jsbin.com/fuwiduv vs http://jsbin.com/fiheged. Needs a spv2 fix.
,
Jan 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0f8b383bba59a8240c646a99fb0a5b2afc995d5d commit 0f8b383bba59a8240c646a99fb0a5b2afc995d5d Author: pdr <pdr@chromium.org> Date: Tue Jan 10 00:19:26 2017 Rewrite how paint properties are built with bg:fixed main thread scrolling Background-attachment: fixed forces main thread scrolling. The initial paint property implementation [1] incorrectly allowed subtrees to scroll off the main thread when an ancestor forced main thread scrolling reasons. If there are three nested frames (A->B->C) and B has bg: fixed objects, both B and C should have main thread reasons set (in [1], A and B would). This patch also removes support for non-frame scrollers to change main thread scrolling reasons for bg: fixed so that spv1 and spv2 match. [1] https://chromium.googlesource.com/chromium/src/+/3797c08066b335c81847266d1f16dafc9b21e886 BUG= 664672 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2619393002 Cr-Commit-Position: refs/heads/master@{#442413} [modify] https://crrev.com/0f8b383bba59a8240c646a99fb0a5b2afc995d5d/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp [modify] https://crrev.com/0f8b383bba59a8240c646a99fb0a5b2afc995d5d/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp [modify] https://crrev.com/0f8b383bba59a8240c646a99fb0a5b2afc995d5d/third_party/WebKit/Source/core/paint/PaintPropertyTreeUpdateTests.cpp
,
Jan 23 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Nov 19 2016