[Media Router] Make per-hostname cast mode selections persist |
||
Issue descriptionCurrently if user wants to use a non-default cast mode (e.g. tab-mirroring on YouTube), they must change the cast mode manually every time they cast. We should save user selections so that their last selection for that site/hostname is chosen automatically when they open the dialog. Since the list of per-hostname selections can get long, the pref shouldn't be syncable. We also don't save the selection of desktop mirroring, since that's not related to the sites the user is on. Background info at go/media-router-modes.
,
Dec 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f5da68f68b47ec803e5e9da660c885afb6713efe commit f5da68f68b47ec803e5e9da660c885afb6713efe Author: takumif <takumif@chromium.org> Date: Fri Dec 09 23:42:20 2016 [MR] Cancel auto-switching from tab mirroring to Cast SDK based on user pref This change makes PresentationServiceDelegateImpl cancel requests to join session if they have the "auto-join" presentation ID and the user pref is set to tab mirroring for the origin. This way, when a page requests to auto-switch from tab mirroring to Cast SDK on a site where the user has chosen to use tab mirroring, the auto-switching gets cancelled. This CL relies on a profile pref introduced by https://codereview.chromium.org/2487673003/. BUG= 664671 Review-Url: https://codereview.chromium.org/2517833004 Cr-Commit-Position: refs/heads/master@{#437699} [modify] https://crrev.com/f5da68f68b47ec803e5e9da660c885afb6713efe/chrome/browser/media/router/media_source_helper.cc [modify] https://crrev.com/f5da68f68b47ec803e5e9da660c885afb6713efe/chrome/browser/media/router/media_source_helper.h [modify] https://crrev.com/f5da68f68b47ec803e5e9da660c885afb6713efe/chrome/browser/media/router/presentation_service_delegate_impl.cc [modify] https://crrev.com/f5da68f68b47ec803e5e9da660c885afb6713efe/chrome/browser/media/router/presentation_service_delegate_impl.h [modify] https://crrev.com/f5da68f68b47ec803e5e9da660c885afb6713efe/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc [modify] https://crrev.com/f5da68f68b47ec803e5e9da660c885afb6713efe/chrome/browser/prefs/pref_service_syncable_util.cc
,
Dec 13 2016
,
Dec 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a600d8d8827e214ea10131ce041419118abaec30 commit a600d8d8827e214ea10131ce041419118abaec30 Author: takumif <takumif@chromium.org> Date: Thu Dec 29 00:02:45 2016 [Media Router] Unit tests for sticky cast modes This CL adds test cases to MediaRouterUITest and MediaRouterWebUIMessageHandlerTest that test recording and retrieving users' preferred cast modes (whether they chose tab mirroring for the current origin) in regular and incognito profiles. BUG= 664671 Review-Url: https://codereview.chromium.org/2549323002 Cr-Commit-Position: refs/heads/master@{#440908} [modify] https://crrev.com/a600d8d8827e214ea10131ce041419118abaec30/chrome/browser/ui/webui/media_router/media_router_ui.cc [modify] https://crrev.com/a600d8d8827e214ea10131ce041419118abaec30/chrome/browser/ui/webui/media_router/media_router_ui.h [modify] https://crrev.com/a600d8d8827e214ea10131ce041419118abaec30/chrome/browser/ui/webui/media_router/media_router_ui_unittest.cc [modify] https://crrev.com/a600d8d8827e214ea10131ce041419118abaec30/chrome/browser/ui/webui/media_router/media_router_webui_message_handler.h [modify] https://crrev.com/a600d8d8827e214ea10131ce041419118abaec30/chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Nov 30 2016