New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664668 link

Starred by 2 users
Status: Fixed
Owner:
bsep@chromium.org
Closed: Apr 2017
Cc:
█ meade@chromium.org
rbyers@chromium.org
foolip@chromium.org
█ tabatkins@chromium.org
chrishtr@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Launch-OWP
Launch-Accessibility: ----
Launch-Exp-Leadership: ----
Launch-Leadership: ----
Launch-Legal: ----
Launch-M-Approved: ----
Launch-M-Target: 59-Dev , 59-Beta , 59-Stable-Exp , 59-Stable
Launch-Privacy: ----
Launch-Security: ----
Launch-Test: ----
Launch-UI: ----
Rollout-Type: ----

Blocked on:
issue 668251
Blocking:
issue 714278



Sign in to add a comment

Remove "reset" and "document" as valid zoom values in CSS.

Project Member Reported by bsep@chromium.org, Nov 11 2016 
Change description:
Remove "reset" and "document" as valid zoom values in CSS.

Deprecation M-56, removal M-57.

Changes to API surface:
* "reset" no longer a valid value for zoom
* "document" no longer a valid value for zoom

Links:
Public standards discussion:
Zoom is not in the CSS standard. These properties existed in WebKit before the Blink branch. No other rendering engine supports them.

Removal discussion here: https://groups.google.com/a/chromium.org/forum/#!msg/Blink-dev/Udxmfvq4Wf8/Jy4VsQxGAQAJ

Support in other browsers:
Internet Explorer: None
Firefox: None
Safari: Supported

Comment 1 by bsep@chromium.org, Nov 23 2016

Blockedon: 668251

Comment 2 by bsep@chromium.org, Feb 11 2017

Labels: -M-57 M-59
It took me a long time to do the refactor in  issue 668251  so I'm retargeting: deprecation 58 and removal 59.

Comment 3 by meade@chromium.org, Feb 13 2017

Cc: meade@chromium.org
Labels: Update-Monthly Objective
Adding Blink>CSS tracking labels.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1

commit c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1
Author: bsep <bsep@chromium.org>
Date: Thu Feb 16 04:44:06 2017

Deprecate CSS values zoom:reset and zoom:document.

Add a deprecation message and output to the console when zoom:reset or
zoom:document are used in preparation for their removal.

BUG= 664668 , 642613 

Review-Url: https://codereview.chromium.org/2689063002
Cr-Commit-Position: refs/heads/master@{#450871}

[modify] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/LayoutTests/fast/css-generated-content/table-with-scrollbar-corner.html
[add] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties-expected.txt
[add] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html
[modify] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/LayoutTests/fast/css/zoom-font-size.html
[modify] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/LayoutTests/fast/css/zoom-on-unattached.html
[modify] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/Source/core/css/parser/CSSParserContext.cpp
[modify] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/Source/core/css/parser/CSSParserContext.h
[modify] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp
[modify] https://crrev.com/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1/third_party/WebKit/Source/core/frame/Deprecation.cpp

Comment 6 by bsep@chromium.org, Apr 26 2017

Labels: Merge-Request-59
Project Member

Comment 7 by sheriffbot@chromium.org, Apr 27 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 8 by rbyers@chromium.org, Apr 27 2017

Labels: Launch-M-Target-59-Dev Launch-M-Target-59-Beta Launch-M-Target-59-Stable-Exp Launch-M-Target-59-Stable
Note that zoom:reset was broken under use-zoom-for-dsf (issue 485650 - currently enabled for Windows, Linux, ChromeOS and Android but not Mac).  See  issue 714278 .  But since we've just removed zoom:reset support completely the problem has gone away :-)

Comment 9 by rbyers@chromium.org, Apr 27 2017

Blocking: 714278
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 27 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30a210d86eaf8ca5bf2941a6bbee44b867300c6b

commit 30a210d86eaf8ca5bf2941a6bbee44b867300c6b
Author: Bret Sepulveda <bsep@chromium.org>
Date: Thu Apr 27 22:42:27 2017

Delete deprecated properties zoom:reset and zoom:document.

BUG= 664668 , 642613 

Review-Url: https://codereview.chromium.org/2821843002
Cr-Commit-Position: refs/heads/master@{#467454}
(cherry picked from commit 36095a2996117ee0b77d0badc9b237ea4d686521)

Review-Url: https://codereview.chromium.org/2846783005 .
Cr-Commit-Position: refs/branch-heads/3071@{#277}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[delete] https://crrev.com/1c0d3e95679659c1b01785b9fc666aa9a8de0431/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties-expected.txt
[delete] https://crrev.com/1c0d3e95679659c1b01785b9fc666aa9a8de0431/third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html
[modify] https://crrev.com/30a210d86eaf8ca5bf2941a6bbee44b867300c6b/third_party/WebKit/Source/core/css/properties/CSSPropertyAPIZoom.cpp
[modify] https://crrev.com/30a210d86eaf8ca5bf2941a6bbee44b867300c6b/third_party/WebKit/Source/core/css/resolver/StyleBuilderCustom.cpp
[modify] https://crrev.com/30a210d86eaf8ca5bf2941a6bbee44b867300c6b/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/30a210d86eaf8ca5bf2941a6bbee44b867300c6b/third_party/WebKit/Source/core/frame/UseCounter.h

Comment 11 by bsep@chromium.org, Apr 27 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment