W3C auto-import fails when upstream repo has ref test with non-existent ref file. |
||
Issue descriptionThis happened this week: The test wpt/html/semantics/grouping-content/the-li-element/grouping-li-reftest-no-list-owner.html is a ref test that should have a reference file upstream called wpt/html/semantics/grouping-content/the-li-element/grouping-li-reftest-no-list-owner.html https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7788/steps/update%20wpt/logs/stdio In this case, the ideal behavior is that the importer should import all other tests, and give a clear error message about the test that should be fixed.
,
Nov 11 2016
No problem - yeah, I wonder if the wpt lint script could be easily modified to catch such things in the future...
,
Nov 13 2016
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b3c467a500e59cb7af25829968118287179ddb86 commit b3c467a500e59cb7af25829968118287179ddb86 Author: qyearsley <qyearsley@chromium.org> Date: Wed Nov 16 18:55:59 2016 W3C test importer: skip ref test if ref file not found. Reason: When auto-importing tests, is there's an issue with one test, in general we want to print an error message and continue trying to import any tests that can be imported. BUG= 664663 Review-Url: https://codereview.chromium.org/2497673003 Cr-Commit-Position: refs/heads/master@{#432576} [modify] https://crrev.com/b3c467a500e59cb7af25829968118287179ddb86/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py [modify] https://crrev.com/b3c467a500e59cb7af25829968118287179ddb86/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
,
Nov 17 2016
|
||
►
Sign in to add a comment |
||
Comment 1 by domenic@chromium.org
, Nov 11 2016