Issue metadata
Sign in to add a comment
|
Fix and reenableload:games:miniclip system health story on Mac perf bots |
||||||||||||||||||||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%20Retina%20Perf%20%281%29?numbuilds=200 It becomes very flaky since 11/4. Now failing. Traceback (most recent call last): File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 79, in _RunStoryAndProcessErrorIfNeeded test.WillRunStory(state.platform) File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py", line 279, in WillRunStory platform.tracing_controller.StartTracing(self._tbm_options.config) File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/core/tracing_controller.py", line 43, in StartTracing self._tracing_controller_backend.StartTracing(tracing_config, timeout) File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py", line 91, in StartTracing if agent.StartAgentTracing(config, timeout): File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py", line 73, in StartAgentTracing self._battor.StartTracing() File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py", line 209, in StartTracing self._FlashBattOr() File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py", line 150, in _FlashBattOr self.StopShell() File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py", line 188, in StopShell self._SendBattOrCommand(self._EXIT_CMD, check_return=False) File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py", line 317, in _SendBattOrCommand status = self._SendBattOrCommandImpl(cmd) File "/b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py", line 312, in _SendBattOrCommandImpl self._battor_shell.stdin.write('%s\n' % cmd) IOError: [Errno 32] Broken pipe INFO:root:Try printing formatted exception: None None None Exception raised when cleaning story run: Traceback (most recent call last): _RunStoryAndProcessErrorIfNeeded at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:106 state.DidRunStory(results) traced_function at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py:75 return func(*args, **kwargs) DidRunStory at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py:155 if self._current_page.credentials and self._did_login_for_current_page: AttributeError: 'NoneType' object has no attribute 'credentials' Locals: results : <telemetry.internal.results.page_test_results.PageTestResults object at 0x103920fd0> [ FAILED ] browse:media:imgur (3238 ms) INFO:root:Try printing formatted exception: None None None Traceback (most recent call last): RunBenchmark at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:343 benchmark.ShouldTearDownStateAfterEachStorySetRun()) Run at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:229 _RunStoryAndProcessErrorIfNeeded(story, results, state, test) _RunStoryAndProcessErrorIfNeeded at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py:79 test.WillRunStory(state.platform) WillRunStory at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py:279 platform.tracing_controller.StartTracing(self._tbm_options.config) StartTracing at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/core/tracing_controller.py:43 self._tracing_controller_backend.StartTracing(tracing_config, timeout) StartTracing at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:91 if agent.StartAgentTracing(config, timeout): StartAgentTracing at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/battor_tracing_agent.py:73 self._battor.StartTracing() StartTracing at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py:209 self._FlashBattOr() _FlashBattOr at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py:150 self.StopShell() StopShell at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py:188 self._SendBattOrCommand(self._EXIT_CMD, check_return=False) _SendBattOrCommand at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py:317 status = self._SendBattOrCommandImpl(cmd) _SendBattOrCommandImpl at /b/c/b/Mac_Retina_Perf__1_/src/third_party/catapult/common/battor/battor/battor_wrapper.py:312 self._battor_shell.stdin.write('%s\n' % cmd) IOError: [Errno 32] Broken pipe Locals: cmd : 'Exit'
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1 commit 14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1 Author: zhenw <zhenw@chromium.org> Date: Sat Nov 12 16:47:53 2016 Revert of Disable system_health.common_desktop on Mac and Win10 perf bots (patchset #1 id:1 of https://codereview.chromium.org/2498753002/ ) Reason for revert: According to Ned, we should disable the failing story only. Reverting this CL. Will disable the story on Monday. Original issue's description: > Disable system_health.common_desktop on Mac and Win10 perf bots > > TBR=nednguyen@google.com > BUG=657665, 653893 , 664661 > > Committed: https://crrev.com/93d3a4a026d6ad24981f394883b9947edda80bdf > Cr-Commit-Position: refs/heads/master@{#431774} TBR= # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=657665, 653893 , 664661 Review-Url: https://codereview.chromium.org/2498693003 Cr-Commit-Position: refs/heads/master@{#431789} [modify] https://crrev.com/14fb7d6c1402cc65aa85bbb3eba5cea0cf2426b1/tools/perf/benchmarks/system_health.py
,
Nov 14 2016
Mac Retina Perf (1): failed load:games:miniclip https://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%20Retina%20Perf%20%281%29?numbuilds=200 Mac Air 10.11 Perf: failed browse:social:twitter https://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%20Air%2010.11%20Perf?numbuilds=200
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f738074d9f00eb126d3ffad6ad40e0a2b7292691 commit f738074d9f00eb126d3ffad6ad40e0a2b7292691 Author: zhenw <zhenw@chromium.org> Date: Mon Nov 14 22:59:46 2016 Disable load:games:miniclip on Mac perf bots BUG= 664661 Review-Url: https://codereview.chromium.org/2499993002 Cr-Commit-Position: refs/heads/master@{#431943} [modify] https://crrev.com/f738074d9f00eb126d3ffad6ad40e0a2b7292691/tools/perf/page_sets/system_health/loading_stories.py
,
Nov 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d4c02aa0d46a7fe3bf66c97e70921f653ff4913f commit d4c02aa0d46a7fe3bf66c97e70921f653ff4913f Author: zhenw <zhenw@chromium.org> Date: Mon Nov 14 23:25:18 2016 Disable browse:social:twitter on Mac perf bots BUG= 664661 , 663025 Review-Url: https://codereview.chromium.org/2501623002 Cr-Commit-Position: refs/heads/master@{#431964} [modify] https://crrev.com/d4c02aa0d46a7fe3bf66c97e70921f653ff4913f/tools/perf/page_sets/system_health/browsing_stories.py
,
Nov 15 2016
,
Nov 15 2016
,
Dec 21 2016
browse:social:twitter is also followed on issue 663025 , let's make this one about load:games:miniclip only. Also removing charlie from owner, needs triage.
,
Jan 11 2017
Grabbing this, but have no idea when I'll realistically get to it.
,
Jun 22 2017
,
Jun 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eef1400f407d1cbdb1c66469e05b7b7f7ab9bdbd commit eef1400f407d1cbdb1c66469e05b7b7f7ab9bdbd Author: Charlie Andrews <charliea@google.com> Date: Thu Jun 22 22:01:14 2017 Reenable load:games:miniclip on Mac I ran it locally, and it now seems to be having no problems TBR=perezju@chromium.org Bug: 664661 Change-Id: Ia8201db53d9687f4cc23736e29f3e45a1a2062fa Reviewed-on: https://chromium-review.googlesource.com/544905 Reviewed-by: Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#481683} [modify] https://crrev.com/eef1400f407d1cbdb1c66469e05b7b7f7ab9bdbd/tools/perf/page_sets/system_health/expectations.py
,
Jun 24 2017
The NextAction date has arrived: 2017-06-24
,
Jun 26 2017
Marking this as fixed - seems like it's passing on all the bots now. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 12 2016