Issue metadata
Sign in to add a comment
|
Version control Sheriff-o-Matic configuration |
||||||||||||||||||||||||
Issue descriptionRight now there are a lot of little things being hard coded into special cases. Like the help links that show up for webkit tests and such. And there are a lot of things that would be nice to make configurable. Like the message that appears at the top of the tree telling sheriffs to start at the top and try to clear all the alerts. And there would be a lot of little other things in the future that would be nice to expose in configuration. For example, it looks like many clients have some sort of bug queue but they seem to handle them in completely different ways. More configuration will make our lives easier to adapt to changing needs and allow us to better reuse code between different use cases. The current admin panel has some configuration but it should be reworked to allow for more configuration. We might want to create separate pages for each tree so that there can be a lot more configuration options. Or, perhaps it might make sense to change the configuration to be JSON-based instead? Right now there is a decent amount of configuration that has to be synced between production and staging. Using JSON files that are part of the repo could help add some more stability here, especially as the configuration gets more complex. It'd also be easier to represent complex configuration modes this way (not having to flatten all configuration into something easy to represent in user input). Having to edit code to change tree settings is a disadvantage here though. Or something else. Just random thoughts here.
,
Nov 22 2016
This bug has some reference to desiring more configuration: https://bugs.chromium.org/p/chromium/issues/detail?id=664169
,
Nov 22 2016
,
Nov 28 2016
A note here that I have a CL in progress here that I will put on hold for now: https://chromium-review.googlesource.com/c/413665/ Moving to luci-config seems like maybe the way to go on this.
,
Dec 19 2016
There is an owner on this bug, but the status was not "Assigned" or "Started". Fixing. If you do not own this bug, please remove yourself as the owner and make the status "Available".
,
May 26 2017
Resurrecting this bug because Sheriff-o-Matic currently has a lot of little conditionals scattered all over the code. There are examples of hardcoded things in Sheriff-o-Matic that I'd like to have separated out into their own configuration: - Whether a tree has a bug queue or not - Mostly calculated by the label's existence but a special case exists to hide the bug queue for Performance-Sheriff-BotHealth. (This should probably be accomplished by creating separate labels for pulling the bug queue and for filing bugs) - Tree status app URLs to trees. - The order of sections per tree. (ie: bug queue at the bottom for Chrome OS, at the top for troopers) - Whether a tree has grouping, resolving, etc enabled - The name of the rotation tied to a tree (used to get the current on calls) /admin/settings is getting pretty cluttered and having to create a UI to edit every setting we add is a bit more heavyweight than I would want. Ideally, settings should be easy to just sort of mock up on the fly so we don't have to spend too much time considering whether it's worth it to make a new setting out of something. Originally, I wanted to just add JSON files to the frontend as a starting incremental step that at least pulls all the various configs hardcoded into the frontend into one place. Though then we decided that luci-config would be better. With luci config, I think we could also replace the settings currently stored in the Go backend as well? I think we'd still need to keep a list of all the trees, but settings that are really only there to be passed into the frontend like playbook links, bug queue labels, tree display names, etc could be moved out. Probably I should write a mini-design doc for this eventually, I think.
,
Aug 30 2017
Update: We should work towards merging Gatekeeper_trees.json into Sheriff-o-Matic and adding Sheriff-o-Matic specific config into this file, so that there is one unified source of configuration what a tree is.
,
Aug 30 2017
Not strictly blocking the Chromium Status migration, but I would really like to track this as part of that.
,
Sep 21 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by zhangtiff@chromium.org
, Nov 18 2016