New issue
Advanced search Search tips

Issue 664650 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Pretty print fix for CSS coverage decorations.

Project Member Reported by valih@google.com, Nov 11 2016

Issue description

The css coverage decorations are now getting adjusted when the source is formatted by the pretty print.
 
Labels: Needs-Feedback
valih@, can you please provide more information on how to reproduce the issue so that we can try it at our end to confirm the issue ?
Components: Blink>CSS

Comment 3 by timloh@chromium.org, Nov 17 2016

Components: -Blink>CSS Platform>DevTools

Comment 4 by l...@chromium.org, Nov 17 2016

Labels: -Needs-Feedback
Owner: caseq@chromium.org
Status: Assigned (was: Unconfirmed)
Sounds like repro steps are:
- Make a timeline recording
- Go to a CSS file in sources to see rendered CSS coverage decorations
- Pretty print the CSS file
- Observe that the coverage decorations have shifted are no longer in the correct positions

Reassigning owner since @caseq works closest with valih@.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c

commit 354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c
Author: valih <valih@google.com>
Date: Fri Nov 18 19:58:25 2016

Devtools: The css coverage decorations are now getting adjusted after the source is formatted by the pretty print.

BUG= 664650 

Review-Url: https://codereview.chromium.org/2492343002
Cr-Commit-Position: refs/heads/master@{#433271}

[add] https://crrev.com/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c/third_party/WebKit/LayoutTests/inspector/tracing/decorations-after-inplace-formatter-expected.txt
[add] https://crrev.com/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c/third_party/WebKit/LayoutTests/inspector/tracing/decorations-after-inplace-formatter.html
[add] https://crrev.com/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c/third_party/WebKit/LayoutTests/inspector/tracing/resources/decorations-after-inplace-formatter.css
[modify] https://crrev.com/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c/third_party/WebKit/Source/devtools/front_end/components_lazy/CoverageProfile.js
[modify] https://crrev.com/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c/third_party/WebKit/Source/devtools/front_end/components_lazy/LineLevelProfile.js
[modify] https://crrev.com/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c/third_party/WebKit/Source/devtools/front_end/sources/InplaceFormatterEditorAction.js
[modify] https://crrev.com/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c/third_party/WebKit/Source/devtools/front_end/timeline/TimelineController.js
[modify] https://crrev.com/354cd6c5a2e6b2a8423816eecada2aeeb5a1a41c/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js

Comment 6 by caseq@chromium.org, Nov 28 2017

Status: Fixed (was: Assigned)

Sign in to add a comment