Bug in compressedTexImage2D/compressedTexSubImage2D taking views with offsets |
||||
Issue descriptionjbauman@ found in https://bugs.chromium.org/p/chromium/issues/detail?id=646538#c1 that WebglConformance_conformance2_misc_views_with_offsets is failing on the Mac ASAN bot with an apparently real out-of-bounds read. This needs to be investigated and fixed.
,
Nov 11 2016
,
Nov 14 2016
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fa298aceb14ff8370addedf502c9fdf7a6f3a1f commit 1fa298aceb14ff8370addedf502c9fdf7a6f3a1f Author: zmo <zmo@chromium.org> Date: Tue Nov 15 03:35:29 2016 Fix a minor bug in compressedTex{Sub}Image in blink. The issue is in error case, we should return early instead of calling into lower level APIs. Otherwise out-of-bounds visits happen. BUG= 664643 TEST=asan build with views-with-offsets.html R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2501243002 Cr-Commit-Position: refs/heads/master@{#432072} [modify] https://crrev.com/1fa298aceb14ff8370addedf502c9fdf7a6f3a1f/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp
,
Nov 15 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by kbr@chromium.org
, Nov 11 2016