New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.
Starred by 34 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 6
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task


Sign in to add a comment

Web Authentication API for Chrome

Project Member Reported by kpaulhamus@chromium.org, Nov 11 2016

Issue description

Change description:
Implement the web authentication API for Chrome. 

Changes to API surface:
Introduction of authentication.makeCredential and authentication.getAssertion interfaces.

Links:
https://w3c.github.io/webauthn/

Support in other browsers:
Internet Explorer: In development
Firefox: In development
 

Comment 1 by owe...@chromium.org, Nov 17 2016

Is there a corresponding type=launch issue for tracking security and privacy approval for this change?
There isn't, currently. Should I create one, or can that be tracked in this issue?
If there is a PM helping out with this I'd recommend you chat to them about setting up a type=launch issue for this.

type=launch issues are needed for any changes with security/privacy/ui/legal/etc changes and are separate to the launch-owp issues (type=launch are Google-private and for approvals, type=launch-owp are public and for community and cross-browser tracking of standards and implementation aspects)

If there isn't, feel free to reach out to the closest PM to you and cc me over email and we can work out what to do.

Comment 4 by owe...@chromium.org, Dec 10 2016

Once a type=launch issue is created please link to it from here and mark it as blocking this issue so we ensure it gets finished before this launches.

Also for more context on type=launch vs type=launch-owp issues you can see this doc: https://drive.google.com/open?id=1Z9x-PBYgDaR99tsNLvhibZLeAwDR757Gor--I60ygeE
Cc: -aczeskis@chromium.org aczeskis@google.com
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d43296f5c9c5c7f5f362ea599881fbd28df4898

commit 8d43296f5c9c5c7f5f362ea599881fbd28df4898
Author: kpaulhamus <kpaulhamus@chromium.org>
Date: Sat Jan 21 01:24:24 2017

Add WebAuthn bindings and client interface.

This CL adds the WebAuthn bindings and interface to support
WebAuthentication.makeCredential and WebAuthentication.getAssertion.

The draft spec is here: https://w3c.github.io/webauthn/

The interface is likely to change as the spec matures. We're tracking the
comments and suggestions from this review via issues opened with the working
group:
https://github.com/w3c/webauthn/issues/310
https://github.com/w3c/webauthn/issues/311
https://github.com/w3c/webauthn/issues/312
https://github.com/w3c/webauthn/issues/313

This patch also proactively implements the change to WebAuthnAttestation
suggested here: https://github.com/w3c/webauthn/issues/244

BUG= 664630 

Review-Url: https://codereview.chromium.org/2533863002
Cr-Commit-Position: refs/heads/master@{#445239}

[modify] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/LayoutTests/external/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
[modify] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/BUILD.gn
[modify] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/modules_idl_files.gni
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/AuthenticationAssertion.h
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/AuthenticationAssertion.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/AuthenticationAssertionOptions.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/AuthenticationClientData.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/AuthenticationExtensions.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/BUILD.gn
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/DEPS
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/NavigatorAuth.cpp
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/NavigatorAuth.h
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/NavigatorAuth.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/RelyingPartyAccount.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/ScopedCredential.h
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/ScopedCredential.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/ScopedCredentialDescriptor.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/ScopedCredentialInfo.h
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/ScopedCredentialInfo.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/ScopedCredentialOptions.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/ScopedCredentialParameters.idl
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
[add] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/modules/webauth/WebAuthentication.idl
[modify] https://crrev.com/8d43296f5c9c5c7f5f362ea599881fbd28df4898/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6adcf35d6ca7f2c4cfb6536880e996fc877a50d1

commit 6adcf35d6ca7f2c4cfb6536880e996fc877a50d1
Author: kpaulhamus <kpaulhamus@chromium.org>
Date: Thu Feb 09 20:10:14 2017

Added idlharness test for webauth

Needs the "-expected.txt" file due to issue with DOM prototypes identifiers:
See https://crbug.com/643712.

BUG= 664630 

Review-Url: https://codereview.chromium.org/2623003002
Cr-Commit-Position: refs/heads/master@{#449384}

[add] https://crrev.com/6adcf35d6ca7f2c4cfb6536880e996fc877a50d1/third_party/WebKit/LayoutTests/webauth/idl-expected.txt
[add] https://crrev.com/6adcf35d6ca7f2c4cfb6536880e996fc877a50d1/third_party/WebKit/LayoutTests/webauth/idl.html

Labels: -M-58 M-60
Components: Blink>WebAuthentication
Blocking: 674593
I don't see RelyingPartyAccount in any spec. Are we planning to standardize it in the future? 
I had pre-empted https://github.com/w3c/webauthn/pull/344 to rename Account. We actually ended up with RelyingPartyUserInfo, which I'll update in the implementation.
Cc: foolip@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, May 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb

commit b1f03c340eaaf193e6d4cae7047600c0eddd5ffb
Author: kpaulhamus <kpaulhamus@chromium.org>
Date: Sat May 13 00:00:52 2017

Add webauth makeCredential mojom.

Patch #1 of multiple

This patch adds the webauth authenticator mojom interface. It has the function makeCredential and necessary structs. The function is used by the WebAuthentication class.

BUG= 664630 

Review-Url: https://codereview.chromium.org/2702653002
Cr-Commit-Position: refs/heads/master@{#471498}

[add] https://crrev.com/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb/components/webauth/BUILD.gn
[add] https://crrev.com/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb/components/webauth/OWNERS
[add] https://crrev.com/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb/components/webauth/authenticator.mojom
[modify] https://crrev.com/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb/third_party/WebKit/LayoutTests/webauth/idl.html
[modify] https://crrev.com/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb/third_party/WebKit/Source/modules/webauth/BUILD.gn
[modify] https://crrev.com/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb/third_party/WebKit/Source/modules/webauth/DEPS
[modify] https://crrev.com/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb/third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp
[modify] https://crrev.com/b1f03c340eaaf193e6d4cae7047600c0eddd5ffb/third_party/WebKit/Source/modules/webauth/WebAuthentication.h

Blockedon: 733029
Blockedon: 733033
Blockedon: 733035
Cc: battre@chromium.org
Cc: engedy@chromium.org mkwst@chromium.org jochen@chromium.org
Project Member

Comment 18 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b

commit 7c9f0094c6c0c202aa8d7219b89a5909edd74f1b
Author: kpaulhamus <kpaulhamus@chromium.org>
Date: Fri Jun 30 11:08:45 2017

This change adds the Mojo implementation of authenticator.mojom's MakeCredential.

The remainder of the implementation to call U2F.register() is in a follow-up CL.

BUG= 664630 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2788823002
Cr-Commit-Position: refs/heads/master@{#483675}

[delete] https://crrev.com/d829d85d98e95d4453eba1c655c38d55bd82f37a/components/webauth/BUILD.gn
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/browser/BUILD.gn
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/browser/DEPS
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/browser/frame_host/render_frame_host_impl.cc
[add] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/browser/webauth/OWNERS
[add] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/browser/webauth/authenticator_impl.cc
[add] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/browser/webauth/authenticator_impl.h
[add] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/child/runtime_features.cc
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/public/app/mojo/content_browser_manifest.json
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/public/common/content_features.cc
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/public/common/content_features.h
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/content/test/BUILD.gn
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/Source/modules/webauth/BUILD.gn
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/Source/modules/webauth/DEPS
[add] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/Source/modules/webauth/OWNERS
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/Source/platform/exported/WebRuntimeFeatures.cpp
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/public/platform/WebRuntimeFeatures.h
[add] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/public/platform/modules/webauth/BUILD.gn
[rename] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/public/platform/modules/webauth/OWNERS
[rename] https://crrev.com/7c9f0094c6c0c202aa8d7219b89a5909edd74f1b/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom

Project Member

Comment 19 by bugdroid1@chromium.org, Jul 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/04b66da848df095ca21d54194b7c59b0d01526ab

commit 04b66da848df095ca21d54194b7c59b0d01526ab
Author: kpaulhamus <kpaulhamus@chromium.org>
Date: Fri Jul 14 02:52:54 2017

Blink-layer update to match WebAuthN spec

1 of many CLs to merge WebAuthN with the Cred Man API. This change
renames idl components and updates the corresponding idl test.
(This changes as much as possible short of depending on anything in
credential manager).

BUG= 664630 

Review-Url: https://codereview.chromium.org/2966523002
Cr-Commit-Position: refs/heads/master@{#486648}

[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/LayoutTests/webauth/idl-expected.txt
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/LayoutTests/webauth/idl.html
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/modules_idl_files.gni
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/AuthenticationAssertion.h
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/AuthenticationAssertion.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/AuthenticationAssertionOptions.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/AuthenticationClientData.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/AuthenticationExtensions.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.cpp
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.h
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorAssertionResponse.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.cpp
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.h
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorAttestationResponse.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorResponse.cpp
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorResponse.h
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorResponse.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/AuthenticatorSelectionCriteria.idl
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/BUILD.gn
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/CollectedClientData.idl
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/DEPS
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/MakeCredentialOptions.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/PublicKeyCredential.cpp
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/PublicKeyCredential.h
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/PublicKeyCredential.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialDescriptor.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialEntity.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialParameters.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl
[add] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialUserEntity.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/RelyingPartyAccount.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/ScopedCredential.h
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/ScopedCredential.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/ScopedCredentialDescriptor.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/ScopedCredentialInfo.h
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/ScopedCredentialInfo.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/ScopedCredentialOptions.idl
[delete] https://crrev.com/c23f8d441fb8c5924fbfa0fb32742a664d2c33cb/third_party/WebKit/Source/modules/webauth/ScopedCredentialParameters.idl
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/WebAuthentication.cpp
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/WebAuthentication.h
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/Source/modules/webauth/WebAuthentication.idl
[modify] https://crrev.com/04b66da848df095ca21d54194b7c59b0d01526ab/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom

Blockedon: 752690
Labels: migrated-launch-owp Type-Task
This issue has been automatically relabelled type=task because type=launch-owp issues are now officially deprecated. The deprecation is because they were creating confusion about how to get launch approvals, which should be instead done via type=launch issues.

We recommend this issue be used for implementation tracking (for public visibility), but if you already have an issue for that, you may mark this as duplicate.

For more details see here: https://docs.google.com/document/d/1JA6RohjtZQc26bTrGoIE_bSXGXUDQz8vc6G0n_sZJ2o/edit

For any questions, please contact owencm, sshruthi, larforge
Blocking: 768486
Cc: -foolip@chromium.org

Comment 24 by ztr...@gmail.com, Oct 11 2017

Is any progress being made on this? Edge has had it implemented for a while.
The WebAuthn spec is still being iterated upon.  During a recent WebAuthn interop, the 3 participating browsers had a similar level of implementation.

I do not believe the statement "Edge has had it implemented for a while." is correct.

To answer your original question: yes, progress is being made.
Project Member

Comment 26 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef10f86671cfedfe5257395ed3dc70756eaef935

commit ef10f86671cfedfe5257395ed3dc70756eaef935
Author: Jun Choi <hongjunchoi@google.com>
Date: Thu Nov 09 01:04:33 2017

Added feature to prevent duplicate registration

If exclude list parameter is provided during the registration process,
then all the devices are checked for duplicate registration by calling
'check-only' sign to device. If any one of the device response with
success, this means that there is duplicate registration and process is
terminated after waiting for user presence verification and response
code U2fReturnCode::CONDITIONS_NOT_SATISFIED is returned to the caller.
If all devices pass the duplication registration check, then we proceed
to normal registration process.

Bug:  664630 
Change-Id: Iaa70490084c7086185e721b5e22d30f73ee9b66d
Reviewed-on: https://chromium-review.googlesource.com/739927
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515041}
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_apdu_command.cc
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_apdu_command.h
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_device.cc
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_device.h
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_register.cc
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_register.h
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_register_unittest.cc
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_request.cc
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_request.h
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_sign.cc
[modify] https://crrev.com/ef10f86671cfedfe5257395ed3dc70756eaef935/device/u2f/u2f_sign.h

Cc: jdoerrie@chromium.org
Blockedon: 785950 785954 785955 785957 785958
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbe092bfffb23f62793a7cda069e1edd5b082b2d

commit fbe092bfffb23f62793a7cda069e1edd5b082b2d
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Tue Nov 21 16:46:08 2017

Hook WebAuthN to //device/u2f to perform credential registration.

This change implements the browser-side of authenticator.mojom to
build and send a U2F-style request to //device/u2f to talk to a
hardware authenticator. This also adds a utility class to map the u2f
response from U2fDevice to a CTAP response per the FIDO2 and WebAuthN specs.

Bug:  664630 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I7d5f9e2308c45fdd8ca9463a8a78c2f88d9aeb80
Reviewed-on: https://chromium-review.googlesource.com/710516
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518277}
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/BUILD.gn
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/frame_host/render_frame_host_impl.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/DEPS
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/attestation_data.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/attestation_data.h
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/attestation_object.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/attestation_object.h
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/attestation_statement.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/attestation_statement.h
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/authenticator_data.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/authenticator_data.h
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/authenticator_impl_unittest.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/authenticator_utils.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/authenticator_utils.h
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/collected_client_data.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/collected_client_data.h
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/ec_public_key.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/ec_public_key.h
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/fido_attestation_statement.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/fido_attestation_statement.h
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/public_key.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/public_key.h
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/register_response_data.cc
[add] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/browser/webauth/register_response_data.h
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/content/test/BUILD.gn
[delete] https://crrev.com/d45b3138465f57ee269ddcde848b6b056990e656/third_party/WebKit/LayoutTests/external/wpt/credential-management/credentialscontainer-create-basics.https-expected.txt
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/third_party/WebKit/LayoutTests/external/wpt/credential-management/credentialscontainer-create-basics.https.html
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/authenticator-helpers.js
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.cpp
[modify] https://crrev.com/fbe092bfffb23f62793a7cda069e1edd5b082b2d/third_party/WebKit/public/platform/WebCredentialManagerError.h

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 22 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/60bd36815a5b2af047bb20ac443d30cb5a8d4766

commit 60bd36815a5b2af047bb20ac443d30cb5a8d4766
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Wed Nov 22 17:24:16 2017

Have RenderFrameHost own the Authenticator service implementation

Also update the expected WPT test results for a test that was correctly
failing, but for the wrong reasons.

Bug:  664630 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: If8e4d090063c36fc7c480e2bd665ebafca53f123
Reviewed-on: https://chromium-review.googlesource.com/779631
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518667}
[modify] https://crrev.com/60bd36815a5b2af047bb20ac443d30cb5a8d4766/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/60bd36815a5b2af047bb20ac443d30cb5a8d4766/content/browser/frame_host/render_frame_host_impl.h
[modify] https://crrev.com/60bd36815a5b2af047bb20ac443d30cb5a8d4766/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/60bd36815a5b2af047bb20ac443d30cb5a8d4766/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/60bd36815a5b2af047bb20ac443d30cb5a8d4766/content/browser/webauth/authenticator_impl_unittest.cc

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c867d4b19754725acbf79d287a649adfcecf51cf

commit c867d4b19754725acbf79d287a649adfcecf51cf
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Mon Nov 27 21:12:38 2017

Make U2fResponse return a key handle.

GetAssertion (or public key 'get' requests) need to know which key
was successfully used by the responding authenticator in a sign request.

Bug:  664630 
Change-Id: I3c272e1f9465750ac4ff30dfb77c18ca4245dee5
Reviewed-on: https://chromium-review.googlesource.com/711015
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519404}
[modify] https://crrev.com/c867d4b19754725acbf79d287a649adfcecf51cf/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/c867d4b19754725acbf79d287a649adfcecf51cf/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/c867d4b19754725acbf79d287a649adfcecf51cf/device/u2f/u2f_register.cc
[modify] https://crrev.com/c867d4b19754725acbf79d287a649adfcecf51cf/device/u2f/u2f_register_unittest.cc
[modify] https://crrev.com/c867d4b19754725acbf79d287a649adfcecf51cf/device/u2f/u2f_request.h
[modify] https://crrev.com/c867d4b19754725acbf79d287a649adfcecf51cf/device/u2f/u2f_request_unittest.cc
[modify] https://crrev.com/c867d4b19754725acbf79d287a649adfcecf51cf/device/u2f/u2f_sign.cc
[modify] https://crrev.com/c867d4b19754725acbf79d287a649adfcecf51cf/device/u2f/u2f_sign_unittest.cc

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6549c813cfbb49316bf6fa77b15c96e3747e4b03

commit 6549c813cfbb49316bf6fa77b15c96e3747e4b03
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Tue Nov 28 22:36:17 2017

Migrate existing WebAuthN components to WD07.

Correctly return TypeErrors instead of DomExceptions for 
missing Rp & User Entity elements.

Bug:  664630 
Change-Id: I464a3d2555f2599299238768a8ef59e8b32cb7f6
Reviewed-on: https://chromium-review.googlesource.com/741863
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519871}
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/chrome/browser/password_manager/credential_manager_browsertest.cc
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/BUILD.gn
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/attestation_statement.h
[rename] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/attested_credential_data.cc
[rename] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/attested_credential_data.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/authenticator_data.cc
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/authenticator_data.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/authenticator_utils.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/collected_client_data.cc
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/collected_client_data.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/content/browser/webauth/register_response_data.cc
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/authenticator-helpers.js
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/LayoutTests/webauth/idl-expected.txt
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/LayoutTests/webauth/idl.html
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAssertionResponse.cpp
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAssertionResponse.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAssertionResponse.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAttestationResponse.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorResponse.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorSelectionCriteria.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/CollectedClientData.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/CredentialCreationOptions.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.cpp
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerClient.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[delete] https://crrev.com/41f6d9bb9df60f3e4b231dabe099a81a041e34f8/third_party/WebKit/Source/modules/credentialmanager/MakeCredentialOptions.idl
[add] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/MakePublicKeyCredentialOptions.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredential.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialDescriptor.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialEntity.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialParameters.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialRequestOptions.idl
[add] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialRpEntity.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialUserEntity.idl
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.cpp
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/credentialmanager/WebAuthenticationClient.h
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/6549c813cfbb49316bf6fa77b15c96e3747e4b03/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom

Project Member

Comment 33 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4eb6b2704f64f34590011dedf06367a0b369a43

commit b4eb6b2704f64f34590011dedf06367a0b369a43
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Mon Jan 08 19:18:18 2018

Parse the raw u2f sign response into a FIDO2 GetAssertion response.

Add fuzzer for SignResponseData and graceful handling to prevent
corrupted data from an authenticator from crashing the process.

Bug:  664630 
Change-Id: I309733391585fa44cf86da74238c85d469e26355
Reviewed-on: https://chromium-review.googlesource.com/831171
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527705}
[modify] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/BUILD.gn
[modify] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/authenticator_data.cc
[modify] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/authenticator_data.h
[modify] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/register_response_data.cc
[modify] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/register_response_data.h
[add] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/response_data.cc
[add] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/response_data.h
[add] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/response_data_fuzzer_corpus/sign0
[add] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/response_data_fuzzer_corpus/sign1
[add] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/sign_response_data.cc
[add] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/sign_response_data.h
[add] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/sign_response_data_fuzzer.cc
[modify] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/u2f_register.cc
[modify] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/u2f_register_unittest.cc
[modify] https://crrev.com/b4eb6b2704f64f34590011dedf06367a0b369a43/device/u2f/u2f_sign_unittest.cc

Project Member

Comment 34 by bugdroid1@chromium.org, Jan 9 2018

Project Member

Comment 35 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d87fb0d0069424e866825bd38d8b50fbac5a3d8

commit 9d87fb0d0069424e866825bd38d8b50fbac5a3d8
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Thu Jan 18 18:36:22 2018

Renderer-side implementation of navigator.credentials.get(public-key).

Call TrySign() from content, process, and surface response to blink.

Add necessary typeconverters and related mojo structs to authenticator.mojom.

Sans appId support.

Bug:  664630 
Change-Id: I01736ab2fdf08cfc64e421bff102a6c5f485a54e
Reviewed-on: https://chromium-review.googlesource.com/853435
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530208}
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/components/password_manager/content/common/credential_manager_struct_traits.cc
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-origins.html
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/credential-helpers.js
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.h
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/public/platform/modules/credentialmanager/credential_manager.mojom
[modify] https://crrev.com/9d87fb0d0069424e866825bd38d8b50fbac5a3d8/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom

Project Member

Comment 36 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94331812efdf403f90a63039346ae7ac57233b68

commit 94331812efdf403f90a63039346ae7ac57233b68
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Thu Jan 18 21:17:32 2018

Call the device/u2f sign operation and process the response.

Bug:  664630 
Change-Id: Ic78e5ef9964505eb6c28a26ed771398791190fa0
Reviewed-on: https://chromium-review.googlesource.com/861644
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530273}
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/content/browser/webauth/collected_client_data.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/content/browser/webauth/collected_client_data.h
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/mock_u2f_device.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/mock_u2f_device.h
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_register.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_register.h
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_register_unittest.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_request.h
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_request_unittest.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_response_test_data.h
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_sign.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_sign.h
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/device/u2f/u2f_sign_unittest.cc
[modify] https://crrev.com/94331812efdf403f90a63039346ae7ac57233b68/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom

Project Member

Comment 37 by bugdroid1@chromium.org, Jan 18 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/33f87b1dd6b4d73f98dc83e4ba86eb8b1880745e

commit 33f87b1dd6b4d73f98dc83e4ba86eb8b1880745e
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Thu Jan 18 22:00:42 2018

WebAuthentication: Add chrome://flags#enable-webauthentication.

This patch adds a flag to enable support for PublicKeyCredentials in
CredentialManager.

Bug:  664630 
Change-Id: Icbdfc6318dd1d3bce65136e826f2bb1f4da1c04e
Reviewed-on: https://chromium-review.googlesource.com/873390
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530287}
[modify] https://crrev.com/33f87b1dd6b4d73f98dc83e4ba86eb8b1880745e/chrome/browser/about_flags.cc
[modify] https://crrev.com/33f87b1dd6b4d73f98dc83e4ba86eb8b1880745e/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/33f87b1dd6b4d73f98dc83e4ba86eb8b1880745e/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/33f87b1dd6b4d73f98dc83e4ba86eb8b1880745e/tools/metrics/histograms/enums.xml

It's a bird...? It's a plane...? It's a milestone! Superb work, Kim, thank you!
Project Member

Comment 39 by bugdroid1@chromium.org, Jan 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83a16a8fccf339ec16f9a4ab61069c6f7cf0a929

commit 83a16a8fccf339ec16f9a4ab61069c6f7cf0a929
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Fri Jan 19 11:27:37 2018

Implement some more updates in the WebAuthN spec WD07 updates.

 -- Remove hashAlgorithm from CollectedClientData (SHA-256 is hardcoded).
 -- Make userhandle optional in AuthenticatorAssertionResponse.
 -- Rename Attachment to AuthenticatorAttachment.

Bug:  664630 
Change-Id: Id4e8d86eb581bfdd556618c17bdab877670556a2
Reviewed-on: https://chromium-review.googlesource.com/873993
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#530484}
[modify] https://crrev.com/83a16a8fccf339ec16f9a4ab61069c6f7cf0a929/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/83a16a8fccf339ec16f9a4ab61069c6f7cf0a929/content/browser/webauth/collected_client_data.cc
[modify] https://crrev.com/83a16a8fccf339ec16f9a4ab61069c6f7cf0a929/content/browser/webauth/collected_client_data.h
[modify] https://crrev.com/83a16a8fccf339ec16f9a4ab61069c6f7cf0a929/third_party/WebKit/LayoutTests/webauth/idl.html
[modify] https://crrev.com/83a16a8fccf339ec16f9a4ab61069c6f7cf0a929/third_party/WebKit/Source/modules/credentialmanager/AuthenticatorAssertionResponse.idl
[modify] https://crrev.com/83a16a8fccf339ec16f9a4ab61069c6f7cf0a929/third_party/WebKit/Source/modules/credentialmanager/CollectedClientData.idl

Thanks, Balazs! Couldn't have been done without your and Jan's excellent reviewing.
Blockedon: 806429
Project Member

Comment 42 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35657d55a0204aaaf092dfe11f2b95032c5b062d

commit 35657d55a0204aaaf092dfe11f2b95032c5b062d
Author: Jan Wilken Dörrie <jdoerrie@chromium.org>
Date: Wed Jan 31 21:48:34 2018

[webauthn] Enable usage of BLE Security Keys

This change enables the usage of U2F BLE security keys for the Web
Authentication API. It introduces a new enum representing supported
U2F transport protocols and changes U2fRequest to own the device
discoveries.

Bug:  664630 , 763303

Change-Id: Ic2ba03f8bb2e9e097501fe453627c85796d39434
Reviewed-on: https://chromium-review.googlesource.com/887482
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533424}
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/BUILD.gn
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_register.cc
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_register.h
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_register_unittest.cc
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_request.cc
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_request.h
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_request_unittest.cc
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_sign.cc
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_sign.h
[modify] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_sign_unittest.cc
[add] https://crrev.com/35657d55a0204aaaf092dfe11f2b95032c5b062d/device/u2f/u2f_transport_protocol.h

Project Member

Comment 43 by bugdroid1@chromium.org, Feb 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf3e96da896ecf7715f85d5c71283f4ab53db112

commit cf3e96da896ecf7715f85d5c71283f4ab53db112
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Fri Feb 09 16:34:51 2018

[webauthn] Remove webauthn/idl.html in favor of existing WPTs.

Bug:  664630 
Change-Id: Iee24c805527fa5b41cde44547666d1ffa0fb167c
Reviewed-on: https://chromium-review.googlesource.com/910117
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535733}
[delete] https://crrev.com/edfc54c66d22c01487c6f70077caed6a3f865c8d/third_party/WebKit/LayoutTests/webauth/idl-expected.txt
[delete] https://crrev.com/edfc54c66d22c01487c6f70077caed6a3f865c8d/third_party/WebKit/LayoutTests/webauth/idl.html

Project Member

Comment 44 by bugdroid1@chromium.org, Feb 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31998d262da2cd43cfe0fad90a8cd9232902ed2c

commit 31998d262da2cd43cfe0fad90a8cd9232902ed2c
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Sat Feb 10 22:28:48 2018

[webauthn] Rename MakePublicKeyCredentialOptions to PublicKeyCredentialCreationOptions

Bug:  664630 
Change-Id: Ie7fb418978c6d7194f071ead353084cc59ffb677
Reviewed-on: https://chromium-review.googlesource.com/912204
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535988}
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/content/browser/webauth/authenticator_impl.cc
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/content/browser/webauth/authenticator_impl.h
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/content/browser/webauth/authenticator_impl_unittest.cc
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/third_party/WebKit/Source/modules/credentialmanager/CredentialCreationOptions.idl
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.h
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
[rename] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/third_party/WebKit/Source/modules/credentialmanager/PublicKeyCredentialCreationOptions.idl
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/31998d262da2cd43cfe0fad90a8cd9232902ed2c/third_party/WebKit/public/platform/modules/webauth/authenticator.mojom

Project Member

Comment 45 by bugdroid1@chromium.org, Feb 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18

commit d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Mon Feb 19 07:33:44 2018

Check publickey security requirements for calls to get(publicKey)
and handle empty or missing rpIds.

Add layout tests for various combinations of origins and rpId to
get(publicKey) just like the existing ones for create(publicKey).

Bug:  807774 ,  664630 
Change-Id: I86d3d36c3f3825743f003da69245c74bdca10d5b
Reviewed-on: https://chromium-review.googlesource.com/896384
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537594}
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[add] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame-expected.txt
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-origins.html
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[add] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame-expected.txt
[add] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame.html
[add] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-origins.html
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/credential-helpers.js
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/nested-mock-authenticator-client.html
[add] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/publickey-get-helper.html
[add] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/README.txt
[add] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame-expected.txt
[add] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame-expected.txt
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp
[modify] https://crrev.com/d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Project Member

Comment 46 by bugdroid1@chromium.org, Feb 23

Labels: merge-merged-3325
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3d96590291b371b643ee138dfe3b50a41cf2fde

commit e3d96590291b371b643ee138dfe3b50a41cf2fde
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Fri Feb 23 20:18:17 2018

Check publickey security requirements for calls to get(publicKey)
and handle empty or missing rpIds.

Add layout tests for various combinations of origins and rpId to
get(publicKey) just like the existing ones for create(publicKey).

Bug:  807774 ,  664630 
Change-Id: I86d3d36c3f3825743f003da69245c74bdca10d5b
Reviewed-on: https://chromium-review.googlesource.com/896384
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#537594}(cherry picked from commit d1eeb248ea7f29e21901ad3ee3e5b7abcd0d6c18)
Reviewed-on: https://chromium-review.googlesource.com/935223
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#578}
Cr-Branched-From: bc084a8b5afa3744a74927344e304c02ae54189f-refs/heads/master@{#530369}
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[add] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame-expected.txt
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame.html
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-origins.html
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[add] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame-expected.txt
[add] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame.html
[add] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-origins.html
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/credential-helpers.js
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/nested-mock-authenticator-client.html
[add] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/publickey-get-helper.html
[add] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/README.txt
[add] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/credentialscontainer-create-from-nested-frame-expected.txt
[add] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/credentialscontainer-get-from-nested-frame-expected.txt
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/Source/modules/credentialmanager/CredentialManagerTypeConverters.cpp
[modify] https://crrev.com/e3d96590291b371b643ee138dfe3b50a41cf2fde/third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp

Project Member

Comment 47 by bugdroid1@chromium.org, Mar 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd63e9e08e75abee4e880eadb78fc6a7d0c545dd

commit cd63e9e08e75abee4e880eadb78fc6a7d0c545dd
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Tue Mar 13 09:55:23 2018

[WebAuthn] Refactor layout tests to reduce code.

Instead of custom building each set of options per test,
deep copy the options and remove select properties. Both reduces
code and makes it more clear what is being tested.

Also adds a helper to set up a successful response from the
mock authenticator.

Bug:  664630 
Change-Id: If5986e21b56e1093835866283f0e69134f265390
Reviewed-on: https://chromium-review.googlesource.com/957831
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#542753}
[modify] https://crrev.com/cd63e9e08e75abee4e880eadb78fc6a7d0c545dd/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-create-basics.html
[modify] https://crrev.com/cd63e9e08e75abee4e880eadb78fc6a7d0c545dd/third_party/WebKit/LayoutTests/http/tests/credentialmanager/credentialscontainer-get-basics.html
[modify] https://crrev.com/cd63e9e08e75abee4e880eadb78fc6a7d0c545dd/third_party/WebKit/LayoutTests/http/tests/credentialmanager/resources/credential-helpers.js

Blockedon: 821766
Labels: -M-60 M-67
Project Member

Comment 51 by bugdroid1@chromium.org, Mar 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d2201138e220a2340dcf2911c9c192e10f12766

commit 7d2201138e220a2340dcf2911c9c192e10f12766
Author: Kim Paulhamus <kpaulhamus@chromium.org>
Date: Sat Mar 31 03:46:37 2018

[Webauthn] Enable the Web Authentication API by default on desktop platforms.
TBR=darin@chromium.org

Intent to ship thread:
https://groups.google.com/a/chromium.org/forum/#!searchin/blink-dev/intent$20ship$20web$20authentication$20api$20/blink-dev/o9RU6Vv0xeM/EGnQOExbAAAJ

Bug:  664630 
Change-Id: I617cec25080b4ec9df929b81494c82e04212047d
Reviewed-on: https://chromium-review.googlesource.com/977031
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547371}
[modify] https://crrev.com/7d2201138e220a2340dcf2911c9c192e10f12766/content/child/runtime_features.cc
[modify] https://crrev.com/7d2201138e220a2340dcf2911c9c192e10f12766/content/public/common/content_features.cc
[modify] https://crrev.com/7d2201138e220a2340dcf2911c9c192e10f12766/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/7d2201138e220a2340dcf2911c9c192e10f12766/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/7d2201138e220a2340dcf2911c9c192e10f12766/third_party/WebKit/LayoutTests/external/wpt/webauthn/createcredential-timeout.https-expected.txt
[modify] https://crrev.com/7d2201138e220a2340dcf2911c9c192e10f12766/third_party/WebKit/LayoutTests/external/wpt/webauthn/getcredential-timeout.https-expected.txt
[delete] https://crrev.com/0e850c3f09ee29b3322f099e3f7a94f5de0e2847/third_party/WebKit/LayoutTests/virtual/enable-webauthn/http/tests/credentialmanager/README.txt
[modify] https://crrev.com/7d2201138e220a2340dcf2911c9c192e10f12766/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt

Cc: juanlang@chromium.org arnarb@chromium.org r...@chromium.org dmitrygr@google.com jleong@chromium.org
 Issue 649021  has been merged into this issue.
Status: Fixed (was: Assigned)
Closing this bug following initial launch. Newer bugs are tracking additional features.

Sign in to add a comment