New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664628 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mojo: we need a thread safe interface pointer

Project Member Reported by jcivelli@chromium.org, Nov 11 2016

Issue description

As part of the work to replace IPC messages with Mojo call, we need an interface pointer that supports getting calls from different threads to perform the task that content::ThreadSafeSender is doing in existing code.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64c7ea9ccda1354968015f4979135760627435e1

commit 64c7ea9ccda1354968015f4979135760627435e1
Author: jcivelli <jcivelli@chromium.org>
Date: Wed Nov 16 06:23:28 2016

Creating a thread safe interface pointer that is tied to an actual
InterfacePtr and forwards message from interface calls to the
InterfacePtr thread and forwards back response messages to the
calling thread.

BUG= 664628 
TEST=InterfacePtrTest.TestThreadSafeInterfacePointer

Review-Url: https://codereview.chromium.org/2498743002
Cr-Commit-Position: refs/heads/master@{#432387}

[modify] https://crrev.com/64c7ea9ccda1354968015f4979135760627435e1/mojo/public/cpp/bindings/lib/associated_interface_ptr_state.h
[modify] https://crrev.com/64c7ea9ccda1354968015f4979135760627435e1/mojo/public/cpp/bindings/lib/interface_ptr_state.h
[modify] https://crrev.com/64c7ea9ccda1354968015f4979135760627435e1/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
[add] https://crrev.com/64c7ea9ccda1354968015f4979135760627435e1/mojo/public/cpp/bindings/thread_safe_interface_ptr.h
[modify] https://crrev.com/64c7ea9ccda1354968015f4979135760627435e1/mojo/public/tools/bindings/generators/cpp_templates/interface_definition.tmpl
[modify] https://crrev.com/64c7ea9ccda1354968015f4979135760627435e1/mojo/public/tools/bindings/generators/cpp_templates/interface_proxy_declaration.tmpl
[modify] https://crrev.com/64c7ea9ccda1354968015f4979135760627435e1/mojo/public/tools/bindings/generators/cpp_templates/module.h.tmpl

Status: Fixed (was: Untriaged)

Sign in to add a comment