New issue
Advanced search Search tips

Issue 664621 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 659155



Sign in to add a comment

Update services/ui/ws/window_manager_client_unittest to use aura-mus

Project Member Reported by sky@chromium.org, Nov 11 2016

Issue description

This test uses WindowServerTestBase, which should go away.

 

Comment 1 by sky@chromium.org, Dec 8 2016

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/247a606263c48168e56020f845df0b3c41857e14

commit 247a606263c48168e56020f845df0b3c41857e14
Author: sky <sky@chromium.org>
Date: Thu Dec 08 16:45:14 2016

Converts WindowTreeClientTest to be in terms of aura

Only real interesting change is
WindowTreeClient::OnWindowDeleted(). If a root is deleted this now
calls to the delegate to handle deletion. This is necessary as
generally the Window shouldn't be deleted directly, rather the
WindowTreeHostMus which owns the window.

I also changed Embed() to fail immediately if the window has children. The
server has logic to force removal, but I think we should treat it as
an error in client code if they try to embed and there are children.

BUG= 664621 
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2559703003
Cr-Commit-Position: refs/heads/master@{#437264}

[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ash/mus/BUILD.gn
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ash/mus/window_manager.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ash/mus/window_manager.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ash/mus/window_manager_unittest.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/mash/simple_wm/simple_wm.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/demo/mus_demo.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/public/cpp/tests/BUILD.gn
[delete] https://crrev.com/ca80f908b7fad35ce88c59047d0417c9d310db54/services/ui/public/cpp/tests/window_server_test_base.cc
[delete] https://crrev.com/ca80f908b7fad35ce88c59047d0417c9d310db54/services/ui/public/cpp/tests/window_server_test_base.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/ws/BUILD.gn
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/ws/window_manager_client_unittest.cc
[rename] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/ws/window_server_service_test_base.cc
[rename] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/ws/window_server_service_test_base.h
[add] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/ws/window_server_test_base.cc
[add] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/ws/window_server_test_base.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/mus/window_mus.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/mus/window_port_mus.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/mus/window_port_mus.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/mus/window_tree_client_delegate.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/test/aura_test_base.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/test/mus/window_tree_client_private.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/aura/test/mus/window_tree_client_private.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/views/mus/desktop_window_tree_host_mus.h
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/views/mus/mus_client.cc
[modify] https://crrev.com/247a606263c48168e56020f845df0b3c41857e14/ui/views/mus/mus_client.h

Comment 3 by sky@chromium.org, Dec 8 2016

Status: Fixed (was: Started)

Comment 4 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 5 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 6 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 7 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 8 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService

Sign in to add a comment