New issue
Advanced search Search tips

Issue 664607 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

PreCQ behaves badly if dependent CLs are updated.

Project Member Reported by dgarr...@chromium.org, Nov 11 2016

Issue description

This CL:

https://chromium-review.googlesource.com/#/c/399583/

Depends on these two CLs:

https://chrome-internal-review.googlesource.com/#/c/297397/
https://chrome-internal-review.googlesource.com/#/c/302515/

All three were in the PreCQ as a unit, when the dependent CLs were chumped.

The PreCQ run was canceled (correctly).

However, looking only at the first CL, every PreCQ run appeared to fail with messages like:

The mixed-c-pre-cq trybot for your change timed out after 240 minutes.
This problem can happen if your change causes the builder to hang, or if there is some infrastructure issue. If your change is not at fault you may mark your change as ready again. If this problem occurs multiple times please notify the sheriff and file a bug.

Also, it was treated as a bad PreCQ run, and flags were cleared so that it wouldn't be tested again.

I think that we should have cancelled the run, but not messaged the first CL in a way that looks like an error in our system, and should have retried the first CL without having to re-set the flags manually.
 
Fixing this will make our system easier to understand and work with, but it only affects a semi-rare case. So, it's not urgent, but nice to have. Pri-2 seems correct.

Comment 2 Deleted

Comment 3 by autumn@chromium.org, Nov 16 2016

Labels: -current-issue Hotlist-Fixit
Project Member

Comment 4 by sheriffbot@chromium.org, Nov 16 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Components: -Infra>Client>ChromeOS Infra>Client>ChromeOS>Build

Comment 6 by nxia@chromium.org, Jun 8 2018

Cc: -nxia@chromium.org
Status: Available (was: Untriaged)

Sign in to add a comment