New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664604 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Android][Client] MultiWindowMode is not always applied correctly

Project Member Reported by joedow@chromium.org, Nov 11 2016

Issue description

This problem manifests in two ways:
1.) Toolbar never hides in fullscreen mode
2.) status bar disappears in multi-window mode

This problem is occurring because the underlying, synchronous API to request the current mode is not guaranteed to be correct.  Instead you need to override a method which receives the new value.  My initial change used the synchronous API and was use late enough in the activity lifecycle that it appeared to be accurate but I have seen a few instances of the problems listed above and want to solve this reliably, even though more complexity will be required.
 

Comment 1 by joedow@chromium.org, Nov 14 2016

Status: Started (was: Assigned)

Comment 2 by joedow@chromium.org, Nov 15 2016

Owner: ajnolley@chromium.org
Status: Fixed (was: Started)

Comment 3 by joedow@chromium.org, Nov 15 2016

Change was checked in a few hours ago but bug hasn't been updated yet, I'm assuming it will be at some point :)
Status: Verified (was: Fixed)
Chrome downloads will typically build binaries around 1030 pm, so any changes will be verified the next day at the earliest. I checked this in version 56.0.2920.0 and behavior in general seems good. A minor thing is that when flipping the screen or expanding/reducing dual screen mode area, the mouse will change position slightly on the client. It moves a bit in one of the four cardinal directions, depending on which way its flipped or expanded/reduced. 

Comment 5 by joedow@chromium.org, Nov 16 2016

Is the mouse cursor moved such that it is placed in the middle of the viewport on the client or is it less deterministic?

I think the former behavior is by design unless we implement a saved state mechanism, the latter might be another bug to look into.
the movement is fairly minimal, such that if the cursor is slightly left of center, it will be moved slightly right of center afterwards. It consistently remains largely in the middle. I suspected this was expected given the current expectations. 

Sign in to add a comment