Run linux_chromium_chromeos_ozone_rel_ng tests with Ozone X11 |
||||||||
Issue descriptionThe tests on linux_chromium_chromeos_ozone_rel_ng use Ozone headless when running. It would be beneficial if some/all tests would run under Ozone X11 instead. Right now it's possible to commit code that breaks running Ozone X11 and CQ will not catch the problem.
,
Nov 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7895a178293de777611dd91255b9b90934f1a5df commit 7895a178293de777611dd91255b9b90934f1a5df Author: kylechar <kylechar@chromium.org> Date: Tue Nov 15 00:55:56 2016 Run gl_unittests with Ozone X11. Add a new test target gl_unittests_ozonex that runs with --ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with both Ozone headless and Ozone X11. The test requires an X server to be running on the bot. The mb.py script is modified to look for GN arg use_ozone=true and runtime flag --ozone-platform=x11. In this case, it runs the test using xvfb. BUG= 664570 Review-Url: https://codereview.chromium.org/2493063003 Cr-Commit-Position: refs/heads/master@{#432038} [modify] https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df/BUILD.gn [modify] https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df/tools/mb/mb.py [modify] https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df/ui/gl/BUILD.gn
,
Nov 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2939f78b519bc6cd0909a9615a666205ad6aecc2 commit 2939f78b519bc6cd0909a9615a666205ad6aecc2 Author: tandrii <tandrii@chromium.org> Date: Wed Nov 16 16:33:31 2016 Revert of Run gl_unittests with Ozone X11. (patchset #3 id:40001 of https://codereview.chromium.org/2493063003/ ) Reason for revert: Likely caused error in isolate steps in http://crbug.com/665895 : /b/c/b/linux_chromeos/src/out/Release/xdisplaycheck: no such file or directory Original issue's description: > Run gl_unittests with Ozone X11. > > Add a new test target gl_unittests_ozonex that runs with > --ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with > both Ozone headless and Ozone X11. > > The test requires an X server to be running on the bot. The mb.py script > is modified to look for GN arg use_ozone=true and runtime flag > --ozone-platform=x11. In this case, it runs the test using xvfb. > > BUG= 664570 > > Committed: https://crrev.com/7895a178293de777611dd91255b9b90934f1a5df > Cr-Commit-Position: refs/heads/master@{#432038} TBR=dpranke@chromium.org,sadrul@chromium.org,kylechar@chromium.org # tandrii@ decided it's enough waiting for tests. # so not (Not skipping CQ checks because original CL landed more than 1 days ago.) NOTRY=True BUG= 664570 , 665895 Review-Url: https://codereview.chromium.org/2506013002 Cr-Commit-Position: refs/heads/master@{#432513} [modify] https://crrev.com/2939f78b519bc6cd0909a9615a666205ad6aecc2/BUILD.gn [modify] https://crrev.com/2939f78b519bc6cd0909a9615a666205ad6aecc2/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/2939f78b519bc6cd0909a9615a666205ad6aecc2/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/2939f78b519bc6cd0909a9615a666205ad6aecc2/tools/mb/mb.py [modify] https://crrev.com/2939f78b519bc6cd0909a9615a666205ad6aecc2/ui/gl/BUILD.gn
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/50abf5a8708a126e65c1d709b2488ef5080b19d7 commit 50abf5a8708a126e65c1d709b2488ef5080b19d7 Author: kylechar <kylechar@chromium.org> Date: Tue Nov 29 16:03:07 2016 Reland: Run gl_unittests with Ozone X11. Add a new test target gl_unittests_ozonex that runs with --ozone-platform=x11. The Ozone CrOS bot will now run gl_unittests with both Ozone headless and Ozone X11. The test requires an X server to be running on the bot. The mb.py script is modified to look for GN arg use_ozone=true and runtime flag --ozone-platform=x11. In this case, it runs the test using xvfb. Original commit crrev.com/2493063003 was reverted due to crbug.com/665895 . There was no dependency on xdisplaycheck by the new test target that needs it. This caused problems during the isolate step when xdisplaycheck wasn't found. BUG= 664570 Review-Url: https://codereview.chromium.org/2509033006 Cr-Commit-Position: refs/heads/master@{#435000} [modify] https://crrev.com/50abf5a8708a126e65c1d709b2488ef5080b19d7/BUILD.gn [modify] https://crrev.com/50abf5a8708a126e65c1d709b2488ef5080b19d7/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/50abf5a8708a126e65c1d709b2488ef5080b19d7/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/50abf5a8708a126e65c1d709b2488ef5080b19d7/tools/mb/mb.py [modify] https://crrev.com/50abf5a8708a126e65c1d709b2488ef5080b19d7/ui/gl/BUILD.gn
,
Dec 17 2016
,
Jan 25 2017
,
Jan 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63f513b1f5def735183564edcdd2558411fdb5f9 commit 63f513b1f5def735183564edcdd2558411fdb5f9 Author: kylechar <kylechar@chromium.org> Date: Wed Jan 25 21:20:59 2017 Run more CrOS Ozone tests with Ozone X11. Switch a number of test targets to run with Ozone X11 instead of Ozone Headless. These are some of the obvious working candidates I found, although there might be other test targets that work. BUG= 664570 Review-Url: https://codereview.chromium.org/2542193002 Cr-Commit-Position: refs/heads/master@{#446122} [modify] https://crrev.com/63f513b1f5def735183564edcdd2558411fdb5f9/testing/buildbot/chromium.chromiumos.json
,
Jan 27 2017
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/53b5ef0706d72a4822ec4317ff65c412f070ce0e commit 53b5ef0706d72a4822ec4317ff65c412f070ce0e Author: kylechar <kylechar@chromium.org> Date: Thu Feb 02 13:50:03 2017 Run Ozone CrOS tests with X11 platform by default. Add GN argument ozone_platform="x11" for Ozone CrOS trybots. This will cause tests to run with Ozone X11 instead of Ozone headless unless the Ozone platform is specified at runtime via command line flag. Most tests now pass with Ozone X11, so it's easier to add an extra argument for tests that don't pass. Newly added tests will run with Ozone X11 too. This change will affect the 'linux_chromium_chromeos_ozone_rel_ng' and 'Mojo Chromium' trybots. 'linux_chromium_chromeos_ozone_rel_ng' is the main Ozone CrOS trybot that runs as part of CQ. 'Mojo ChromiumOS' is an FYI bot that is basically a subset of the CQ trybot. Technically this also affects 'Linux ChromiumOS Ozone Builder' but that trybot doesn't run any tests. BUG= 664570 Review-Url: https://codereview.chromium.org/2668033003 Cr-Commit-Position: refs/heads/master@{#447757} [modify] https://crrev.com/53b5ef0706d72a4822ec4317ff65c412f070ce0e/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/53b5ef0706d72a4822ec4317ff65c412f070ce0e/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/53b5ef0706d72a4822ec4317ff65c412f070ce0e/tools/mb/mb_config.pyl
,
Feb 2 2017
The only tests that aren't running with Ozone X11 are now: ash_unittests gpu_ipc_service_unittests gpu_unittests mash_browser_tests mus_ws_unittests ozone_gl_unittests unit_tests
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0166803afdf454945171969526a023cb304bb295 commit 0166803afdf454945171969526a023cb304bb295 Author: kylechar <kylechar@chromium.org> Date: Fri Feb 03 19:35:12 2017 Get mus_ws_unittests working with Ozone X11. WindowServerTests need a TYPE_UI message loop to work with libevent for Ozone X11. Luckily, there is already a virtual function in ServiceTest to create a MessageLoop. Other Changes: - Switch mus_ws_unittests to run with Ozone X11 - Add media_service_unittests to CQ trybot instead of FYI trybot. - Delete tests from FYI trybot that run on CQ trybot. BUG= 664570 Review-Url: https://codereview.chromium.org/2661163006 Cr-Commit-Position: refs/heads/master@{#448049} [modify] https://crrev.com/0166803afdf454945171969526a023cb304bb295/services/ui/ws/window_manager_client_unittest.cc [modify] https://crrev.com/0166803afdf454945171969526a023cb304bb295/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/0166803afdf454945171969526a023cb304bb295/testing/buildbot/chromium.fyi.json
,
Feb 3 2017
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824 commit 18eef539260cdf6ca1f5dbfbb0a44cbf836a5824 Author: kylechar <kylechar@chromium.org> Date: Tue Feb 07 19:48:54 2017 Switch mash_browser_tests to Ozone X11 platform. Run with mash_browser_tests with Ozone X11 platform instead of Ozone headless. Move most of the test arguments into the gn_isolate_map.pyl file so they don't have to be repeated. Also add a proper dependency on mash_service_overrides.json so that isolate knows the file is required for mash_browser_tests. BUG= 664570 Review-Url: https://codereview.chromium.org/2675443002 Cr-Commit-Position: refs/heads/master@{#448703} [modify] https://crrev.com/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824/chrome/app/mash/BUILD.gn [modify] https://crrev.com/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824/chrome/test/BUILD.gn [modify] https://crrev.com/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824/testing/buildbot/gn_isolate_map.pyl
,
Feb 7 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc72782d44b71f6a1d8b38f264c9119dcb6cea65 commit fc72782d44b71f6a1d8b38f264c9119dcb6cea65 Author: jam <jam@chromium.org> Date: Tue Feb 07 21:16:21 2017 Revert of Switch mash_browser_tests to Ozone X11 platform. (patchset #10 id:210001 of https://codereview.chromium.org/2675443002/ ) Reason for revert: Looks like the only culprit that caused win bots to fail compile, i.e. https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium%2FWin%2F51649%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original issue's description: > Switch mash_browser_tests to Ozone X11 platform. > > Run with mash_browser_tests with Ozone X11 platform instead of Ozone > headless. Move most of the test arguments into the gn_isolate_map.pyl > file so they don't have to be repeated. Also add a proper dependency on > mash_service_overrides.json so that isolate knows the file is required > for mash_browser_tests. > > BUG= 664570 > > Review-Url: https://codereview.chromium.org/2675443002 > Cr-Commit-Position: refs/heads/master@{#448703} > Committed: https://chromium.googlesource.com/chromium/src/+/18eef539260cdf6ca1f5dbfbb0a44cbf836a5824 TBR=sky@chromium.org,kylechar@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 664570 Review-Url: https://codereview.chromium.org/2683633003 Cr-Commit-Position: refs/heads/master@{#448728} [modify] https://crrev.com/fc72782d44b71f6a1d8b38f264c9119dcb6cea65/chrome/app/mash/BUILD.gn [modify] https://crrev.com/fc72782d44b71f6a1d8b38f264c9119dcb6cea65/chrome/test/BUILD.gn [modify] https://crrev.com/fc72782d44b71f6a1d8b38f264c9119dcb6cea65/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/fc72782d44b71f6a1d8b38f264c9119dcb6cea65/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/fc72782d44b71f6a1d8b38f264c9119dcb6cea65/testing/buildbot/gn_isolate_map.pyl
,
Feb 9 2017
,
Feb 9 2017
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/309364b3ec8f63807d91ce0eb1985df300155c1a commit 309364b3ec8f63807d91ce0eb1985df300155c1a Author: kylechar <kylechar@chromium.org> Date: Fri Feb 10 18:51:30 2017 Switch mash_browser_tests to Ozone X11 platform. Run with mash_browser_tests with Ozone X11 platform instead of Ozone headless. Move most of the test arguments into the gn_isolate_map.pyl file so they don't have to be repeated. Also add a proper dependency on mash_service_overrides.json so that isolate knows the file is required for mash_browser_tests. Original review in http://crrev.com/2675443002 was reverted due to breaking the Windows waterfall bots. The waterfall trybots build target all but CQ trybots do not. GN learns about //chrome/app/mash and tries to build all targets in it. Those targets are not suitable for Windows currently. Guard the compilation of mash_browser_tests and //chrome/app/mash related code on GN arg enable_package_mash_services. The inclusion of //chrome/app/mash already happens based on enable_package_mash_services anyways. Remove mash_browser_tests from 'Mojo Windows' trybot as the mash part of browser_tests isn't compiled anyways. BUG= 664570 Review-Url: https://codereview.chromium.org/2680283003 Cr-Commit-Position: refs/heads/master@{#449673} [modify] https://crrev.com/309364b3ec8f63807d91ce0eb1985df300155c1a/chrome/app/mash/BUILD.gn [modify] https://crrev.com/309364b3ec8f63807d91ce0eb1985df300155c1a/chrome/test/BUILD.gn [modify] https://crrev.com/309364b3ec8f63807d91ce0eb1985df300155c1a/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/309364b3ec8f63807d91ce0eb1985df300155c1a/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/309364b3ec8f63807d91ce0eb1985df300155c1a/testing/buildbot/gn_isolate_map.pyl
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59d468305aab2c224ab5bd34a3415869a3e78351 commit 59d468305aab2c224ab5bd34a3415869a3e78351 Author: fwang <fwang@igalia.com> Date: Mon Feb 13 15:22:57 2017 Ozone Linux: Disable some mash tests causing configuration errors After [1], new ChromeOS-specific files are built when enable_package_mash_services=1. This is the case for Ozone Linux and it caused the following error to happen on the build bot: ERROR at //ash/mus/BUILD.gn:11:1: Assertion failed. assert(is_chromeos) ^----- See //services/service_manager/public/service_manifest.gni:136:19: which caused the file to be included. deps += [ manifest_target ] ^-------------- This CL disables corresponding conditionals of [1] when is_chromeos=0 so that Ozone Linux builds again. [1] https://codereview.chromium.org/2680283003/ BUG= 664570 Review-Url: https://codereview.chromium.org/2694683002 Cr-Commit-Position: refs/heads/master@{#449961} [modify] https://crrev.com/59d468305aab2c224ab5bd34a3415869a3e78351/chrome/test/BUILD.gn
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0454d552d477db039a8e4b4ae923c87887c02dd commit d0454d552d477db039a8e4b4ae923c87887c02dd Author: kylechar <kylechar@chromium.org> Date: Mon Mar 06 21:25:17 2017 Don't exit SetBounds early for X11Window. If X11WindowBase::SetBounds() exits early when the bounds haven't changed this breaks changing the device scale factor. Use the same logic as WindowTreeHostX11. We check if anything has changed in origin/bounds before calling XConfigureNotify. WindowTreeHostPlatform does it's own checks afterwards to notify observers. BUG= 664570 Review-Url: https://codereview.chromium.org/2725383002 Cr-Commit-Position: refs/heads/master@{#454960} [modify] https://crrev.com/d0454d552d477db039a8e4b4ae923c87887c02dd/ui/platform_window/x11/x11_window_base.cc
,
Mar 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1fc7c670580371210623e35e09301eda28e656af commit 1fc7c670580371210623e35e09301eda28e656af Author: kylechar <kylechar@chromium.org> Date: Thu Mar 09 18:16:50 2017 Fix AshWindowTreeHost shutdown for Ozone X11. AshWindowTreeHostX11 stops receiving XEvents when PrepareForShutdown() is called to ensure it doesn't get any configuration events after Ash starts tearing down the RootWindowController. Things like the window size changing after teardown has started ends up crashing Ash. We need to do something similar, in a platform independent way for Ozone, when using the Ozone X11 platform. Add PlatformWindow::PrepareForShutdown() and call it from AshWindowTreeHostPlatform::PrepareForShutdown(). BUG= 664570 Review-Url: https://codereview.chromium.org/2741533002 Cr-Commit-Position: refs/heads/master@{#455794} [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ash/host/ash_window_tree_host_platform.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/ozone/platform/cast/platform_window_cast.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/ozone/platform/drm/host/drm_window_host.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/ozone/platform/drm/host/drm_window_host.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/ozone/platform/headless/headless_window.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/ozone/platform/headless/headless_window.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/ozone/platform/wayland/wayland_window.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/ozone/platform/wayland/wayland_window.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/ozone/platform/x11/ozone_platform_x11.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/android/platform_window_android.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/android/platform_window_android.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/platform_window.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/stub/stub_window.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/stub/stub_window.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/win/win_window.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/win/win_window.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/x11/x11_window.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/x11/x11_window.h [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/x11/x11_window_ozone.cc [modify] https://crrev.com/1fc7c670580371210623e35e09301eda28e656af/ui/platform_window/x11/x11_window_ozone.h
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54ec52855c6e4f37012e502d3eedf9a022334f94 commit 54ec52855c6e4f37012e502d3eedf9a022334f94 Author: kylechar <kylechar@chromium.org> Date: Fri Mar 17 00:01:13 2017 Add Ozone X11 tests to FYI trybot. These tests run with Ozone headless on CQ trybot. Make sure they aren't flaky with Ozone X11 on FYI trybot before changing the CQ trybot. BUG= 664570 Review-Url: https://codereview.chromium.org/2752273004 Cr-Commit-Position: refs/heads/master@{#457614} [modify] https://crrev.com/54ec52855c6e4f37012e502d3eedf9a022334f94/testing/buildbot/chromium.fyi.json
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0a9436e24a06867dfa1d466fedd493fa667e1b8b commit 0a9436e24a06867dfa1d466fedd493fa667e1b8b Author: kylechar <kylechar@chromium.org> Date: Fri Mar 17 18:22:38 2017 Switch three more tests to Ozone X11. These tests have run without any flakes on the FYI trybot for a couple hundred iterations now. Switch tests from Ozone headless to Ozone X11 on CQ trybot. Remove the tests from the FYI trybot too. BUG= 664570 Review-Url: https://codereview.chromium.org/2746363014 Cr-Commit-Position: refs/heads/master@{#457819} [modify] https://crrev.com/0a9436e24a06867dfa1d466fedd493fa667e1b8b/testing/buildbot/chromium.chromiumos.json [modify] https://crrev.com/0a9436e24a06867dfa1d466fedd493fa667e1b8b/testing/buildbot/chromium.fyi.json
,
Mar 24 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11d88d96ccf5f46266cddb5241528be6923f1f41 commit 11d88d96ccf5f46266cddb5241528be6923f1f41 Author: kylechar <kylechar@chromium.org> Date: Fri Mar 24 18:57:18 2017 Change Ozone X11 PlatformEventSource initialization. The GPU process PlatformEventSource is only there to listen for Expose XEvents. This isn't important for tests so we don't need to initialize the PlatfromEventSource in single process mode at all. BUG= 664570 Review-Url: https://codereview.chromium.org/2773503003 Cr-Commit-Position: refs/heads/master@{#459500} [modify] https://crrev.com/11d88d96ccf5f46266cddb5241528be6923f1f41/ui/ozone/platform/x11/ozone_platform_x11.cc
,
May 2 2017
Almost all tests run with Ozone X11 now, so I'll mark this fixed. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dpranke@chromium.org
, Nov 11 2016Labels: OS-Linux