Issue metadata
Sign in to add a comment
|
Regression: OSX Press-And-Hold accent menu broken in Chrome 55 (beta-channel). Works in 54 stable.
Reported by
mi...@mirdita.de,
Nov 11 2016
|
||||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.44 Safari/537.36 Steps to reproduce the problem: 1. Open https://crbug.com 2. Go to search box 3. Try long pressing the u keyboard key What is the expected behavior? Mac OS accent menu (Press-and-Hold/pressandhold.app) should appear, offering various accented characters for input. What went wrong? uuuuuuuuuuuuuuuuuuuuuuuu Key is repeated multiple times, instead of the accent menu being shown. Did this work before? Yes 54.0.2840.98 (stable - channel) Chrome version: 55.0.2883.44 Channel: beta OS Version: OS X 10.11.6 Flash Version: Shockwave Flash 23.0 r0 I downloaded the current release channel and cannot reproduce the issue there. Something happened in the last beta - channel release that broke the input method. Press-and-hold might have to be enabled first (defaults write -g ApplePressAndHoldEnabled -bool true)
,
Nov 11 2016
You are probably looking for a change made after 430109 (known good), but no later than 430124 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/ce7b196756d70afc2a98de8da644f78a1cfb6402..c9da801622a97bfa43a367741e6bf666e39e2b1e Maybe https://chromium.googlesource.com/chromium/src/+/7d85f23cb0235db06b0b6c2de1dc29ae5eaeb8f5 ?
,
Nov 11 2016
I've confirmed that reverting the CL in question fixes the problem.
,
Nov 11 2016
Removing the conditional:
"""
3020 - (NSRange)selectedRange {
3021 if (... selectedRange_.length == 0)
3022 return NSMakeRange(NSNotFound, 0);
"""
fixes the problem, but also re-introduces the memory leak. Needs more investigation.
,
Nov 11 2016
There are issues beyond just my CL. If I revert my CL, I can still hit a DCHECK: """ [24366:1295:1111/134707:FATAL:PlainTextRange.cpp(49)] Check failed: start >= 0 (-1 vs. 0) 0 libbase.dylib 0x000000010f46fdae _ZN4base5debug10StackTraceC2Ev + 30 1 libbase.dylib 0x000000010f46fe15 _ZN4base5debug10StackTraceC1Ev + 21 2 libbase.dylib 0x000000010f508d70 _ZN7logging10LogMessageD2Ev + 80 3 libbase.dylib 0x000000010f506925 _ZN7logging10LogMessageD1Ev + 21 4 libblink_core.dylib 0x0000000122d2f3e9 _ZN5blink14PlainTextRangeC2Eii + 217 5 libblink_core.dylib 0x0000000122d2f551 _ZN5blink14PlainTextRangeC1Eii + 33 6 libblink_web.dylib 0x000000012151987b _ZNK5blink17WebLocalFrameImpl26firstRectForCharacterRangeEjjRNS_7WebRectE + 235 7 libcontent.dylib 0x0000000116340eb9 _ZN7content23TextInputClientObserver28OnFirstRectForCharacterRangeEN3gfx5RangeE + 217 8 libcontent.dylib 0x0000000116341f53 _ZN4base20DispatchToMethodImplIPN7content23TextInputClientObserverEMS2_FvN3gfx5RangeEERKNSt3__15tupleIJS5_EEEJLm0EEEEvRKT_T0_OT1_NS_13IndexSequenceIJXspT2_EEEE + 179 9 libcontent.dylib 0x0000000116341e90 _ZN4base16DispatchToMethodIPN7content23TextInputClientObserverEMS2_FvN3gfx5RangeEERKNSt3__15tupleIJS5_EEEEEvRKT_T0_OT1_ + 96 10 libcontent.dylib 0x0000000116341e0d _ZN3IPC16DispatchToMethodIN7content23TextInputClientObserverEMS2_FvN3gfx5RangeEEvNSt3__15tupleIJS4_EEEEEvPT_T0_PT1_RKT2_ + 109 11 libcontent.dylib 0x0000000116340d72 _ZN3IPC8MessageTI50TextInputClientMsg_FirstRectForCharacterRange_MetaNSt3__15tupleIJN3gfx5RangeEEEEvE8DispatchIN7content23TextInputClientObserverESA_vMSA_FvS5_EEEbPKNS_7MessageEPT_PT0_PT1_T2_ + 482 12 libcontent.dylib 0x00000001163401b9 _ZN7content23TextInputClientObserver17OnMessageReceivedERKN3IPC7MessageE + 697 13 libcontent.dylib 0x0000000116282609 _ZN7content12RenderWidget17OnMessageReceivedERKN3IPC7MessageE + 153 14 libcontent.dylib 0x00000001162583aa _ZN7content14RenderViewImpl17OnMessageReceivedERKN3IPC7MessageE + 10458 15 libipc.dylib 0x00000001135e371b _ZN3IPC13MessageRouter12RouteMessageERKNS_7MessageE + 91 16 libcontent.dylib 0x00000001137a58a8 _ZN7content15ChildThreadImpl24ChildThreadMessageRouter12RouteMessageERKN3IPC7MessageE + 40 17 libipc.dylib 0x00000001135e369e _ZN3IPC13MessageRouter17OnMessageReceivedERKNS_7MessageE + 94 18 libcontent.dylib 0x00000001137b2e96 _ZN7content15ChildThreadImpl17OnMessageReceivedERKN3IPC7MessageE + 20 """ Repro steps: 1) compile with DCHECKs 2) in a text field, with chinese (simplified pinyin) IME, type: q 1 q The first "q 1" inserts a chinese character. The second q will hit the DCHECK.
,
Nov 11 2016
,
Nov 12 2016
Reverting: https://codereview.chromium.org/2497073002/
,
Nov 12 2016
Reverted: https://bugs.chromium.org/p/chromium/issues/detail?id=654695#c44
,
Nov 12 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-55; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-55 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 14 2016
Revert already merged: https://bugs.chromium.org/p/chromium/issues/detail?id=654695#c46 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rsesek@chromium.org
, Nov 11 2016Labels: -Pri-2 M-55 ReleaseBlock-Stable Needs-Bisect Pri-1
Status: Untriaged (was: Unconfirmed)