Remove settings constants defined in base class. |
|||||
Issue descriptionRemove definition of local settings constants that are now defined in the base class: - CHROME_SETTINGS_PAGE = 'chrome://settings' - SETTING_LABEL = 0 - SETTING_CHECKED = 1 - SETTING_DISABLED = 2 These constants will be removed from all tests that use them: - policy_SearchSuggestEnabled - policy_SpellCheckServiceEnabled - policy_AutoFillEnabled
,
Nov 11 2016
,
Nov 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/autotest/+/7d92682dda76814841ff83f6fa6ec77b2d59ecf8 commit 7d92682dda76814841ff83f6fa6ec77b2d59ecf8 Author: Scott Cunningham <scunningham@chromium.org> Date: Fri Nov 11 17:10:15 2016 Remove local constants definition defined in base class. - CHROME_SETTINGS_PAGE = 'chrome://settings' - SETTING_LABEL = 0 - SETTING_CHECKED = 1 - SETTING_DISABLED = 2 These constants will be removed from the three tests that use them: - policy_SearchSuggestEnabled - policy_SpellCheckServiceEnabled - policy_AutoFillEnabled BUG= chromium:664543 TEST=Run three tests above. Change-Id: Ie90a1e4813a6f8eefa09c4a528b48ba1544f68c3 Reviewed-on: https://chromium-review.googlesource.com/410126 Commit-Ready: Scott Cunningham <scunningham@chromium.org> Tested-by: Scott Cunningham <scunningham@chromium.org> Reviewed-by: Scott Cunningham <scunningham@chromium.org> Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org> [modify] https://crrev.com/7d92682dda76814841ff83f6fa6ec77b2d59ecf8/client/site_tests/policy_AutoFillEnabled/policy_AutoFillEnabled.py [modify] https://crrev.com/7d92682dda76814841ff83f6fa6ec77b2d59ecf8/client/site_tests/policy_SpellCheckServiceEnabled/policy_SpellCheckServiceEnabled.py [modify] https://crrev.com/7d92682dda76814841ff83f6fa6ec77b2d59ecf8/client/site_tests/policy_SearchSuggestEnabled/policy_SearchSuggestEnabled.py
,
Nov 12 2016
,
Dec 2 2016
Is working. Closing.
,
Mar 3 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by scunning...@chromium.org
, Nov 11 2016