Issue 664522 link

Starred by 1 user

Issue metadata

Status:	Archived
Owner:	kylec...@chromium.org
Closed:	Nov 2016
Cc:	mustash-bugs@google.com geoffl...@chromium.org rjkroege@chromium.org sky@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	3
Type:	Bug
Proj-Ozone Proj-Mustash-Mus VerifyIn-57 VerifyIn-58 VerifyIn-59 VerifyIn-60 VerifyIn-61

Ozone X11 fails to run

Project Member Reported by kylec...@chromium.org, Nov 11 2016

Issue description

Trying to run either cash or mash with Ozone X11 fails during GLContext initialization.

[26762:26762:1111/095650:ERROR:gl_context_egl.cc(117)] eglCreateContext failed with error EGL_BAD_ATTRIBUTE

This failure is caused by df7fff2d416e731d3a968cf6bd16bb6f5f60eaee. The trybots run as Ozone headless, not Ozone X11, so they didn't catch the problem.

The problematic patch can't be reverted easily because other patches have landed on top. Looking into a fix now before I revert multiple patches.

Comment 1 by kylec...@chromium.org, Nov 11 2016

Fix is in crrev.com/2495813002 and in CQ.

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/abe74bcd139f934688cc3c892efa350005a7ed41

commit abe74bcd139f934688cc3c892efa350005a7ed41
Author: kylechar <kylechar@chromium.org>
Date: Fri Nov 11 16:32:17 2016

Fix inverted if statement in GLContextEGL.

The context attributes for IsCreateContextRobustnessSupported got
inverted in crrev.com/2480373002. This breaks Ozone X11 running with
EGL.

BUG= 664522 
TBR=piman@chromium.org

Review-Url: https://codereview.chromium.org/2495813002
Cr-Commit-Position: refs/heads/master@{#431574}

[modify] https://crrev.com/abe74bcd139f934688cc3c892efa350005a7ed41/ui/gl/gl_context_egl.cc