New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664521 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 663179
issue 664505



Sign in to add a comment

System health common background:news:nytimes failing on TapElement

Project Member Reported by perezju@chromium.org, Nov 11 2016

Issue description

background:news:nytimes is consistently failing on Android Nexus7v2 Perf (2)

Example traceback:
Traceback (most recent call last):
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 87, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 299, in RunStory
    self._current_page.Run(self)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/page/__init__.py", line 109, in Run
    self.RunPageInteractions(action_runner)
  File "/b/rr/tmpzXWTDD/w/src/tools/perf/page_sets/system_health/system_health_story.py", line 112, in RunPageInteractions
    self._DidLoadDocument(action_runner)
  File "/b/rr/tmpzXWTDD/w/src/tools/perf/page_sets/system_health/background_stories.py", line 63, in _DidLoadDocument
    action_runner.TapElement(selector='.nytd-player-poster')
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 275, in TapElement
    selector=selector, text=text, element_function=element_function))
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/actions/action_runner.py", line 55, in _RunAction
    action.RunAction(self._tab)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/actions/tap.py", line 69, in RunAction
    element_function=self.element_function)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/actions/page_action.py", line 121, in EvaluateCallbackWithElement
    return tab.EvaluateJavaScript(code)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 193, in EvaluateJavaScript
    expr, context_id=None, timeout=timeout)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/browser/web_contents.py", line 221, in EvaluateJavaScriptInContext
    expr, context_id=context_id, timeout=timeout)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 36, in inner
    return func(inspector_backend, *args, **kwargs)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend.py", line 211, in EvaluateJavaScript
    return self._runtime.Evaluate(expr, context_id, timeout)
  File "/b/rr/tmpzXWTDD/w/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_runtime.py", line 53, in Evaluate
    raise exceptions.EvaluateException(text)
EvaluateException: Uncaught

 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016

Now that https://github.com/catapult-project/catapult/issues/2999 is addressed, we should reenable this to get the better exception message.

Comment 4 by hjd@chromium.org, Nov 16 2016

Trying it here: https://codereview.chromium.org/2505803002/

Comment 5 by ericrk@chromium.org, Nov 17 2016

Blocking: 663179
The try in #4 looks good, maybe land now?

Comment 7 by hjd@chromium.org, Nov 25 2016

Two bots failed only with the new test: android_one_perf_bisect android_nexus7_perf_bisect. One of those failures was tap based
("Error: Tap position is off-screen") the other is weirder
(predictors::PredictorDatabaseInternal::LogDatabaseStats(), https://cs.chromium.org/chromium/src/chrome/browser/predictors/predictor_database.cc?q=src/chrome/browser/predictors/predictor_database.cc:125&sq=package:chromium&l=125)

Is it okay to land in-spite of those? 
Cc: nednguyen@chromium.org
Hmm.. I would vote for yes, at least to see how often those failures occur, and whether we've made any improvements. Also a bug to check whether a regression was fixed is blocked on this.

Ned? what do you think?
To avoid the tap position, you can add ScrollToElement('..') before tapping to be sure. The predictors::PredictorDatabaseInternal::LogDatabaseStats could just be a flaky browser failure.

Comment 10 by hjd@chromium.org, Nov 25 2016

Owner: hjd@chromium.org
Status: Started (was: Untriaged)
I've borrowed an N7 and think I have a fix, uploading a CL now.
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08e303fd2871c16b1fb675743e7548bc7e4feff9

commit 08e303fd2871c16b1fb675743e7548bc7e4feff9
Author: hjd <hjd@chromium.org>
Date: Fri Nov 25 14:29:25 2016

Re-enable background:news:nytimes

Also fixes the story for the Nexus7

BUG= 664521 

Review-Url: https://codereview.chromium.org/2505803002
Cr-Commit-Position: refs/heads/master@{#434497}

[modify] https://crrev.com/08e303fd2871c16b1fb675743e7548bc7e4feff9/tools/perf/page_sets/system_health/background_stories.py

Comment 13 by hjd@chromium.org, Dec 6 2016

Status: Fixed (was: Started)

Sign in to add a comment