New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664516 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 664494



Sign in to add a comment

Very unclear bisect output from "Testing the "bad" revision failed"

Project Member Reported by sullivan@chromium.org, Nov 11 2016

Issue description

https://bugs.chromium.org/p/chromium/issues/detail?id=632652#c34
https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1813
https://build.chromium.org/p/tryserver.chromium.perf/builders/mac_retina_perf_bisect/builds/1813/steps/Failure%20reason/logs/reason

Big problem: there are no red steps. How should one investigate why testing the bad revision failed?
Smaller problem: no result code for bisect, so it doesn't post a failure reason on the bug.
 
There are no red steps on the bisect, because the failure happened on the builder. Bisect requested a build, and then it determined that the build had failed. This being on the reference range, it bailed as expected.

Rather than making a step artificially red, I'll make sure the message says something like: "Failed because building one of the revisions in the reference range failed" and I will also try to provide a link to the failed revision
The following change should have referred to this bug instead of 664156:
https://chromium.googlesource.com/chromium/tools/build/+/7ca55d253b11457ebacd13053e707d19f5325a95


Project Member

Comment 4 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb

commit 0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb
Author: robertocn <robertocn@chromium.org>
Date: Fri Nov 11 21:35:02 2016

Pushing the detailed error messages to dashboard.

For https://codereview.chromium.org/2498693002/ and
https://codereview.chromium.org/2496903004/ to work properly, we need to
push the error to dashboard through the 'aborted_message' field.

TBR=sullivan@chromium.org
BUG= 664516 

Review-Url: https://codereview.chromium.org/2494213002

[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/bisector.py
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_bisect_other_direction.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_linux_bisect.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_mac_bisect.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win32_bisect.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/basic_win64_bisect.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_build.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_buildbucket_get.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_reference_range.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_revision.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_repro.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/no_values.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/retest_bisect.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/example.expected/v8_roll_bisect_bis.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipe_modules/auto_bisect_staging/local_bisect.py
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipes/bisection/android_bisect_staging.expected/failure_in_ref_range.json
[modify] https://crrev.com/0a3f7b2a48a01d1048cbf636eb17f5509a37b0fb/scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_failed_device.json

Last job failed due to problem with dashboard. Deployed a dev version with the fix and uploaded a CL to land it permanently.

Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8996200736752906560
Status: Fixed (was: Untriaged)
An example of the correct output: https://bugs.chromium.org/p/chromium/issues/detail?id=632652#c37
Components: Speed>Bisection

Sign in to add a comment