New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664489 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Page going to Blank screen after switching to Fullscreen on Mac

Project Member Reported by durga.behera@chromium.org, Nov 11 2016

Issue description

Version: 56.0.2916.0
OS: Mac 10.11.6/Mac 10.12.1(both retina and non-retina)

Note : Issue is not seen on Windows and Linux.

What steps will reproduce the problem?
(1) Open any video URL(https://www.youtube.com/watch?v=UmbhHP7cFZ8,http://edition.cnn.com/videos)
(2) Click on Full screen button
(3) Observe the video screen

What is the expected result?
Video should play and visible.

What happens instead?
Screen is going to Blank screen and audio heard.

Please find the attached screen cast for the same.

Bisect info:
===========
Good:56.0.2914.3
Bad:56.0.2916.0

Change Log: https://chromium.googlesource.com/chromium/src/+log/69c6fdec22b2e94128f6ad016ff7b496b2e6704a..2b039432b32361aa1b772aa5fa878d43ac22eff6

Suspect : Review-Url: https://codereview.chromium.org/2492583002
fsamuel@ : Could you please take a look into this if its related to your change.
 
Screen going blank.mp4
2.6 MB View Download

Comment 2 by ajha@chromium.org, Nov 11 2016

Labels: hasbisect-per-revision
Cc: ccameron@chromium.org piman@chromium.org
+piman@, +ccameron in CC

It's possible my patch is at fault but it's not immediately obvious to me what's wrong in the patch. I'm building for Mac locally now, and I'll debug this. Thanks!
I should note that ccameron@ has worked on fullscreen mac video recently: https://codereview.chromium.org/2479723003/

Chris, could this actually be something you broke recently, or am I at fault? I'm still working on a full Mac build so I won't be able to repro this for another 20-30 min :-)

Comment 5 by gov...@chromium.org, Nov 11 2016

Cc: -gov...@chromium.org
I tried reverting ccameron's patch and that doesn't help. I'll try rolling back my last few patches. Video works for a little while full screen then goes blank.
I've confirmed that reverting https://codereview.chromium.org/2492583002 does indeed fix the problem. I'll investigate more carefully what I broke. 
Fix in flight: https://codereview.chromium.org/2499703002/

I've TBR'ed Antoine because he's OOO and this is a trivial fix to a serious problem.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e56e9c3126ffa852351d14c2bd7d74e703e5827

commit 8e56e9c3126ffa852351d14c2bd7d74e703e5827
Author: fsamuel <fsamuel@chromium.org>
Date: Fri Nov 11 21:35:15 2016

gpu: Fix Mac fullscreen video

https://codereview.chromium.org/2492583002/ introduced a bug where
one of the SwapBufeersCompleteParams were dropped before sending
an IPC to the gpu host. This CL plumbs the fullscreen_low_power_ca_context_id
parameter and deletes a stale comment.

BUG= 664489 
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2499703002
Cr-Commit-Position: refs/heads/master@{#431652}

[modify] https://crrev.com/8e56e9c3126ffa852351d14c2bd7d74e703e5827/gpu/ipc/service/gpu_command_buffer_stub.cc
[modify] https://crrev.com/8e56e9c3126ffa852351d14c2bd7d74e703e5827/gpu/ipc/service/pass_through_image_transport_surface.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-M56 TE-Verified-56.0.2918.0
Thank you @fsamuel for the quick fix.
Verified the issue on Mac 10.11.6 and Mac 10.12.1(both retina & Non-retina)using dev # 56.0.2918.0 and its working fine.
664489_Nov_18.mp4
7.3 MB View Download

Sign in to add a comment