Support using testharness.js in non-html documents.
Reported by
r...@opera.com,
Nov 11 2016
|
||||||||
Issue descriptionWe currently cannot use testharness.js in non-html documents like SVG because testharnessreport.js relies on document.body.
,
Nov 11 2016
Hrm. I'm not familiar enough with SVG documents to know what options we have, really. It seems like we should be able to render something useful for SVG, though. Perhaps pdr@ has opinions?
,
Nov 11 2016
,
Nov 11 2016
Maybe it'd work to create a <foreignObject> (append to documentElement and set x=y=0 and width=height=100%) in the relevant case in Output.resolve_log (!document.body) and then set that as the output_node. (Looks like the filtering code might still barf on that though...) Another option might be something more like the worker setup (i.e <iframe> and then transfer results to parent doc.) I suspect that's of fairly limited use though.
,
Nov 11 2016
I've actually been playing around with the foreignObject idea ...
,
Nov 11 2016
rune@, go ahead and own this if you expect to commit something.
,
Nov 14 2016
I actually asked rune to open this because he had to commit a -expected.txt file for a test that uses SVGs. I said to file a bug and see if anyone knows a way around this, and check if there was anyone working on fixing it.
,
Nov 14 2016
I ran into timeout issues with the experiment I did. If I pick it up again, I'll assign.
,
Dec 22 2016
,
Jun 1 2017
Hey, looking again at testharnessreport.js, it looks like maybe document.body is not assumed, and there is some code that has been put there specifically for the case where the document is SVG? https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/resources/testharnessreport.js?l=246 rune@, do you know if this is fixed, and if not, what might need to be done?
,
Jun 1 2017
It looks like this was probably fixed by https://codereview.chromium.org/2741403002 - tkent@, do you think this should be considered fixed?
,
Jun 2 2017
Yeah, it seems I fixed this :)
,
Jun 2 2017
\o/ |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by r...@opera.com
, Nov 11 2016