New issue
Advanced search Search tips

Issue 664439 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
V1



Sign in to add a comment

authpolicy: Add unit test for UserPolicyEncoder

Project Member Reported by ljusten@chromium.org, Nov 11 2016

Issue description

- Test encoding bool, int, string and string lists
- Make sure an empty string list is encoded as such

 
Summary: authpolicy: Add unit test for preg_policy_encoder (was: authpolicy: Add unit test for UserPolicyEncoder)
Summary: authpolicy: Add unit test for UserPolicyEncoder (was: authpolicy: Add unit test for preg_policy_encoder)

Comment 5 by tnagel@chromium.org, Nov 21 2016

Labels: -M-56 M-57

Comment 6 by tnagel@chromium.org, Nov 21 2016

Labels: V1
Labels: Enterprise-Triaged
Status: Started (was: Assigned)
Labels: Pri-1
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/7cb1e7de9d74ce74b998edbb52876160bbd8a145

commit 7cb1e7de9d74ce74b998edbb52876160bbd8a145
Author: Lutz Justen <ljusten@chromium.org>
Date: Thu Apr 13 03:22:35 2017

authpolicy: Add unit test for UserPolicyEncoder

Makes sure that all user policies get encoded into protobuf properly.

BUG= chromium:664439 
TEST=Compiled and ran tests.

Change-Id: I394dec71e1c8e6c4050f4f3c460a912df10e3e89
Reviewed-on: https://chromium-review.googlesource.com/468846
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@google.com>

[modify] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/policy/device_policy_encoder.cc
[modify] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/policy/device_policy_encoder.h
[modify] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/policy/preg_policy_encoder.cc
[modify] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/authpolicy.gyp
[add] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/policy/user_policy_encoder_unittest.cc
[modify] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/policy/device_policy_encoder_unittest.cc
[modify] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/policy/user_policy_encoder.cc
[modify] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/policy/user_policy_encoder.h
[add] https://crrev.com/7cb1e7de9d74ce74b998edbb52876160bbd8a145/authpolicy/policy/policy_encoder_test_base.h

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of Chromad V1 bugs

Sign in to add a comment