New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664437 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

Remove encoded image data for background tabs

Project Member Reported by hajimehoshi@chromium.org, Nov 11 2016

Issue description

Design doc: https://docs.google.com/document/d/1-nr_2Ce_dYtxNcb_oUU8IVfrpcjejnWt1OgsDf9eiVA/edit

At first, as image resource is highly likely in disk cache, we thought we could remove encoded image in a background inactive tab when purge + suspend happens. However, we realized that it'd be unacceptable if we cannot assure the image is 100% in the disk cache, so we need API to control lifetime of cache. The network team is working on it. We also need to confirm how much memory usage would be reduced with UMA.
 
Components: -Blink
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd79bd92221f5057521d62639b7c5e84645032ef

commit bd79bd92221f5057521d62639b7c5e84645032ef
Author: hajimehoshi <hajimehoshi@chromium.org>
Date: Mon Nov 21 07:36:28 2016

Add UMA to estimate deroppable memory usage of encoded data size in Resources

This CL adds a UMA to estimate droppable memory usage of encoded data
size in Resources when reusing disk cache is implemented. If it is 100%
sure that an encoded data is in disk cache, it is possible to remove
the same data from memory to reduce memory usage, and the UMA measures
this effectiveness.

BUG=664437

Review-Url: https://codereview.chromium.org/2499263002
Cr-Commit-Position: refs/heads/master@{#433491}

[modify] https://crrev.com/bd79bd92221f5057521d62639b7c5e84645032ef/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/bd79bd92221f5057521d62639b7c5e84645032ef/third_party/WebKit/Source/core/fetch/ImageResource.h
[modify] https://crrev.com/bd79bd92221f5057521d62639b7c5e84645032ef/third_party/WebKit/Source/core/style/StyleFetchedImage.cpp
[modify] https://crrev.com/bd79bd92221f5057521d62639b7c5e84645032ef/third_party/WebKit/Source/platform/DEPS
[modify] https://crrev.com/bd79bd92221f5057521d62639b7c5e84645032ef/third_party/WebKit/Source/platform/Histogram.h
[modify] https://crrev.com/bd79bd92221f5057521d62639b7c5e84645032ef/tools/metrics/histograms/histograms.xml

The current problem is that ImageResource::prune is not called so often than expected on desktops. tasak@ and I are now considering where purging image can be called.

Components: -Blink>Network Blink>Loader

Sign in to add a comment