MD Settings: Ripple effect diameter too big to fit inside row in OnStartup section.
Reported by
mni...@etouch.net,
Nov 11 2016
|
||||||
Issue descriptionVersion: 56.0.2916.0 bee9d25dd206a08d4b9b1bd86900cc354d8bb4e0-refs/heads/master@{#431463} (64-bit) OS: Windows (7,8,8.1,10),Mac OS X(10.11.6, 10.12.1) What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://md-settings/onStartup 2. Now press tab key and observe grey focus highlight on 'Open the New tab page' radio button Actual: Grey focus highlight on radio button is seen going out of box or appears larger than expected. Expected: Grey focus highlight on radio button should be seen properly This is regression issue, broken in ‘M 56’ and will soon update other info : Good build:56.0.2913.0 Bad build: 56.0.2914.0
,
Nov 11 2016
Issue os observed on Ubuntu 14.04 OS as well. Thanks.!
,
Nov 11 2016
The ripple is too big to fit inside the row it is displayed. This was happening even before https://codereview.chromium.org/2365453002, (see attached screenshot).
,
Nov 11 2016
,
Nov 18 2016
,
Nov 18 2016
Looking into this issue, and it seems like checkbox's ripple size is hardcoded to be 3*checkbox-size in Polymer source. I'm asking for Polymer team's thoughts on making that configurable; will get back to this once I hear back.
,
Nov 28 2016
Just for update, Still able to reproduce the issue on Ubuntu 14.04,Win 10.0 & Mac 10.11.6 using latest chrome canary version 57.0.2935.0. scottchen@ Could you please look into this issue. Thanks!
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7383f00039f3d3a10e76e714e51b69e9b9750309 commit 7383f00039f3d3a10e76e714e51b69e9b9750309 Author: dpapad <dpapad@chromium.org> Date: Wed Nov 30 02:04:43 2016 MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1 BUG= 664433 , 668021 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2526053002 Cr-Commit-Position: refs/heads/master@{#435124} [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_downloads/vulcanized.html [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_history/app.vulcanized.html [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_history/lazy_load.vulcanized.html [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/PRESUBMIT.py [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/bower.json [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.html [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components_summary.txt [modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/web-animations-js/sources/.bower.json
,
Dec 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c6ab947d7b070c009ee5199e8e447757d8c0179 commit 2c6ab947d7b070c009ee5199e8e447757d8c0179 Author: scottchen <scottchen@chromium.org> Date: Thu Dec 01 21:33:48 2016 MD Settings: Reduce paper-radio-button's ripple size. paper-radio-button's ripple size is changed to 40px to be consistent with the default ripple size as paper-checkbox. This size reduction will prevent it from going out of its container's bounds. BUG= 664433 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2539353003 Cr-Commit-Position: refs/heads/master@{#435720} [modify] https://crrev.com/2c6ab947d7b070c009ee5199e8e447757d8c0179/chrome/browser/resources/settings/settings_vars_css.html
,
Dec 8 2016
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by hdodda@chromium.org
, Nov 11 2016Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)