New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664433 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

MD Settings: Ripple effect diameter too big to fit inside row in OnStartup section.

Reported by mni...@etouch.net, Nov 11 2016

Issue description

Version: 56.0.2916.0 bee9d25dd206a08d4b9b1bd86900cc354d8bb4e0-refs/heads/master@{#431463} (64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.11.6, 10.12.1)

What steps will reproduce the problem?
1. Launch chrome, navigate to chrome://md-settings/onStartup
2. Now press tab key and observe grey focus highlight on 'Open the New tab page' radio button

Actual: Grey focus highlight on radio button is seen going out of box or appears larger than expected.
Expected: Grey focus highlight on radio button should be seen properly

This is regression issue, broken in ‘M 56’ and will soon update other info :
Good build:56.0.2913.0 
Bad build: 56.0.2914.0
 
Actual_video.mov
1.8 MB Download
Expected_video.mov
2.7 MB Download
Actual_screenshot.png
257 KB View Download
Expected_screenshot.png
255 KB View Download

Comment 1 by hdodda@chromium.org, Nov 11 2016

Cc: hdodda@chromium.org
Labels: hasbisect-per-revision
Owner: dpa...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good Build : 56.0.2913.0 (Revision:430459)
Bad Build : 56.0.2914.0 (Revision:430837)

You are probably looking for a change made after 430815 (known good), but no later than 430816 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.
  https://chromium.googlesource.com/chromium/src/+log/4d77b0e6f0b1ee3fc3b9a1ddb268d86f7c29f065..8c4965f69d6de2d3c4ed9c6cd5b2ccbee1667cad

From the CL above, assigning the issue to the concern owner 

@dpapad - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Review-Url: https://codereview.chromium.org/2365453002

Thanks!
Labels: OS-Linux
Issue os observed on Ubuntu 14.04 OS as well.

Thanks.!

Comment 3 by dpa...@chromium.org, Nov 11 2016

Cc: scottchen@chromium.org
Labels: Proj-MaterialDesign-WebUI
Owner: ----
Status: Available (was: Assigned)
Summary: MD Settings: Ripple effect diameter too big to fit inside row in OnStartup section. (was: Regression : Grey focus highlight on radio button is seen going out of box in chrome://md-settings/onStartup.)
The ripple is too big to fit inside the row it is displayed. This was happening even before https://codereview.chromium.org/2365453002, (see attached screenshot).

Comment 4 by dpa...@chromium.org, Nov 11 2016

ripple_too_big.png
21.5 KB View Download
Owner: scottchen@chromium.org
Status: Started (was: Available)
Looking into this issue, and it seems like checkbox's ripple size is hardcoded to be 3*checkbox-size in Polymer source. I'm asking for Polymer team's thoughts on making that configurable; will get back to this once I hear back.
Cc: rbasuvula@chromium.org
Just for update, Still able to reproduce the issue on Ubuntu 14.04,Win 10.0 & Mac 10.11.6 using latest chrome canary version 57.0.2935.0.

scottchen@ Could you please look into this issue.

Thanks!
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7383f00039f3d3a10e76e714e51b69e9b9750309

commit 7383f00039f3d3a10e76e714e51b69e9b9750309
Author: dpapad <dpapad@chromium.org>
Date: Wed Nov 30 02:04:43 2016

MD Settings: roll paper-radio-button, 1.2.1 -> 1.3.1

BUG= 664433 , 668021 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2526053002
Cr-Commit-Position: refs/heads/master@{#435124}

[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/chrome/browser/resources/md_history/lazy_load.vulcanized.html
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/PRESUBMIT.py
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/bower.json
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/bower.json
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button-extracted.js
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components-chromium/paper-radio-button/paper-radio-button.html
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/polymer/v1_0/components_summary.txt
[modify] https://crrev.com/7383f00039f3d3a10e76e714e51b69e9b9750309/third_party/web-animations-js/sources/.bower.json

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c6ab947d7b070c009ee5199e8e447757d8c0179

commit 2c6ab947d7b070c009ee5199e8e447757d8c0179
Author: scottchen <scottchen@chromium.org>
Date: Thu Dec 01 21:33:48 2016

MD Settings: Reduce paper-radio-button's ripple size.

paper-radio-button's ripple size is changed to 40px to be consistent with the default ripple size as paper-checkbox. This size reduction will prevent it from going out of its container's bounds.

BUG= 664433 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2539353003
Cr-Commit-Position: refs/heads/master@{#435720}

[modify] https://crrev.com/2c6ab947d7b070c009ee5199e8e447757d8c0179/chrome/browser/resources/settings/settings_vars_css.html

Status: Fixed (was: Started)

Sign in to add a comment