New issue
Advanced search Search tips

Issue 664430 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

chrome:crashes omits the crash time stamp after it is sent

Project Member Reported by phistuck@gmail.com, Nov 11 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.71 Safari/537.36

Steps to reproduce the problem:
Prerequisite -
A Chrome tab crashes and you exit Chrome seconds or minutes later, so the crash is not yet sent to the server. Wait some time.

1. Go to chrome:crashes.
2. Click on "Send now" for a crash that happened some time ago.
3. Wait a few moments for the crash to be sent.
4. Refresh.

What is the expected behavior?
Crash report captured on Friday, November 11, 2016 at 10:36:33 AM was automatically reported Friday, November 11, 2016 at 10:36:33 AM.

What went wrong?
Automatically reported Friday, November 11, 2016 at 10:36:33 AM

Did this work before? N/A 

Chrome version: 56.0.2915.0  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: 

One of the issues is that I have an option to report the crash, but I do not know when the crash actually happened, which makes it hard to retrace my steps.
The other issue is that it was not automatically reported, as I manually clicked on "Send now", but that is a fairly minor issue.
(Also minor - "captured on (date)" versus "reported (date)". The former uses "on", the latter omits it)
 
Components: -UI UI>Browser>WebUI
Labels: -Type-Bug Hotlist-Polish Type-Feature

Comment 2 by phistuck@gmail.com, Nov 11 2016

Should be a small change...

File - src/components/crash_strings.grdp
  <message name="IDS_CRASH_CRASH_TIME_FORMAT" desc="Format for crash entry occurrence time on chrome://crashes">
-    Automatically reported <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>
+    Crash report captured on <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>, reported on <ph name="CRASH_TIME">$1<ex>Tuesday, January 25, 2011 2:58:02 PM</ex></ph>
  </message>

File - src/components/crash/core/browser/crashes_ui_util.cc
    if (info.state == UploadList::UploadInfo::State::Uploaded) {
-      crash->SetString("time",
+      crash->SetString("upload_time",
                       base::TimeFormatFriendlyDateAndTime(info.upload_time));
-    } else {
+    }
      crash->SetString("time",
                       base::TimeFormatFriendlyDateAndTime(info.capture_time));
-    }

File - src/components/crash/core/browser/resources/crashes.js
    if (uploaded) {
      var date = document.createElement('p');
      date.textContent = loadTimeData.getStringF('crashTimeFormat',
-                                                 crash.time);
+                                                 crash.time,
+                                                 crash.upload_time);
      crashBlock.appendChild(date);
Status: Untriaged (was: Unconfirmed)
Marking it as Untiraged as the issue is of Type-Feature.


Comment 4 by treib@chromium.org, Dec 12 2016

Cc: rsesek@chromium.org
Cc: gayane@chromium.org scottmg@chromium.org
scottmg, gayane - care to submit those changes? Thank you, anyway.

Comment 6 by napper@chromium.org, Dec 12 2016

Owner: jiameng@chromium.org

Comment 7 by napper@chromium.org, Dec 12 2016

Status: Assigned (was: Untriaged)

Comment 9 by phistuck@gmail.com, Dec 14 2016

Yay, thank you very much!
Status: Fixed (was: Assigned)

Comment 11 by phistuck@gmail.com, Dec 20 2016

A fixed manual patch is attached.
crashes-patch.txt
2.0 KB View Download

Comment 12 by w...@chromium.org, Dec 27 2016

Status: Started (was: Fixed)
Project Member

Comment 13 by bugdroid1@chromium.org, Dec 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fd83ce883b96af751b0a2d7919f40b3bbadf1e4

commit 8fd83ce883b96af751b0a2d7919f40b3bbadf1e4
Author: wez <wez@chromium.org>
Date: Tue Dec 27 23:14:59 2016

Revert of Fixed a bug where chrome crash omits crash time stamp after it's sent. (patchset #1 id:1 of https://codereview.chromium.org/2568953003/ )

Reason for revert:
See  crbug.com/674249 : This change broke things in two ways:
- The string format incorrectly uses the crash-time parameter twice, rather than the second parameter coming from upload-time.
- The string format assumes that all crashes have a valid crash-time, which is not the case for Breakpad reports.

Original issue's description:
> Fixed a bug where chrome crash omits crash time stamp after it's sent.
>
> This cl patches in the solution devised by phistuck@gmail.com. See  bug 664430  for detail.
>
> BUG= 664430 
>
> Committed: https://crrev.com/d8027b2065994c2a5b8cbea2821971dc60b7c6f5
> Cr-Commit-Position: refs/heads/master@{#438333}

TBR=rsesek@chromium.org,jiameng@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 664430 

Review-Url: https://codereview.chromium.org/2601853002
Cr-Commit-Position: refs/heads/master@{#440801}

[modify] https://crrev.com/8fd83ce883b96af751b0a2d7919f40b3bbadf1e4/components/crash/core/browser/crashes_ui_util.cc
[modify] https://crrev.com/8fd83ce883b96af751b0a2d7919f40b3bbadf1e4/components/crash/core/browser/resources/crashes.js
[modify] https://crrev.com/8fd83ce883b96af751b0a2d7919f40b3bbadf1e4/components/crash_strings.grdp

Comment 14 by w...@chromium.org, Jan 6 2017

Cc: phistuck@chromium.org jiameng@chromium.org
Owner: w...@chromium.org
Cc: -phistuck@chromium.org
(I starred the bug already, thank you)
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5ffc3925eacc602f07e724560a4b0830edf108c

commit c5ffc3925eacc602f07e724560a4b0830edf108c
Author: wez <wez@chromium.org>
Date: Fri Jan 06 23:18:25 2017

Display both capture and upload times in chrome://crashes.

Originally chrome://crashes only displayed uploaded crashes, and only
displayed the time at which the crash report was uploaded.

On systems using Crashpad we also have access to the crash capture-time
which is useful in identifying crash reports which occurred while
offline, for example, such that the capture and upload times would
differ considerably.

This patch was originally drafted by phistuck@gmail.com and
jiameng@chromium.org.

BUG= 664430 , 674249 

Review-Url: https://codereview.chromium.org/2612993003
Cr-Commit-Position: refs/heads/master@{#442091}

[modify] https://crrev.com/c5ffc3925eacc602f07e724560a4b0830edf108c/components/crash/core/browser/crashes_ui_util.cc
[modify] https://crrev.com/c5ffc3925eacc602f07e724560a4b0830edf108c/components/crash/core/browser/resources/crashes.js
[modify] https://crrev.com/c5ffc3925eacc602f07e724560a4b0830edf108c/components/crash_strings.grdp

Comment 17 by w...@chromium.org, Jan 6 2017

Status: Fixed (was: Started)
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6d7142534246d479668c7ad7122d7864979e2b8

commit a6d7142534246d479668c7ad7122d7864979e2b8
Author: wez <wez@chromium.org>
Date: Thu Jan 19 05:37:56 2017

Improve crash format text for the captured & uploaded case.

The previous wording was clumsy, and the format's description was not
sufficient for translators to understand the intended phrasing.

BUG= 664430 ,b/34237079

Review-Url: https://codereview.chromium.org/2632613003
Cr-Commit-Position: refs/heads/master@{#444656}

[modify] https://crrev.com/a6d7142534246d479668c7ad7122d7864979e2b8/components/crash_strings.grdp

Sign in to add a comment