New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664420 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Enable traffic shaping for loading story set

Project Member Reported by ksakamoto@chromium.org, Nov 11 2016

Issue description

Currently loading.mobile perf benchmark is running without any traffic shaping.
Now telemetry supports traffic shaping using TsProxy, so loading benchmark can take advantage of it.

Plan: run each story in the loading story set with two traffic settings.
- No traffic shaping (as before)
- "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/88fadb24d5573872129ea8809918f509b1e34757

commit 88fadb24d5573872129ea8809918f509b1e34757
Author: catapult-deps-roller <catapult-deps-roller@chromium.org>
Date: Wed Nov 30 08:54:19 2016

Roll src/third_party/catapult/ 2dd86f198..d4f87ce5d (5 commits).

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/2dd86f198093..d4f87ce5d439

$ git log 2dd86f198..d4f87ce5d --date=short --no-merges --format='%ad %ae %s'
2016-11-29 ksakamoto Add traffic setting as a grouping key
2016-11-29 mikecase Adding two additional ungrantable permissions to blacklist.
2016-11-29 sullivan Add tracing directories to deployment paths.
2016-11-29 simonhatch Dashboard - Remove stdev option from bisect-form.html.
2016-11-29 charliea Mark tail calls as "Approved" in style guide

BUG= 664420 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2543563002
Cr-Commit-Position: refs/heads/master@{#435181}

[modify] https://crrev.com/88fadb24d5573872129ea8809918f509b1e34757/DEPS

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9febcf5133be621b82954c0fea52123fa4f8b7a8

commit 9febcf5133be621b82954c0fea52123fa4f8b7a8
Author: ksakamoto <ksakamoto@chromium.org>
Date: Wed Nov 30 12:13:04 2016

Enable traffic shaping in loading.mobile benchmark

After this patch, loading.mobile benchmark will run with two traffic
configurations:

- No traffic shaping (as before)
- "Regular 3G" (Down 750kbps, Up 250kbps, 100ms RTT)

BUG= 664420 

Review-Url: https://codereview.chromium.org/2493063002
Cr-Commit-Position: refs/heads/master@{#435230}

[modify] https://crrev.com/9febcf5133be621b82954c0fea52123fa4f8b7a8/tools/perf/benchmarks/loading.py
[modify] https://crrev.com/9febcf5133be621b82954c0fea52123fa4f8b7a8/tools/perf/page_sets/loading_mobile.py

Status: Fixed (was: Assigned)

Sign in to add a comment