Regression: Browser crash is seen after 'View page source' of chrome://bookmarks
Reported by
jshan...@etouch.net,
Nov 11 2016
|
|||
Issue descriptionChrome Version: 56.0.2916.0 (Official Build)bee9d25dd206a08d4b9b1bd86900cc354d8bb4e0-refs/heads/master@{#431463}-32/64 bit OS : Mac(10.11.6, 10.12.1), Windows (7,8,8.1,10), Linux (14.04 LTS) Steps: 1. Launch Chrome and navigate to chrome://bookmarks. 2. Press 'Ctrl+U' keys and observe. Actual: Browser crash is seen after 'View page source' of chrome://bookmarks Expected: Browser crash should not be seen on opening 'View page source' of chrome://bookmarks This is a regression issue broken in ‘M-56’, below is the Manual Regression range and will soon update bisect info. Good Build : 56.0.2914.0 Bad Build : 56.0.2915.0 Crash ID bc05c922-a893-4c4a-bd5c-c15d54bc64ee (Server ID: 6b5e290500000000)
,
Nov 11 2016
Note: Above issue is also reproducible by following steps. Steps: 1. Launch Chrome and navigate to chrome://bookmarks 2. Right click on page (near search box or Header) and select 'view page source' from context menu. 3. Observe.
,
Nov 11 2016
Using the per-revision bisect providing the bisect results, Good build: 56.0.2914.0 (Revision: 430837). Bad build: 56.0.2915.0 (Revision: 431137). You are probably looking for a change made after 430939 (known good), but no later than 430940 (first known bad). CHANGE-LOG URL: --------------------------------------- https://chromium.googlesource.com/chromium/src/+log/35d322e24f91a372ecdc0b152891e0635187a07e..a32a0900c104b2143e6462febc81e6900dbd2104 From the CL above, assigning the issue to the concern owner @ rdevlin.cronin : ------------------ Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner. Review-Url: https://codereview.chromium.org/2468673003 Note : Able to reproduce the issue in Ubuntu 14.04, Win 10.0 & Mac 10.11.6.
,
Nov 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62fa72cbd02ff4e279efe12145dd4b1a3d221821 commit 62fa72cbd02ff4e279efe12145dd4b1a3d221821 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Fri Nov 11 19:03:07 2016 [Extensions] Don't remove the bookmark drag event router as delegate Previously, the BookmarkManagerPrivateDragEventRouter removed itself as the BookmarkTabHelper's delegate on destruction. Since crrev.com/a32a0900c104b2143e6462febc81e6900dbd2104, both the event router and the BookmarkTabHelper are WebContentsUserData, and thus will be destroyed at the "same" time (that is, synchronously - if the BookmarkTabHelper tried to access the BookmarkManagerPrivateDragEventRouter in its dtor, it's unsafe, but hopefully we never do that). Don't remove the BookmarkManagerPrivateDragEventRouter as a delegate since there's a chance the BookmarkTabHelper has already been destroyed. BUG=664371 BUG= 664419 Review-Url: https://codereview.chromium.org/2488203003 Cr-Commit-Position: refs/heads/master@{#431607} [modify] https://crrev.com/62fa72cbd02ff4e279efe12145dd4b1a3d221821/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
,
Nov 11 2016
Should be fixed with @4. |
|||
►
Sign in to add a comment |
|||
Comment 1 by ranjitkan@chromium.org
, Nov 11 2016Owner: rdevlin....@chromium.org
Status: Assigned (was: Unconfirmed)