test team, please repro and provide logs/bugreport.

if it repro's please also do a bisect.

ppolisetty@ working on it.

I tried to repro this issue on Samsung Galaxy Tab S2(SM-T815)/MMB29K & Samsung Galaxy Tab S2(SM-T815Y)/MMB29K with Webview System image:49.0.2623.105 & Webview stable (playstore version): 54.0.2840.85 on both devices.

Here are the steps:
1. Go to Gmail/OEM email
2. Open any email and tap on the 3-dot menu on the toolbar>Print
3. In the Save as PDF page, Tap on down arrow on the toolbar and then on "All printers"

Observed result:
In "All printers" page, I just see "Searching for printers" message with the spinner wheel forever and printers' list is not loaded. 

Frequency: 5/5

Logcat @ http://go/chrome-androidlogs1/6/664400

The searching for printers is probably a different issue. Also I do not think this affected gmail. I was testing imap/pop client apps.

 Issue 665397  has been merged into this issue.

Let me share some typical log:
11-03 17:01:43.680 12695-12695/? I/RemotePrintDocument: [CALLED] update()
11-03 17:01:43.680 12695-12695/? I/RemotePrintDocument: [PERFORMING] layout
11-03 17:01:43.680 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.680 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.680 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.680 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.680 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.680 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.680 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.680 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.690 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.690 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.690 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.690 12695-12695/? W/ResourcesManager: getTopLevelResources: /system/framework/framework-res.apk / 1.0 running in com.android.printspooler rsrc of package android
11-03 17:01:43.700 12695-12695/? I/RemotePrintDocument: [CALLBACK] onLayoutStarted
11-03 17:01:43.700 12695-12695/? I/RemotePrintDocument: [CALLBACK] onLayoutFinished PrintDocumentInfo{name=Gmail - Необходимые действия: Подтвердите свой адрес электронной почты в HP Connected, pageCount=-1, contentType=CONTENT_TYPE_DOCUMENT, dataSize=0}
11-03 17:01:43.700 12695-12695/? I/RemotePrintDocument: [CommandDoneCallback] onDone mCurrentCommand: LayoutCommand [mSequence=166, mError=null, mState=2] mNextCommand: null
11-03 17:01:43.700 12695-13953/? I/MutexFileProvider: Acquired file: /data/user/0/com.android.printspooler/files/print_job_c1824178-cc56-4882-842b-d774a1a3094f.pdf by thread: Thread[AsyncTask #7,5,main]
11-03 17:01:43.700 12695-13953/? I/RemotePrintDocument: [PERFORMING] write
11-03 17:01:43.700 12695-12695/? I/RemotePrintDocument: [CALLBACK] onWriteStarted
11-03 17:01:43.700 12695-12695/? I/RemotePrintDocument: [CALLBACK] onWriteFailed
11-03 17:01:43.700 12695-12695/? I/RemotePrintDocument: [CommandDoneCallback] onDone mCurrentCommand: WriteCommand [mSequence=167, mError=null, mState=5] mNextCommand: null
11-03 17:01:43.700 12695-12695/? I/RemotePrintDocument: [CALLING] onUpdateCompleted()
11-03 17:01:43.700 12695-12695/? I/PrintActivity: onUpdateFailed()
11-03 17:01:43.700 12695-13953/? I/MutexFileProvider: Released file: /data/user/0/com.android.printspooler/files/print_job_c1824178-cc56-4882-842b-d774a1a3094f.pdf from thread: Thread[AsyncTask #7,5,main]
11-03 17:01:43.700 12695-12695/? I/InjectionManager: dispatchOnViewCreated > Target : com.android.printspooler.ui.PrintErrorFragment isFragment :true

Deleted: Image 1.jpg 27.8 KB

	Image 1.jpg 27.8 KB View Download

Deleted: Image 2.jpg 10.0 KB

	Image 2.jpg 10.0 KB View Download

Hmm, it would be great with a bisect here, ppolisetty@ could you try this with one of the devices in  crbug.com/665397 ? S7 / S7 Edge / S6 Edge

gsennton@, I tried this issue on Samsung Galaxy S7 Edge, S7 & S6 Edge. On both S7Edge and S6Edge, I could repro this issue but not very consistently. When I open an email on Gmail/OEM, I see this issue on 8/10 emails instead of the PDF preview. On Galaxy S7 (SM-G930P) however, when the 3-dot menu is tapped and print option is selected, the print dialog opens for a few seconds and then goes back to the email page.

logs @ http://go/chrome-androidlogs1/6/664400
Files added: s7_vid.mp4
             S7_664400_logcat.txt
             S6Edge_664400_logcat2.txt
             S6Edge_664400_logcat.txt

Cool, so that seems to be a fairly consistent repro :).
Could we get a bisect please?

Polite ping, any updates we can provide affected customers?

 Issue 668147  has been merged into this issue.

gsennton@, here is the Bisect Range :  https://chromium.googlesource.com/chromium/src/+log/54.0.2830.0..54.0.2837.2?pretty=fuller&n=10000

Additional Info: I noticed when I have webview build 54.0.2820.0 on Samsung Galaxy S7 trying to print from gmail, the preview is not displayed. It shows spinner for a long time and the print preview displayed is blank. I have added a video and logcat please see below.
Any builds after that, i.e from 54.0.2823.0 thru 54.0.2830.0, I see spinning for a long time but the preview loads. 

logs @ http://go/chrome-androidlogs1/6/664400
Files added: S7edge_54.0.2837.2_logcat.txt
             S7edge_54.0.2820.0_print_vid.mp4
             s7edge_664400_54.0.2820.0_logcat2.txt

Correction: the device is Samsung Galaxy S7 Edge (SM-G935A)

Hey team, do we have any update in this bug?

Polite ping. We have some affected customer waiting for updates.

Thanks.

I don't think what the testing team found, and what the original reporter was reporting is the same issue.

So, need a better bug report, ie with more information, from the original reporter, or someone suffering from the exact same bug. Answer these questions:

* What exact app is being used? Provide a play store link.
* What device is being used?
* What exact webview version is broken? Also would be good to know what version wasn't broken.
* What's the exact steps to reproduce this? What happens at each step?
* Attach an android bugreport from the device after the problem occurs: http://tamingthedroid.com/take-bug-report
* Screenshots/Video would help to, just to rule out other issues.

I'll take a fix to any of the above issues.  The comment above from Nov. 17, 2016 seems close enough for me.

More details about the web view versions were documented in the  issue #665397 

I recently checked with Pixel with OS 7.1.1 and everything works fine in that. Probably because it is not using Webview. WebView in Pixel is disabled and there is no way to enable that. 

I also tried on the Beta version of Android 7.0 on Galaxy S7 edge and Web View is disabled on that too. But I can still reproduce the issue in Galaxy S7

On Galaxy Note 5 (SM-N920S)with Android 6.0.1 and WebView version 56.0.2924.53 I can still reproduce the issue


Text of  issue #665397 
Device name: Samsung S7 Edge (SM-G935S)
Android version: 6.0.1
WebView version (from system settings -> Apps -> Android System WebView):54.0.2840.85
Application: Gmail
Application version:6.10.9.136347105.release


Steps to reproduce:
(1) Open any email in Gmail
(2) Tap print
(3) Select printer "Save as PDF"
(4) Sometimes it shows "Failed to change settings" in print preview screen.
(5) If it does not show above error string, try changing orientation in print settings and it will show the same error

Expected result:
Preview Should be generated fine.

Actual result:
"Failed to change settings" is shown in preview.

Android System WebView version	Test Phone	Test Results
V50.0.2661.86	Galaxy S7	Good
v51.0.2704.81	Galaxy S6 Edge	Good
v54.0.2850.85 	Galaxy S7	Not Good
v54.0.2850.85 	Galaxy S6 Edge	Not Good

Hi, to address questions in comment 21:

* What exact app is being used? Provide a play store link.
Gmail App
https://play.google.com/store/apps/details?id=com.google.android.gm

* What device is being used?
Mobile device: HTC One M7 
OS version of Android: 5.0.2 
HTC Sense version: 6.0 
Android System WebView app installed 
version 55.0.2883.91

* What exact webview version is broken? Also would be good to know what version wasn't broken.
- version 54.0.2840.85, updated on Oct 31, 2016 
- version 55.0.2883.91, updated on Dec 14, 2016 
- We are not aware of a version that is not broken. We've only been testing the two versions listed above.

* What's the exact steps to reproduce this? What happens at each step?
1. Using a device running the Andriod OS.
2. Open an email via GMAIL 
3. Choose the Print function 
4. Choose any printer.
5. Select Print 
6. Receive ‘Failed to Print’ error 

* Attach an android bugreport from the device after the problem occurs:
Devices were the issue is reproducible have corporate accounts that may contain sensitive data, thus, they can’t provide the bug report.

* Screenshots/Video would help to, just to rule out other issues.
https://drive.google.com/file/d/0B6n8TuD8FTNJUzAyTEhQOVdhNlU/view?usp=sharing

And again pointing out, not restricted to that device, that Android version, or that email program.

Hi,

I was able to reproduce the issue on my phone while trying to print from the Gmail app. Bug report file at https://drive.google.com/open?id=0Bxg-rTzA58PeYW1jZjEtdUlYdk0. It's Google restricted.

All device information details are included in the log, but summarizing:

Make/Model: Samsung S5 Mini.
Android version: 6.0.1
Android System WebView version: 55.0.2883.91

I tested it in my Nexus 5x with 55.0.2283.91. No problems, it printed right away.

I will try a few other devices.

works fine on my nexus 5 either. Did anybody see this bug in a nexus device?

#23, pixels also use WebView. webView apk is disabled because its code is provided by Chrome apk. 

Try changing a setting such as B&W instead of color (it also sometimes happens when selecting a different printer).  If I do that it always gives me a screen that says "Failed to change the settings. Try again." with a "retry" button below it.  When pressing the "retry" button it just gives the same error and you cannot print nor select any print options, you can only get out with the back button which takes you back to the original email.

This happens for me on my Samsung S6 Edge, currently System WebView version 56.0.2924.68. It has happened for a long, long time and many past versions of WebView.  If I revert back to the original "stock" version of WebView this error does not happen.  That is version 51.0.2704.81.  I can select a printer and change a setting, again such as from color to B&W, and it changes the print preview from color to B&W with no error.  I just did this to verify.

changing settings did not help repro it for me. (color/bw, landscape/portrait, paper size)

I see cancelled print jobs in the bugreport provided above. I am not sure why though.

Does the error happen if you save as pdf?

does the error happen when trying to choose a page range?

I can select Save as PDF fine.  If I try to change a setting, landscape/portrait being the only one selectable for PDF, it gives me the same error. 

One interesting note.  When changing the option from color to b&w it gives me the error, but when I hit the "retry" button displayed with the error dialog I can VERY briefly see an image of the document in b&w and then the error message is displayed.  It is displayed very fast then gone. This is repeatable as long as I keep hitting the retry button.

Just for the record, my main printer is a HP LaserJet.

Page range seems to work just fine and the preview displays the appropriate pages selected.  Number of copies works fine.  Color/b&w errors along with orientation, I cannot test paper size and double-sided due to lack of printer support.

These errors happen whether I select my printer directly or select via cloud print to that printer.

I also just checked Saving to Google Drive and when trying to change the orientation it errors out.

For me, save as PDF provides Color/Bw, Paper size, orientation, pages, etc options.

Time to find a samsung phone I guess.

HP printer also seems common across numerous reports.

yeah reproed on samsung right away. webview does not do anything different for samsung vs nexus so I will probably have to take the question to Android printing team to see whether they have any suggestion.

Those options are there, just not selectable.  Just orientation and range.

More random notes.  I tried from my 2013 Nexus 7 and do not seem to have these same errors.  One small point of interest, when changing color to b&w on the Nexus the preview shown does NOT change to b&w like on my Samsung, it stays color but changing orientation IS reflected in the preview...odd. 

I will try to remember tomorrow and test my friend's S6 and S7 Edge and see what happens with their phones.  They also happen to have a Brother printer instead of an HP so maybe that will shed some light on  something.

And yet one more thing.  I can do all of this perfectly fine, with no errors, from Google Photos.  I can select b&w for my HP printer and the preview changes. Never any errors.  

Printing from Chrome (a PITA BTW as you have to select share>print) also works fine.  I tested a web page and was able to change color to b&w and the preview showed just fine.

I am suspicious that the bug is related to both WebView and some particular OEM phones. 

We may need one more bisect on a Samsung phone to figure out the exact WebView build that this issue started happening. 

this bug has become confusing over time, change the title.

the regression range seems to be
https://chromium.googlesource.com/chromium/src/+log/54.0.2832.0..54.0.2833.0?pretty=fuller&n=10000

nothing immediately stands out.

I wrote an app to print a simple WebView page and my test on a Samsung phone did not repro the issue. 

This seems to be specific to email apps. Not sure what they do that is different from a browser or a pdf reader.

I agree, other apps seem to print fine.

Bug appears on Samsung SM-T535 (Samsung Galaxy Tab 4 10.1 LTE), Android 5.0.2

But not only on email apps: In our case a cordova app (using chrome webview) which invokes the native print dialog. issue with details here:
https://github.com/katzer/cordova-plugin-printer/issues/121#issuecomment-274361962

Yeah it is some problem with WebView on Samsung devices. I will debug it further next week.

 Issue 686462  has been merged into this issue.

I am able to print from other apps, including Gmail;just not the stock Samsung email app. Thanks.

Tried the new 2/1/17 update. Same story.:(

Deleted: Screenshot_20170202-065159.png 108 KB

	Screenshot_20170202-065159.png 108 KB View Download

Latest update, dated 1/31/17, worked with the Samsung mobile print plug-in. HP plug-in did not work. Thanx.

Deleted: Screenshot_20170202-202013.png 105 KB

	Screenshot_20170202-202013.png 105 KB View Download

It does not work with Samsung plug-in for me.  Try changing a setting such as color/B&W and it will error out.  And if I try to print it without changing a setting it errors out.

Today's release fails to work with both Samsung and HP mobile print plug-ins. 

Deleted: Screenshot_20170209-074119.png 108 KB

	Screenshot_20170209-074119.png 108 KB View Download

sgurun@ is there any update on this? I have a customer who says this issue is holding up a critical project for them - any info we can pass along would be extremely helpful.

Sorry this took a while because I was waiting for a OEM device that I can actually debug. 

Anyhow, I found the reason. Applications create a printdocumentadapter using WebView.createPrintDocumentAdapter and passes it to Android framework, which then drives the printing flow. If an application cleans all the references to this WebView, then it can be GC'ed before printing flow ends. During the print UI flow, as the user changes settings, frameworks makes calls the printdocumentadapter that is created above, and thus WebView being GC'ed is fatal, i.e. not an exception but printing will fail.

To prevent WebView being GC'ed we keep a reference to the webview in the printdocumentadapter as long as frameworks owns it.

Unfortunately some proguard optimization has landed and proguard optimized away that field. I verified that reverting https://codereview.chromium.org/2240483002 fixes the problem.

I am looking at options to fix it. Either I will change the proguard optimization, make the field volatile (not sure how volatile and proguard interacts for private variables) or both.

No change to the java code will work unless you actually make the field used - making it volatile won't help, proguard doesn't care. You'll have to just add a -keep rule for the field :(

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e06547be990aacac4ae3ff0382d2aa222b4280a

commit 5e06547be990aacac4ae3ff0382d2aa222b4280a
Author: sgurun <sgurun@chromium.org>
Date: Wed Feb 15 07:03:49 2017

Keep the reference to local private variable.

Applications create a printdocumentadapter using WebView.createPrintDocumentAdapter
and passes it to Android framework, which then drives the printing flow.
If an application cleans all the references to this WebView,
then it can be GC'ed before printing flow ends. During the print UI flow,
as the user changes settings, frameworks makes calls the printdocumentadapter
that is created above, and thus WebView being GC'ed is fatal, i.e. not an exception
but printing will fail.

To prevent WebView being GC'ed we keep a reference to the webview in
AwPdfExporter, as long as frameworks owns it. Enabling proguard
optimizations optimized away this local variable. Add an explicit keep.

BUG= 664400 

Review-Url: https://codereview.chromium.org/2695123005
Cr-Commit-Position: refs/heads/master@{#450618}

[modify] https://crrev.com/5e06547be990aacac4ae3ff0382d2aa222b4280a/android_webview/apk/java/proguard.flags
[modify] https://crrev.com/5e06547be990aacac4ae3ff0382d2aa222b4280a/android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java

The latest (v57.0.2987.54; 2/15/17) Android System WebView version still causes a printer error in the stock Samsung email app, using both Samsung & HP plug-ins.

the changes landed in 58.0.3014.0. Can people following the bug, please try a chrome canary on a Android N device and make it webview provider. instructions here:


https://www.chromium.org/developers/androidwebview/android-webview-beta

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d29da5a764d976e07d45278630b696da1f281b2

commit 7d29da5a764d976e07d45278630b696da1f281b2
Author: Selim Gurun <sgurun@chromium.org>
Date: Thu Feb 16 21:33:47 2017

Keep the reference to local private variable.

Applications create a printdocumentadapter using WebView.createPrintDocumentAdapter
and passes it to Android framework, which then drives the printing flow.
If an application cleans all the references to this WebView,
then it can be GC'ed before printing flow ends. During the print UI flow,
as the user changes settings, frameworks makes calls the printdocumentadapter
that is created above, and thus WebView being GC'ed is fatal, i.e. not an exception
but printing will fail.

To prevent WebView being GC'ed we keep a reference to the webview in
AwPdfExporter, as long as frameworks owns it. Enabling proguard
optimizations optimized away this local variable. Add an explicit keep.

BUG= 664400 

Review-Url: https://codereview.chromium.org/2695123005
Cr-Commit-Position: refs/heads/master@{#450618}
(cherry picked from commit 5e06547be990aacac4ae3ff0382d2aa222b4280a)

Review-Url: https://codereview.chromium.org/2701473008 .
Cr-Commit-Position: refs/branch-heads/2987@{#559}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/7d29da5a764d976e07d45278630b696da1f281b2/android_webview/apk/java/proguard.flags
[modify] https://crrev.com/7d29da5a764d976e07d45278630b696da1f281b2/android_webview/java/src/org/chromium/android_webview/AwPdfExporter.java

this is now merged back to M57. I will keep the bug open because I want to think about some test cases that would cover this bug.

 Issue 692888  has been merged into this issue.

actually will set this to fixed to prevent confusion and will open a new bug for tests.

Tested on Android N Canary build 58.0.3019.0 and it works good!!
Can this be also tested on Android M and below installing beta version of Android Webview? 

Can you pls. advice by when it will be available in stable version? There are customers asking for this issue. 

It can be tested on M in the beta version of webview once it's in the beta, yes. The fix is in 57.0.2987.68 and higher, which haven't yet been released to beta, but will be soon.

Fix verified on Samsung Galaxy S7 Edge (SM-G935A)/MMB29M, WebView: 57.0.2987.74

Terrific. Great job.

However, AT&T has now updated most of the Samsung Galaxy 7s in the field to Nougat, and Webview is disabled in Android 7. 

Printing doesn't work in Android 7 on the Samsung Galaxy 7. That same error, or one that behaves just like it, seems to have been migrated to Nouget.

The error message is slightly different. See attached. Any ideas?

⁣Sent from TypeApp ​

On Android 7 it's provided by Chrome instead, so once Chrome is updated to 57.0.2987.68 and higher it will be fixed. You can install Chrome Beta from the play store and select it as the webview implementation in the Android developer settings to try it out sooner.

The WebView implementation is the same across all Android 5.0 and later versions, so generally the same bugs (and bug fixes) will apply.

Thank you. Please close this ticket. 

⁣Sent from TypeApp ​

YAY!!  Confirmed working on Samsung S6 Edge on AT&T.  Woo hoo!

I love it when a plan comes together.

⁣Sent from TypeApp ​

Closing this issue as fix verified. 

when I print from my HP printer its show an error on my laptop screen that printed is an error state. I reinstalled, check the connection from the laptop, but also they show an error that hp printer in error state. Can anyone tell me the solution for it VISIT HER TO GET THE SUPPORT RELATED IT? https://www.hptechsupportnumbers.com/blog/how-to-fix-hp-printer-in-an-error-state/

This issue was fixed.  This issue was an Android OS issue and has nothing to do with your Windows laptop nor your HP printer.  This was (before the bug was resolved) a SMARTPHONE issue.  It also was not specific to printing to HP printers.  Contacting HP for HP printer error issues is your best way to resolve your problem.

Follow this step to solve this issue 
Turn on your Samsung Galaxy S8 or S8 Plus.
Tap on All Apps.
Tap Settings.
Browse the settings menu for “Connect and Share” option and tap on it.
Tap on the Printing icon.
Here you will see all the printers that come pre-installed with the smartphone.
If anyone face printer issue clicks here https://www.printererrorrepair.com/blog/how-to-fix-epson-printer-error-code-0xf1/

Deleted: printrtrrrrr.jpg 9.0 KB

	printrtrrrrr.jpg 9.0 KB View Download

There are some dedicated apps for printing documents from smartphones. If the default method does not work you can use those apps for printing. Such apps are available for both Android and iPhones. For any printer issue visit https://www.hpsupporthelpline.com/blog/tag/printer-not-activated-error-code-20/