eliding in tooltip is broken |
||||
Issue descriptionm55 Chrome: 55.0.2883.42 (Official Build) beta (64-bit) Platform: 8872.44.0 (Official Build) beta-channel stumpy Repro step: 1) Bookmark https://en.wikipedia.org/wiki/List_of_law_clerks_of_the_Supreme_Court_of_the_United_States 2) Make bookmark visible 3) Move the cursor to this bookmark. let's discuss who should work on these type issues tomorrow.
,
Nov 15 2016
,
Dec 6 2016
I think this might not be a bug from my investigation. tooltip_aura allows 400 max tooltip width generally: https://cs.chromium.org/chromium/src/ui/views/corewm/tooltip_aura.cc?q=tooltip_aura&sq=package:chromium&l=201 From the unittest in elide_url_unittest.cc: https://cs.chromium.org/chromium/src/components/url_formatter/elide_url_unittest.cc?q=elide_url_&sq=package:chromium&l=64 http://subdomain.foo.com/bar/filename.html is expected to be formatted to ...foo.com/.../filename.html if available_width is restricted. So if ElideUrl rule is expected to be like this, the wikipedia link should behave like this because of 400(kTooltipMaxWidthPixels) restriction.
,
Dec 7 2016
let me take a quick look
,
Dec 22 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8658c9c6854e1a550d2adc155cb17dc8ed39e62c commit 8658c9c6854e1a550d2adc155cb17dc8ed39e62c Author: oshima <oshima@chromium.org> Date: Thu Dec 22 04:14:43 2016 Don't subtract border from max size for display rect. The display rect must be consistent with max size, otherwise the text may not fit. BUG= 664370 TEST=TooltipControllerTest.TestMaxWidth Review-Url: https://codereview.chromium.org/2556083002 Cr-Commit-Position: refs/heads/master@{#440337} [modify] https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c/ui/views/BUILD.gn [add] https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c/ui/views/corewm/test/tooltip_aura_test_api.cc [add] https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c/ui/views/corewm/test/tooltip_aura_test_api.h [modify] https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c/ui/views/corewm/tooltip_aura.cc [modify] https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c/ui/views/corewm/tooltip_aura.h [modify] https://crrev.com/8658c9c6854e1a550d2adc155cb17dc8ed39e62c/ui/views/corewm/tooltip_controller_unittest.cc
,
Jan 9 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by abodenha@chromium.org
, Nov 11 2016Labels: -OS-Chrome OS-All
Owner: ----