Issue metadata
Sign in to add a comment
|
The IME candidate window become transparent |
||||||||||||||||||||||
Issue descriptionChrome Version : 56.0.2915.0 (Official Build) dev (64-bit) Platform : 8978.0.0 (Official Build) dev-channel peppy What steps will reproduce the problem? (1) open https://www.irs.gov/pub/irs-pdf/fw4.pdf (2) set IME to Japanese (3) enter "gakkou" in input field and check the CJK candidate windows What is the expected result? What happens instead? Since the window has a transparent container, lists are hardly recognized on PDF file (pdf_ja1.png) Please provide any additional information below. Attach a screenshot if possible. Not reproducible in Chrome 56.0.2905.0/8953.0.0 - parrot (pdf_ja2.png)
,
Nov 11 2016
Marking with RB label as it is a regression issue.
,
Nov 11 2016
Narrow down to the range 56.0.2907.0 - 56.0.2915.0. Bisecting...
,
Nov 11 2016
,
Nov 11 2016
Confirming that the issue happens on the omnibox and any input fields.
,
Nov 15 2016
Bisect'ed to get the regression cl: https://codereview.chromium.org/2485793002. Over to estade@ for appropriate fix.
,
Nov 15 2016
how do I get the IME to show up? I've enabled Japanese input but typing "gakkou" doesn't seem to do anything.
,
Nov 15 2016
Try to select and enable Japanese/ "Google Japanese Input(for US keyboard)" ime. Should be able to see the candidate window while entering "gakkou" >> how do I get the IME to show up? ...
,
Nov 15 2016
I'm still not seeing it. Is there some special setup I have to do to get this on a local build of chromium? When I click on the simplified Chinese pinyin configuration button, it gives me a 404 for a chrome://extension page.
,
Nov 15 2016
I think that this is probably the correct fix, but I still haven't figured out how to test it --- https://codereview.chromium.org/2502023002/
,
Nov 16 2016
estade@, you need to deploy the chrome binary with "branding=Chrome buildtype=Official" to your device, so that it can invoke the correct version of IME extension. I've verified your cl https://codereview.chromium.org/2502023002. It can make the window in-transparent, however, the background became RED.
,
Nov 16 2016
thanks for checking. Why doesn't a chromium build work with IME? It looks like there are open source version of the ime extensions. I updated the patch, could you try again?
,
Nov 16 2016
The open source version of the ime extensions are only deployed on Chromium OS, under /usr/share/chromeos-assets/input_method/. There is no official Chromium OS published, so you would need to self-make a Chromium OS image which I don't recommend. Making a "branding=Chrome buildtype=Official" Chrome binary is easier. I've verified your cl, and it works great!
,
Nov 16 2016
super!
,
Nov 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2cb96143d90df932a11e9a21e6983f4631796008 commit 2cb96143d90df932a11e9a21e6983f4631796008 Author: estade <estade@chromium.org> Date: Thu Nov 17 03:08:05 2016 Fix background opacity/color of IME candidate window. BUG= 664363 Review-Url: https://codereview.chromium.org/2502023002 Cr-Commit-Position: refs/heads/master@{#432716} [modify] https://crrev.com/2cb96143d90df932a11e9a21e6983f4631796008/ui/chromeos/ime/candidate_window_view.cc
,
Nov 17 2016
,
Nov 17 2016
[Auto-generated comment by a script] We noticed that this issue is targeted for M-56; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-56 label, otherwise remove Merge-TBD label. Thanks.
,
Nov 22 2016
Verified. chrome 56.0.2924.3/CrOS 9000.3.0 - Pi, Clapper
,
Nov 25 2016
,
Dec 7 2016
The change landed at commit position 432716 and M-56 branched at 433059. Also verified in m-56 as per #18. Removing the merge-TBD label.
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
This bug requires manual review: No test file found in commits. Please contact the milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 16 2016
this is fallout from merging bug 660510 (which I didn't really want to do in the first place). It required two matches to be merged, and I guess I forgot about this third one. Anyway, we just have to merge https://crrev.com/2cb96143d90df932a11e9a21e6983f4631796008 Hopefully there's still time to do so.
,
Dec 16 2016
[Automated comment] removing mislabelled Merge-Review-56, Hotlist-Merge-Review
,
Dec 16 2016
Issue 675000 has been merged into this issue.
,
Dec 16 2016
,
Dec 17 2016
,
Dec 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1272d7976b721df4664bb5a0aa3c1fc0b4a591e2 commit 1272d7976b721df4664bb5a0aa3c1fc0b4a591e2 Author: Evan Stade <estade@chromium.org> Date: Sat Dec 17 00:13:45 2016 Fix background opacity/color of IME candidate window. BUG= 664363 Review-Url: https://codereview.chromium.org/2502023002 Cr-Commit-Position: refs/heads/master@{#432716} (cherry picked from commit 2cb96143d90df932a11e9a21e6983f4631796008) Review-Url: https://codereview.chromium.org/2584013003 . Cr-Commit-Position: refs/branch-heads/2883@{#748} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/1272d7976b721df4664bb5a0aa3c1fc0b4a591e2/ui/chromeos/ime/candidate_window_view.cc
,
Dec 17 2016
This broke the PFQ error snippet: chromeos-chrome-55.0.2883.101_rc-r1: FAILED: obj/ui/chromeos/chromeos/candidate_window_view.o chromeos-chrome-55.0.2883.101_rc-r1: x86_64-cros-linux-gnu-g++ -B/usr/x86_64-pc-linux-gnu/x86_64-cros-linux-gnu/binutils-bin/2.25.51-gold -MMD -MF obj/ui/chromeos/chromeos/candidate_window_view.o.d -DUI_CHROMEOS_IMPLEMENTATION -DV8_DEPRECATION_WARNINGS -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1 -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_ASH=1 -DUSE_AURA=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_NSS_CERTS=1 -DUSE_OZONE=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1 -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_RLZ -DENABLE_APP_LIST=1 -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_WAYLAND_SERVER=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -DOS_CHROMEOS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DUSE_EGL -DTOOLKIT_VIEWS=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_NOEXCEPT= -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -I../../../../../../../home/chrome-bot/chrome_root/src -Igen -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/khronos -I../../../../../../../home/chrome-bot/chrome_root/src/gpu -I/build/samus/usr/include/dbus-1.0 -I/build/samus/usr/lib64/dbus-1.0/include -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -Igen/protoc_out -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/protobuf/src -I../../../../../../../home/chrome-bot/chrome_root/src/skia/config -I../../../../../../../home/chrome-bot/chrome_root/src/skia/ext -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/c -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/config -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/core -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/effects -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/images -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/lazy -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pathops -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pdf -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/pipe -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/ports -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/utils -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/include/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/gpu -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/skia/src/sksl -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/common -I../../../../../../../home/chrome-bot/chrome_root/src/third_party/icu/source/i18n -Igen/ui/chromeos/resources -Igen/ui/chromeos/strings -Igen -Igen/ui/views/resources -fno-strict-aliasing -fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pipe -pthread -m64 -march=x86-64 -Wall -Werror -Wno-unused-local-typedefs -Wno-maybe-uninitialized -Wno-missing-field-initializers -Wno-unused-parameter -O2 -fno-ident -fdata-sections -ffunction-sections -g2 --sysroot=../../../../../../../build/samus -fvisibility=hidden -fno-threadsafe-statics -fvisibility-inlines-hidden -std=gnu++11 -Wno-narrowing -Wno-literal-suffix -fno-rtti -fno-exceptions -pipe -pipe -pipe -march=corei7 -D__google_stl_debug_vector=1 -c ../../../../../../../home/chrome-bot/chrome_root/src/ui/chromeos/ime/candidate_window_view.cc -o obj/ui/chromeos/chromeos/candidate_window_view.o chromeos-chrome-55.0.2883.101_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/chromeos/ime/candidate_window_view.cc: In constructor 'ui::ime::CandidateWindowView::CandidateWindowView(gfx::NativeView)': chromeos-chrome-55.0.2883.101_rc-r1: ../../../../../../../home/chrome-bot/chrome_root/src/ui/chromeos/ime/candidate_window_view.cc:162:25: error: 'class ui::NativeTheme' has no member named 'theme' chromeos-chrome-55.0.2883.101_rc-r1: GetNativeTheme()->theme->GetSystemColor( chromeos-chrome-55.0.2883.101_rc-r1: ^ chromeos-chrome-55.0.2883.101_rc-r1: Full log: https://uberchromegw.corp.google.com/i/chromeos_release/builders/samus-pre-flight-branch%20release-R55-8872.B/builds/295/steps/BuildPackages/logs/stdio
,
Dec 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91d57fa12796786826fa7830fb3e44ee90203f6f commit 91d57fa12796786826fa7830fb3e44ee90203f6f Author: Evan Stade <estade@chromium.org> Date: Sat Dec 17 06:07:30 2016 Fix bad merge conflict resolution from m55 merge of IME window fix. BUG= 664363 Review-Url: https://codereview.chromium.org/2586013002 . Cr-Commit-Position: refs/branch-heads/2883@{#751} Cr-Branched-From: 614d31daee2f61b0180df403a8ad43f20b9f6dd7-refs/heads/master@{#423768} [modify] https://crrev.com/91d57fa12796786826fa7830fb3e44ee90203f6f/ui/chromeos/ime/candidate_window_view.cc
,
Dec 19 2016
Problem should be resolved in 8872.73.0 / 55.0.2883.103
,
Dec 19 2016
Verified it on 8872.73.0 / 55.0.2883.103 - Candy, Daisy |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by shuchen@chromium.org
, Nov 11 2016Status: Started (was: Untriaged)