Issue metadata
Sign in to add a comment
|
MacViews ignores FocusBehavior::NEVER |
||||||||||||||||||||||||
Issue descriptionDiscovered as part of https://codereview.chromium.org/2491773002 Possibly the root cause of Issue 660230 .
,
Nov 10 2016
Does FocusBehavior::NEVER mean that a screen reader should ignore it? Focus usually refers to keyboard focus. Screen readers typically allow access to all content, because otherwise there'd be no way to read static text and anything else other than a form control.
,
Nov 11 2016
The enum values seem to suggest so:
enum class FocusBehavior {
// Use when the View is never focusable. Default.
NEVER,
// Use when the View is to be focusable both in regular and accessibility
// mode.
ALWAYS,
// Use when the View is focusable only during accessibility mode.
ACCESSIBLE_ONLY,
};
Non-Mac Views platforms might do so if this is the root cause of Issue 660230 , but I haven't had enough time to investigate that.
,
Nov 11 2016
`accessibility mode` in this case (at least on Mac) refers mainly to "Full Keyboard Access" in System Preferences, as opposed to VoiceOver. View::IsAccessibilityFocusable() doesn't seem to be used outside of ui/views/focus/focus_manager.cc . Maybe this wasn't always the case, since it predates MacViews. (Karan might know more). There's some conceptual overlap, but I don't think we're leveraging View::FocusBehavior yet for VoiceOver and other screen readers.
,
Nov 11 2016
Oh, I see. That's unintuitive from reading the code alone, but I guess working as intended?
,
Nov 11 2016
Yeah from what I know, the FocusBehavior enum and the View::IsFocusable and View::IsAccessibilityFocusable methods are just used for keyboard focus. I am not aware of any usages for accessibility (used in the screen reader sense). As Trent suggested, the "accessibility mode" in the enum definition suggests a mode where more views are focusable. On Mac, this is the Full Keyboard access mode. On other platforms, it is used for example when we are traversing through say the Bookmarks Bar, where buttons are also focusable through the keyboard. (They are generally not) I think the terminology could have been a better, since it's easy to confuse between keyboard accessibility(focus) and accessibility in the screen reader sense, but this terminology has been used for a long time now.
,
Dec 6 2016
Closing as it's working as intended. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by lgar...@chromium.org
, Nov 10 2016Owner: patricia...@chromium.org