New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 664307 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
inactive
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Remove content detectors in the renderer

Project Member Reported by twelling...@chromium.org, Nov 10 2016

Issue description

As part of quick actions support, content detectors in the renderer are being removed. For one milestone they will be disabled, but not fully removed. After that they can (and should be) removed entirely.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2449b35f7561d4374347605b0b234d781f971297

commit 2449b35f7561d4374347605b0b234d781f971297
Author: twellington <twellington@chromium.org>
Date: Fri Nov 11 01:45:03 2016

Disable content intent detectors in the renderer

BUG= 664307 ,657063

Review-Url: https://codereview.chromium.org/2496763002
Cr-Commit-Position: refs/heads/master@{#431448}

[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/public/android/javatests/src/org/chromium/content/browser/EmailAddressDetectionTest.java
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/public/common/content_switches.cc
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/public/common/content_switches.h
[modify] https://crrev.com/2449b35f7561d4374347605b0b234d781f971297/content/renderer/render_view_impl.cc

Comment 2 by aelias@chromium.org, Mar 20 2017

Cc: aelias@chromium.org
This has gone stable so we can start with the deletion.  Copy-pasting what I wrote on a thread about the little that needs to be preserved in WebView:

"I looked into the implementation of the WebView public APIs and I believe we can delete a majority of the content detection code without regressing any public API behavior.

On Tue, Nov 8, 2016 at 4:05 PM, Bo Liu <boliu@google.com> wrote:
> Also usage of these content detectors is a bit wider in chrome than webview:
> * fire intents if user clicks on an address/phone number, same as chrome
> * implement these hittest schemes, which are then used by apps to populate their context menu

As far as I see, this actually does not use the content detector at all today.  All it does is a simple scan of a link URL to see if it starts mailto://, geo:// or tel://.  See aw_render_frame_ext.cc
 
> * implement webview.findAddress

This uses the static method findAddress but not anything else.  See content_view_statics.cc

So I think we should go forward with deleting everything except for findAddress and the methods it depends on.

Comment 3 by aelias@chromium.org, Mar 31 2017

Cc: twelling...@chromium.org
Labels: -Restrict-View-Google
Owner: aelias@chromium.org
I'm preparing a deletion patch.
Deletion patch up at https://codereview.chromium.org/2790893004
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7d91597c0438dc21291f862ce0dd920abd11bc4

commit b7d91597c0438dc21291f862ce0dd920abd11bc4
Author: aelias <aelias@chromium.org>
Date: Thu Apr 06 19:57:30 2017

Delete Android content detectors.

This feature has been replaced by contextual search, which
provides a superset of the functionality with a better UI.
It's been disabled behind a flag for one release and is now
ready for removal.

Note that content/common/android/address_parser.cc is not
deleted, because it's still in use by WebView.findAddress() public
API.

BUG= 664307 

Review-Url: https://codereview.chromium.org/2790893004
Cr-Commit-Position: refs/heads/master@{#462596}

[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/android_webview/java/src/org/chromium/android_webview/AwViewAndroidDelegate.java
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientShouldOverrideUrlLoadingTest.java
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/chrome/android/java/src/org/chromium/chrome/browser/tab/TabViewAndroidDelegate.java
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/browser/renderer_host/render_widget_host_view_android.cc
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/browser/renderer_host/render_widget_host_view_android.h
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/common/view_messages.h
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/public/android/BUILD.gn
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/public/android/java/src/org/chromium/content/common/ContentSwitches.java
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/public/android/javatests/src/org/chromium/content/browser/AddressDetectionTest.java
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/public/android/javatests/src/org/chromium/content/browser/ClickListenerTest.java
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionActivityTestRule.java
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestBase.java
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/public/android/javatests/src/org/chromium/content/browser/ContentDetectionTestCommon.java
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/public/android/javatests/src/org/chromium/content/browser/EmailAddressDetectionTest.java
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/public/android/javatests/src/org/chromium/content/browser/PhoneNumberDetectionTest.java
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/public/common/content_switches.cc
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/public/common/content_switches.h
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/renderer/BUILD.gn
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/address_detector.cc
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/address_detector.h
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/content_detector.cc
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/content_detector.h
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/email_detector.cc
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/email_detector.h
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/email_detector_unittest.cc
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/phone_number_detector.cc
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/phone_number_detector.h
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/renderer/android/phone_number_detector_unittest.cc
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/renderer/render_view_impl.cc
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/renderer/render_view_impl.h
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/shell/android/java/src/org/chromium/content_shell/ShellViewAndroidDelegate.java
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/content/test/BUILD.gn
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/click_listeners.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/email.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/empty.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/geo_address_limits.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/geo_address_multiple.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/geo_address_real.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/geo_address_special_chars.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/geo_address_split.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/phone_international.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/content/test/data/android/content_detection/phone_local.html
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/third_party/WebKit/Source/web/WebViewImpl.h
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/third_party/WebKit/Source/web/tests/data/content_listeners.html
[delete] https://crrev.com/cf38158add6214df8d0779816c854429ccc6208e/third_party/WebKit/Source/web/tests/data/content_listeners_iframe.html
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/third_party/WebKit/public/web/WebViewClient.h
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/ui/android/java/src/org/chromium/ui/base/ViewAndroidDelegate.java
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/ui/android/view_android.cc
[modify] https://crrev.com/b7d91597c0438dc21291f862ce0dd920abd11bc4/ui/android/view_android.h

Status: Fixed (was: Started)

Sign in to add a comment