New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 664293 link

Starred by 1 user
Status: Fixed
Owner:
groeck@chromium.org
Closed: Nov 2016
Cc:
bleung@chromium.org
█ dtor@chromium.org
█ erik.alm...@fingerprints.com
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Build errors in fingerprint driver

Project Member Reported by groeck@chromium.org, Nov 10 2016 
drivers/misc/fpc1020.c:511:1: warning: data definition has no type or storage class [enabled by default]
drivers/misc/fpc1020.c:511:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
drivers/misc/fpc1020.c:511:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/misc/fpc1020.c:556:1: warning: data definition has no type or storage class [enabled by default]
drivers/misc/fpc1020.c:556:1: error: type defaults to 'int' in declaration of 'module_init' [-Werror=implicit-int]
drivers/misc/fpc1020.c:556:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/misc/fpc1020.c:564:1: warning: data definition has no type or storage class [enabled by default]
drivers/misc/fpc1020.c:564:1: error: type defaults to 'int' in declaration of 'module_exit' [-Werror=implicit-int]
drivers/misc/fpc1020.c:564:1: warning: parameter names (without types) in function declaration [enabled by default]
drivers/misc/fpc1020.c:566:15: error: expected declaration specifiers or '...' before string constant
drivers/misc/fpc1020.c:567:20: error: expected declaration specifiers or '...' before string constant
drivers/misc/fpc1020.c:568:16: error: expected declaration specifiers or '...' before string constant
drivers/misc/fpc1020.c:569:14: error: expected declaration specifiers or '...' before string constant
drivers/misc/fpc1020.c:524:19: warning: 'fpc1020_init' defined but not used [-Wunused-function]
drivers/misc/fpc1020.c:558:20: warning: 'fpc1020_exit' defined but not used [-Wunused-function]

Comment 1 by groeck@chromium.org, Nov 10 2016 

Also:

drivers/misc/fpc1020.c:519:3: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration]
   .of_match_table = of_match_ptr(fpc_of_match),
   ^
drivers/misc/fpc1020.c:519:3: error: initializer element is not constant
drivers/misc/fpc1020.c:519:3: error: (near initialization for 'fpc1020_spi_driver.driver.of_match_table')

seen with m68k:allmodconfig.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 11 2016

Labels: merge-merged-chromeos-4.4
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/2130f08c2ee329205c03ce864497d698ffc0ab76

commit 2130f08c2ee329205c03ce864497d698ffc0ab76
Author: Guenter Roeck <groeck@chromium.org>
Date: Thu Nov 10 21:26:44 2016

FIXUP: CHROMIUM: misc: Add fpc fingerprint sensor driver

Build failures observed:

drivers/misc/fpc1020.c:511:1: warning:
	data definition has no type or storage class
drivers/misc/fpc1020.c:511:1: error:
	type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE'
drivers/misc/fpc1020.c:511:1: warning:
	parameter names (without types) in function declaration
drivers/misc/fpc1020.c:556:1: warning:
	data definition has no type or storage class
drivers/misc/fpc1020.c:556:1: error:
	type defaults to 'int' in declaration of 'module_init'

and so on. This was seen when building mips:allmodconfig.

After fixing this, the following error was seen with m68k:allmodconfig.

drivers/misc/fpc1020.c:519:3: error:
	implicit declaration of function 'of_match_ptr'
drivers/misc/fpc1020.c:519:3: error: initializer element is not constant

BUG= chromium:664293 
TEST=Build mips:allmodconfig, m68k:allmodconfig

Change-Id: Ia640e77540d6f13b24cb20018573bdc9c54cb518
Signed-off-by: Guenter Roeck <groeck@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/410220
Reviewed-by: Benson Leung <bleung@chromium.org>

[modify] https://crrev.com/2130f08c2ee329205c03ce864497d698ffc0ab76/drivers/misc/fpc1020.c

Comment 3 by groeck@chromium.org, Nov 11 2016

Status: Fixed (was: Started)
►

Sign in to add a comment